Add CI check for full validation mode #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Apr 12, 2022
|
|
||
| // Provide a force_validate mode | ||
| #[cfg(feature = "force_validate")] | ||
| new_self.validate_full().unwrap(); |
There was a problem hiding this comment.
Here is the validation call
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
==========================================
- Coverage 82.82% 82.82% -0.01%
==========================================
Files 190 190
Lines 54941 54943 +2
==========================================
- Hits 45507 45506 -1
- Misses 9434 9437 +3
Continue to review full report at Codecov.
|
tustvold
approved these changes
Apr 12, 2022
|
|
||
| // Provide a force_validate mode | ||
| #[cfg(feature = "force_validate")] | ||
| new_self.validate_full().unwrap(); |
tustvold
reviewed
Apr 12, 2022
| @@ -1692,6 +1692,9 @@ mod tests { | |||
| } | |||
|
|
|||
| #[test] | |||
| // Fails when validation enabled | |||
There was a problem hiding this comment.
at least we know there is a problem. So it is progress 🤷 we'll get it fixed
viirya
approved these changes
Apr 14, 2022
|
I will try and polish this up shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1544
Closes #1239
Rationale for this change
We have a full validation mode that validates the full contents of creating Arrays but it is (on purpose) not called in many places in arrow for performance reasons: https://docs.rs/arrow/11.1.0/arrow/array/struct.ArrayData.html#method.validate_full
This leads to two possible issues:
What changes are included in this PR?
force_validatefeature flag that forced the validation check for all array creations (defaults to off)Found / filed new tickets or existing tickets:
filterproduces invalid sparseUnionArrays #1547ipc::reader::tests::projection_should_workfails validation #1548substringkernel #1531Are there any user-facing changes?
New optional feature
force_validate