Fix incorrect into_buffers for UnionArray
#1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
changed the title
into_buffers for UnionArray
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #1567 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 190 190
Lines 55042 55055 +13
=======================================
+ Hits 45608 45621 +13
Misses 9434 9434
Continue to review full report at Codecov.
|
tustvold
approved these changes
Apr 14, 2022
|
Thanks @tustvold . Okay, I will add a test for this. |
viirya
commented
Apr 14, 2022
arrow/src/array/data.rs
Outdated
Comment on lines
2606
to
2609
| let data_types = vec![ | ||
| DataType::Union(vec![], UnionMode::Sparse), | ||
| DataType::Union(vec![], UnionMode::Sparse), | ||
| ]; |
There was a problem hiding this comment.
We can add more datatypes if needed.
viirya
commented
Apr 14, 2022
| @@ -1692,9 +1692,6 @@ mod tests { | |||
| } | |||
|
|
|||
| #[test] | |||
| // Fails when validation enabled | |||
| // https://github.com/apache/arrow-rs/issues/1547 | |||
| #[cfg(not(feature = "force_validate"))] | |||
| fn test_filter_union_array_sparse() { | |||
|
Thank you @tustvold ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1547.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?