Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parquet benchmarks #1723

Merged
merged 2 commits into from
May 24, 2022
Merged

Fix parquet benchmarks #1723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdc11cf
Fix parquet benchmarks
tustvold May 22, 2022
3e2bcc7
Format
tustvold May 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ jobs:
run: |
export CARGO_HOME="/github/home/.cargo"
export CARGO_TARGET_DIR="/github/home/target"
cargo check --benches --workspace
cargo check --benches --workspace --features test_common,prettyprint,async,experimental

lint:
name: Lint (cargo fmt)
Expand Down
7 changes: 2 additions & 5 deletions parquet/benches/arrow_reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,7 @@ where
let mut pages: Vec<Vec<parquet::column::page::Page>> = Vec::new();
for _i in 0..NUM_ROW_GROUPS {
let mut column_chunk_pages = VecDeque::new();
let mem_tracker = Arc::new(parquet::memory::MemTracker::new());
let mut dict_encoder = DictEncoder::<T>::new(column_desc.clone(), mem_tracker);
let mut dict_encoder = DictEncoder::<T>::new(column_desc.clone());
// add data pages
for _j in 0..PAGES_PER_GROUP {
// generate page
Expand Down Expand Up @@ -239,9 +238,7 @@ fn build_dictionary_encoded_string_page_iterator(
let mut pages: Vec<Vec<parquet::column::page::Page>> = Vec::new();
for _i in 0..NUM_ROW_GROUPS {
let mut column_chunk_pages = VecDeque::new();
let mem_tracker = Arc::new(parquet::memory::MemTracker::new());
let mut dict_encoder =
DictEncoder::<ByteArrayType>::new(column_desc.clone(), mem_tracker);
let mut dict_encoder = DictEncoder::<ByteArrayType>::new(column_desc.clone());
// add data pages
for _j in 0..PAGES_PER_GROUP {
// generate page
Expand Down