-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up arrow::array::builder module (#1843) #1879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this 👍, I plan to go through this this evening unless someone else gets there first. Left some minor comments from a cursory run through.
Edit: CI appears to be unhappy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @DaltonModlin
this PR appears to have a conflict -- could you possible resolve it and I will then merge it in?
Thanks!
96f3c47
to
005283a
Compare
- Removed old builder.rs - Added missing licensing header to builder submodules - Updated builder submodule imports and exports - Updated array mod file builder imports and exports
005283a
to
c7c6cb7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1879 +/- ##
==========================================
- Coverage 83.48% 83.47% -0.02%
==========================================
Files 203 214 +11
Lines 57141 57163 +22
==========================================
+ Hits 47705 47717 +12
- Misses 9436 9446 +10
Continue to review full report at Codecov.
|
Thanks again @DaltonModlin |
Which issue does this PR close?
Closes #1843
Rationale for this change
Currently, arrow::array::builder contains 12 distinct builders; breaking the builders into submodules makes test coverage and functional differences more obvious.
Are there any user-facing changes?
No