-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete and fixup split of arrow::array::builder
module (#1843)
#1928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- thanks @tustvold
arrow::array::builder
module (#1843)
Codecov Report
@@ Coverage Diff @@
## master #1928 +/- ##
==========================================
+ Coverage 83.41% 83.42% +0.01%
==========================================
Files 214 217 +3
Lines 57004 56981 -23
==========================================
- Hits 47550 47538 -12
+ Misses 9454 9443 -11
Continue to review full report at Codecov.
|
We also lost #1842 |
Which issue does this PR close?
Closes #1843
Rationale for this change
See below
What changes are included in this PR?
Follow on to #1879 which
Are there any user-facing changes?
No