Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

into_inner() for CSV Writer #3759

Merged
merged 1 commit into from
Feb 25, 2023
Merged

into_inner() for CSV Writer #3759

merged 1 commit into from
Feb 25, 2023

Conversation

Weijun-H
Copy link
Member

Which issue does this PR close?

Closes #520

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 24, 2023
tustvold
tustvold approved these changes Feb 25, 2023
View reviewed changes
arrow-csv/src/writer.rs

/// Unwraps this `Writer<W>`, returning the underlying writer
pub fn into_inner(self) -> W {
self.writer.into_inner().unwrap()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a comment here saying the unwrap is fine because write always flushes, assuming that is actually the case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It make sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant an inline comment, not a doc comment, no need to document this for outside consumers

@Weijun-H Weijun-H force-pushed the inner_function_for_csv_writer branch from 7400261 to f1fa6c0 Compare February 25, 2023 18:00
@Weijun-H Weijun-H requested a review from tustvold February 25, 2023 18:00
@Weijun-H Weijun-H force-pushed the inner_function_for_csv_writer branch from f1fa6c0 to 6eccb1f Compare February 25, 2023 18:53
@tustvold tustvold merged commit 96791ea into apache:master Feb 25, 2023
@ursabot
Copy link

ursabot commented Feb 25, 2023

Benchmark runs are scheduled for baseline = d016403 and contender = 96791ea. 96791ea is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@Weijun-H Weijun-H deleted the inner_function_for_csv_writer branch February 25, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold Awaiting requested review from tustvold

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

into_inner() for CSV Writer
3 participants
@Weijun-H @ursabot @tustvold