Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

into_inner() for CSV Writer #3759

Merged
merged 1 commit into from
Feb 25, 2023
Merged

into_inner() for CSV Writer #3759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions arrow-csv/src/writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,12 @@ impl<W: Write> Writer<W> {

Ok(())
}

/// Unwraps this `Writer<W>`, returning the underlying writer.
pub fn into_inner(self) -> W {
// Safe to call `unwrap` since `write` always flushes the writer.
self.writer.into_inner().unwrap()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a comment here saying the unwrap is fine because write always flushes, assuming that is actually the case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It make sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant an inline comment, not a doc comment, no need to document this for outside consumers

}
}

/// A CSV writer builder
Expand Down