Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Built on #532 so review that one first
Closes #529
Rationale for this change
Arrow does not build today unless
rand 0.8
is included as another dependency of the project; I introduced this in #488 when I upgraded the rand dependency but disabled the default features (which require sys which mean arrow can't be built on webasm anymore)Since the only use of the
sys
part of the rand dependency is in benchmarks and testing code, I propose simply not building that part of of the arrow crate if default features are turned offWhat changes are included in this PR?
#ifdef
out their use when arrows default features are disabledAre there any user-facing changes?
There is a
test_utils
feature flag now, enabled by default, that gates what parts of arrow are compiled if the default features are turned off