Add tests for building with feature gates ["simd"] #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 167 167
Lines 45984 45984
=======================================
Hits 37984 37984
Misses 8000 8000
Continue to review full report at Codecov.
|
alamb
force-pushed
the
alamb/fix-simd-flag-builds
branch
from
7ef5319 to
0eb3c3b
Compare
nevi-me
approved these changes
Jul 12, 2021
| @@ -591,7 +591,7 @@ where | |||
|
|
|||
| let bitmask = T::mask_to_u64(&simd_result); | |||
| let bytes = bitmask.to_le_bytes(); | |||
| &result_slice[0..lanes / 8].copy_from_slice(&bytes[0..lanes / 8]); | |||
| result_slice[0..lanes / 8].copy_from_slice(&bytes[0..lanes / 8]); | |||
There was a problem hiding this comment.
Seems unrelated, was it a needless borrow clippy lint?
There was a problem hiding this comment.
Yes -- sorry -- I should have mentioned that. When I was testing the project with simd locally this was flagged as a compiler warning so I fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #458
Built on #532 and #533 so review them first
Rationale for this change
There are reports #458 that user applications can't be built against arrow using the simd feature gate and I wanted to increase test coverage. However, arrow still doesn't seem to build from crates.io 🤔
What changes are included in this PR?
tests and clean up some warnings
Are there any user-facing changes?
no