Fix string '0' cast to decimal with scale 0 #6547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/fix-string-0-cast-to-decimal-with-scale-0-bc5f5f
branch
from
2b184f4
to
6240664
Compare
Before the change, the cast used to fail or return null, depending on cast options.
findepi
force-pushed
the
findepi/fix-string-0-cast-to-decimal-with-scale-0-bc5f5f
branch
from
6240664
to
3a035fc
Compare
|
cc @alamb |
Xuanwo
reviewed
Oct 11, 2024
findepi
deleted the
findepi/fix-string-0-cast-to-decimal-with-scale-0-bc5f5f
branch
findepi
added a commit
to sdf-labs/arrow-rs
that referenced
this pull request
Oct 30, 2024
* Fix string '0' cast to decimal with scale 0 Before the change, the cast used to fail or return null, depending on cast options. * Add more test cases
findepi
added a commit
to sdf-labs/arrow-rs
that referenced
this pull request
Oct 31, 2024
* Fix string '0' cast to decimal with scale 0 Before the change, the cast used to fail or return null, depending on cast options. * Add more test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, the cast used to fail or return null, depending on cast options.
Which issue does this PR close?
'0'todecimal(p,0)datafusion#12870castfromStringArraytoDecimal128ArrayandDecimal256Arraydoesn't work on 0 #5876Rationale for this change
Correctness fix
What changes are included in this PR?
Fix to cast from string to decimal.
Are there any user-facing changes?
Yes, behavior changes