Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Fix string '0' cast to decimal with scale 0 (#6547) #1

Conversation

findepi
Copy link
Collaborator

@findepi findepi commented Oct 30, 2024

Backport apache#6547

* Fix string '0' cast to decimal with scale 0

Before the change, the cast used to fail or return null, depending on
cast options.

* Add more test cases
Copy link

@vgapeyev vgapeyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's good for Arrow folks, ought to be good for me!

@findepi
Copy link
Collaborator Author

findepi commented Oct 31, 2024

And it ought to be good for CI too.
It looks like failures are unrelated.

@findepi findepi force-pushed the findepi/sdf/52.2.0/fix-string-0-cast-to-decimal-with-scale-0-6547-c0a842 branch from d0fb377 to 069d147 Compare October 31, 2024 13:03
@github-actions github-actions bot removed the parquet label Oct 31, 2024
@findepi findepi force-pushed the findepi/sdf/52.2.0/fix-string-0-cast-to-decimal-with-scale-0-6547-c0a842 branch from 069d147 to 82d3f85 Compare October 31, 2024 13:12
* Fix `test_private_bucket` test

* remove test
@findepi findepi merged commit 7980eed into sdf/52.2.0 Oct 31, 2024
33 checks passed
@findepi findepi deleted the findepi/sdf/52.2.0/fix-string-0-cast-to-decimal-with-scale-0-6547-c0a842 branch October 31, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants