[Website] Add release note for 5.0.0 including the rust contributions #131
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
_release/5.0.0.md
Outdated
| The following Apache committers merged contributed patches to Arrow repositories. | ||
|
|
||
| ```console | ||
| 150 GitHub |
There was a problem hiding this comment.
@thisisnic it looks like all the arrow-rs commits are listing the committer as GitHub
There was a problem hiding this comment.
Correctly, since the PRs get merged with the Squash and Merge button from the Github UI.
There was a problem hiding this comment.
Author: Author's name <Author's email>
AuthorDate: Thu Jul 29 04:53:14 2021 +1000
Commit: GitHub <noreply@github.com>
CommitDate: Wed Jul 28 14:53:14 2021 -0400
There was a problem hiding this comment.
@alamb do you know why git shortlog outputs GitHub as the committer for most of the arrow-rs commits?
git shortlog --summary --group=committer 4.0.0..5.0.0
3 Andy Grove
138 GitHub
20 Jorge C. Leitao
There was a problem hiding this comment.
Ugh, apparently when the PR author is also the committer, GitHub uses GitHub <noreply@github.com> as the committer. For the Arrow monorepo this doesn't happen, I assume because we use the merge script.
There was a problem hiding this comment.
Shall we just remove this entry for now?
We can handle this scenario in https://issues.apache.org/jira/browse/ARROW-13483 for the next release.
There was a problem hiding this comment.
I applied a manual fix in #133 to add in the actual Rust committers
There was a problem hiding this comment.
Sorry, no idea why I didn't realise this was wrong and flag it up, thanks for sorting it @ianmcook
kszucs
changed the title
No description provided.