Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-12701: [Website][Release] Include Rust contributors, committers, and commits in release notes #10774

Closed
wants to merge 13 commits into from
Closed

ARROW-12701: [Website][Release] Include Rust contributors, committers, and commits in release notes #10774

wants to merge 13 commits into from

Conversation

thisisnic
Copy link
Member

@thisisnic thisisnic commented Jul 22, 2021 •
edited by ianmcook
Loading

Note: this PR does not include DataFusion commits because it is not yet clear what release schedule and tagging conventions will be used for the DataFusion repo.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-12701

@ianmcook ianmcook mentioned this pull request Jul 22, 2021
Closed
@thisisnic thisisnic changed the title ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note [WIP] ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note Jul 23, 2021
@thisisnic thisisnic marked this pull request as ready for review July 23, 2021 16:16
jonkeane
jonkeane reviewed Jul 23, 2021
View reviewed changes
Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few comments

dev/release/post-03-website.sh Show resolved Hide resolved
dev/release/post-03-website.sh Outdated Show resolved Hide resolved
dev/release/post-03-website.sh Outdated Show resolved Hide resolved
dev/release/post-03-website.sh Show resolved Hide resolved
@ianmcook
Copy link
Member

Thanks for doing this @thisisnic! Could you also please change how n_commits is calculated? It should iterate over directories and total up all the commits.

@thisisnic
Copy link
Member Author

Thanks for doing this @thisisnic! Could you also please change how n_commits is calculated? It should iterate over directories and total up all the commits.

Done

This was referenced Jul 27, 2021
Merged
Closed
@ianmcook ianmcook changed the title ARROW-12701: [Website][Release] Include Rust and DataFusion commits, contributors, changes in release note ARROW-12701: [Website][Release] Include Rust commits and contributors in release notes Jul 28, 2021
@ianmcook ianmcook changed the title ARROW-12701: [Website][Release] Include Rust commits and contributors in release notes ARROW-12701: [Website][Release] Include Rust contributors, committers, and commits in release notes Jul 28, 2021
kszucs
kszucs approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thisisnic!

@kszucs
Copy link
Member

kszucs commented Jul 28, 2021

Created a follow-up ticket to port the release note generation to archery at some point: https://issues.apache.org/jira/browse/ARROW-13483

@kszucs
Copy link
Member

kszucs commented Jul 28, 2021 •
edited by ianmcook
Loading

Regenerated the release note for 5.0.0 with this patch: apache/arrow-site#131

@ianmcook
Copy link
Member

Regenerated the release note for 5.0.0 with this patch: apache/arrow-site#131

Thanks! @thisisnic there's a problem with the Rust committers; please see https://github.com/apache/arrow-site/pull/131/files#r678709259

@ianmcook
Copy link
Member

@thisisnic I manually fixed the problem with the Rust committers and applied the fix in apache/arrow-site#133. So we're OK for the 5.0.0 release and there's no great urgency, but let's fix the problem before we merge this PR.

@thisisnic
Copy link
Member Author

@ianmcook Do you remember what you did to get the correct list on this ticket? I've been looking into it but a lot of what I find online is people complaining that they can't find that information after a squash & merge.

@thisisnic
Copy link
Member Author

Closing this ancient PR and starting again in a new one

@thisisnic thisisnic closed this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkeane jonkeane jonkeane left review comments

@kszucs kszucs kszucs approved these changes

@ianmcook ianmcook ianmcook approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thisisnic @ianmcook @kszucs @jonkeane