Skip to content

Commit

Permalink
Adress java comments
Browse files Browse the repository at this point in the history
  • Loading branch information
emkornfield committed Oct 22, 2020
1 parent cfa3513 commit 438ca49
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public void endList() {

<#list vv.types as type><#list type.minor as minor><#assign name = minor.class?cap_first />
<#assign fields = minor.fields!type.fields />
<#if minor.class != "Decimal" && minor.class != "BigDecimal">
<#if minor.class != "Decimal" && minor.class != "Decimal256">
@Override
public void write(${name}Holder holder) {
getWriter(MinorType.${name?upper_case}).write(holder);
Expand Down Expand Up @@ -108,7 +108,7 @@ public void writeBigEndianBytesToDecimal(byte[] value) {
}
<#elseif minor.class == "Decimal256">
@Override
public void write(BigDecimalHolder holder) {
public void write(Decimal256Holder holder) {
getWriter(MinorType.DECIMAL256).write(holder);
}
Expand Down
2 changes: 1 addition & 1 deletion java/vector/src/main/codegen/templates/ArrowType.java
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public static class ${name} extends <#if type.complex>ComplexType<#else>Primitiv
<#if type.name == "Decimal">
// Needed to support golden file integration tests.
@JsonCreator
public static Decimal createDecimal128(
public static Decimal createDecimal(
@JsonProperty("precision") int precision,
@JsonProperty("scale") int scale,
@JsonProperty("bitWidth") Integer bitWidth) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ public void writeBigEndianBytesToDecimal(byte[] value, ArrowType arrowType){
writer.setPosition(writer.idx() + 1);
}

public void writeDecimal256(int start, ArrowBuf buffer, ArrowType arrowType) {
public void writeDecimal256(long start, ArrowBuf buffer, ArrowType arrowType) {
writer.writeDecimal256(start, buffer, arrowType);
writer.setPosition(writer.idx()+1);
}
Expand Down
2 changes: 1 addition & 1 deletion testing

0 comments on commit 438ca49

Please sign in to comment.