Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Second block of refactoring to move acero out of libarrow #34630

Closed
Tracked by #15280
assignUser opened this issue Mar 18, 2023 · 1 comment · Fixed by #34575
Closed
Tracked by #15280

[C++] Second block of refactoring to move acero out of libarrow #34630

assignUser opened this issue Mar 18, 2023 · 1 comment · Fixed by #34575
Assignees
@ildipo
Labels
Component: C++ Type: enhancement
Milestone
12.0.0

Comments

@assignUser
Copy link
Member

Describe the enhancement requested

This is the second and last block of refactoring before moving acero out of libarrow.

Component(s)

C++
@assignUser assignUser mentioned this issue Mar 18, 2023
Closed
1 task
@github-actions github-actions bot mentioned this issue Mar 18, 2023
Merged
@ildipo
Copy link
Contributor

ildipo commented Mar 18, 2023

take

icexelloss pushed a commit that referenced this issue Mar 18, 2023
@ildipo
GH-34630: [C++] Second block of refactoring to move acero out of liba…
8524572 
…rrow (#34575)

### Rationale for this change

This is the second and last block of refactoring before moving acero out
of libarrow. This PR removes the remaining dependencies from libarrow
into the compute/exec directory.

### What changes are included in this PR?

In detail:

* compute/exec/expression is moved inside compute since it is needed in
several kernels
* all compute/exec specific include files are removed from compute/api.h
* light_array_exec_test.cc i(introduced in the previous refactoring) s
merged back into light_array_test
* testing generators are refactored to remove the need for
exec/options.h
* some utilities are moved from compute/exec/util to compute/util
* updated python and r libraries usage of moved files

### Are these changes tested?

Yes using existing tests (some of which have been updated due to
refactoring).

### Are there any user-facing changes?

no
* Issue: #15280
* Closes: #34630
@kou kou added this to the 12.0.0 milestone Mar 18, 2023
rtpsw pushed a commit to rtpsw/arrow that referenced this issue Mar 27, 2023
@ildipo @rtpsw
apacheGH-34630: [C++] Second block of refactoring to move acero out o…
3efa39e 
…f libarrow (apache#34575)

### Rationale for this change

This is the second and last block of refactoring before moving acero out
of libarrow. This PR removes the remaining dependencies from libarrow
into the compute/exec directory.

### What changes are included in this PR?

In detail:

* compute/exec/expression is moved inside compute since it is needed in
several kernels
* all compute/exec specific include files are removed from compute/api.h
* light_array_exec_test.cc i(introduced in the previous refactoring) s
merged back into light_array_test
* testing generators are refactored to remove the need for
exec/options.h
* some utilities are moved from compute/exec/util to compute/util
* updated python and r libraries usage of moved files

### Are these changes tested?

Yes using existing tests (some of which have been updated due to
refactoring).

### Are there any user-facing changes?

no
* Issue: apache#15280
* Closes: apache#34630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ildipo ildipo

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34630: [C++] Second block of refactoring to move acero out of libarrow ildipo/arrow
3 participants
@kou @ildipo @assignUser