Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Accessing values of a decimal array doesn't account for the array offset #41199

Closed
adamreeve opened this issue Apr 15, 2024 · 1 comment
Closed

[C#] Accessing values of a decimal array doesn't account for the array offset #41199

adamreeve opened this issue Apr 15, 2024 · 1 comment
Assignees
@adamreeve
Labels
Component: C# Type: bug
Milestone
17.0.0

Comments

@adamreeve
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

Decimal128Array.GetValue, GetString and GetSqlDecimal account for the array offset in the null check but not when getting the actual value.

Decimal256Array.GetValue, GetString and TryGetSqlDecimal have the same issue.

Component(s)

C#
@github-actions github-actions bot mentioned this issue Apr 15, 2024
Merged
CurtHagenlocher pushed a commit that referenced this issue Apr 15, 2024
@adamreeve
GH-41199: [C#] Fix accessing values of a sliced decimal array (#41200)
fec096a 
### Rationale for this change

Fixes a bug where getting values from a sliced `Decimal128Array` or `Decimal256Array` would return the wrong values.

### What changes are included in this PR?

Updates the various `Get*` methods in `Decimal128Array` and `Decimal256Array` to account for the array offset.

### Are these changes tested?

Yes, I've added new unit tests.

### Are there any user-facing changes?

Yes, this is a user-facing bug fix.
* GitHub Issue: #41199

Authored-by: Adam Reeve <adreeve@gmail.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
@CurtHagenlocher CurtHagenlocher added this to the 17.0.0 milestone Apr 15, 2024
@CurtHagenlocher
Copy link
Contributor

Issue resolved by pull request 41200
#41200

tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@adamreeve @tolleybot
apacheGH-41199: [C#] Fix accessing values of a sliced decimal array (a…
70f8f99 
…pache#41200)

### Rationale for this change

Fixes a bug where getting values from a sliced `Decimal128Array` or `Decimal256Array` would return the wrong values.

### What changes are included in this PR?

Updates the various `Get*` methods in `Decimal128Array` and `Decimal256Array` to account for the array offset.

### Are these changes tested?

Yes, I've added new unit tests.

### Are there any user-facing changes?

Yes, this is a user-facing bug fix.
* GitHub Issue: apache#41199

Authored-by: Adam Reeve <adreeve@gmail.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@adamreeve @vibhatha
apacheGH-41199: [C#] Fix accessing values of a sliced decimal array (a…
f43ff76 
…pache#41200)

### Rationale for this change

Fixes a bug where getting values from a sliced `Decimal128Array` or `Decimal256Array` would return the wrong values.

### What changes are included in this PR?

Updates the various `Get*` methods in `Decimal128Array` and `Decimal256Array` to account for the array offset.

### Are these changes tested?

Yes, I've added new unit tests.

### Are there any user-facing changes?

Yes, this is a user-facing bug fix.
* GitHub Issue: apache#41199

Authored-by: Adam Reeve <adreeve@gmail.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamreeve adamreeve

Labels
Component: C# Type: bug
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@adamreeve @CurtHagenlocher