GH-41199: [C#] Fix accessing values of a sliced decimal array #41200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CurtHagenlocher
approved these changes
Apr 15, 2024
To be fair it looks like slicing wasn't considered in a lot of the existing code either so that's understandable |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit fec096a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them. |
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 2, 2024
…pache#41200) ### Rationale for this change Fixes a bug where getting values from a sliced `Decimal128Array` or `Decimal256Array` would return the wrong values. ### What changes are included in this PR? Updates the various `Get*` methods in `Decimal128Array` and `Decimal256Array` to account for the array offset. ### Are these changes tested? Yes, I've added new unit tests. ### Are there any user-facing changes? Yes, this is a user-facing bug fix. * GitHub Issue: apache#41199 Authored-by: Adam Reeve <adreeve@gmail.com> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…pache#41200) ### Rationale for this change Fixes a bug where getting values from a sliced `Decimal128Array` or `Decimal256Array` would return the wrong values. ### What changes are included in this PR? Updates the various `Get*` methods in `Decimal128Array` and `Decimal256Array` to account for the array offset. ### Are these changes tested? Yes, I've added new unit tests. ### Are there any user-facing changes? Yes, this is a user-facing bug fix. * GitHub Issue: apache#41199 Authored-by: Adam Reeve <adreeve@gmail.com> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes a bug where getting values from a sliced
Decimal128ArrayorDecimal256Arraywould return the wrong values.What changes are included in this PR?
Updates the various
Get*methods inDecimal128ArrayandDecimal256Arrayto account for the array offset.Are these changes tested?
Yes, I've added new unit tests.
Are there any user-facing changes?
Yes, this is a user-facing bug fix.