Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R][CI] Windows job failing after R 4.4 release #41398

Closed
nealrichardson opened this issue Apr 26, 2024 · 3 comments
Closed

[R][CI] Windows job failing after R 4.4 release #41398

nealrichardson opened this issue Apr 26, 2024 · 3 comments
Assignees
@assignUser
Labels
Component: Continuous Integration Component: R Priority: Blocker Marks a blocker for the release Type: bug
Milestone
16.1.0

Comments

@nealrichardson
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

See https://github.com/apache/arrow/actions/runs/8849047421/job/24301450969#step:12:83 for example (on main).

g++  -std=gnu++17 -I"C:/R/include" -DNDEBUG -I../windows/arrow-16.0.0.9000/include -DARROW_STATIC -DPARQUET_STATIC -DARROW_DS_STATIC               -DARROW_ACERO_STATIC -DARROW_R_WITH_PARQUET -DARROW_R_WITH_ACERO               -DARROW_R_WITH_DATASET -DARROW_R_WITH_JSON -DARROW_R_WITH_S3 -DARROW_R_WITH_GCS -Werror -I'D:/a/_temp/Library/cpp11/include'   -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"     -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign  -c extension-impl.cpp -o extension-impl.o
In file included from ../windows/arrow-16.0.0.9000/include/arrow/scalar.h:32,
                 from ../windows/arrow-16.0.0.9000/include/arrow/datum.h:29,
                 from ../windows/arrow-16.0.0.9000/include/arrow/compute/api_aggregate.h:26,
                 from ../windows/arrow-16.0.0.9000/include/arrow/acero/options.h:28,
                 from ./arrow_types.h:38,
                 from extension-impl.cpp:18:
../windows/arrow-16.0.0.9000/include/arrow/extension_type.h:53:15: error: 'virtual std::string arrow::ExtensionType::ToString(bool) const' was hidden [-Werror=overloaded-virtual=]
   53 |   std::string ToString(bool show_metadata = false) const override;
      |               ^~~~~~~~
In file included from extension-impl.cpp:26:
./extension.h:55:15: note:   by 'std::string RExtensionType::ToString() const'
   55 |   std::string ToString() const;
      |               ^~~~~~~~

I'm guessing that RTools 4.4 ships with a newer compiler/toolchain and this is throwing the warning (turned into an error by -Werror). Note C:/rtools44/ in the include paths.

FYI @assignUser

Component(s)

Continuous Integration, R
@nealrichardson nealrichardson mentioned this issue Apr 26, 2024
Merged
@jonkeane jonkeane mentioned this issue Apr 26, 2024
Closed
38 tasks
@nealrichardson
Copy link
Member Author

The line in the C++ header in question was introduced here: https://github.com/apache/arrow/pull/39888/files#diff-dd3ca7b08e6c9982fcc1be7ea36c93a2d7998ed3ff6bab2ae1e0343ada0358d3R53

@assignUser
Copy link
Member

I'll give it a try

@assignUser assignUser self-assigned this Apr 27, 2024
@assignUser assignUser mentioned this issue Apr 27, 2024
Merged
@jonkeane jonkeane mentioned this issue Apr 28, 2024
Merged
@assignUser assignUser added this to the 16.1.0 milestone Apr 29, 2024
@assignUser assignUser added the Priority: Blocker Marks a blocker for the release label Apr 29, 2024
jonkeane added a commit that referenced this issue Apr 29, 2024
@jonkeane @assignUser
GH-41402: [CI][R] Update our backwards compatibility CI any other R 4…
6eb0b37 
….4 cleanups (#41403)

### Rationale for this change

Keep up with the state of the world, ensure we are maintaining backwards compatibility.

Resolves #41402

### What changes are included in this PR?

* Bump to 4.4 as the release
* Remove old 3.6 jobs now that we no longer support that; clean up code where we hardcode things fro 3.6 and below
* Move many of our CI jobs to [rhub's new containers](https://github.com/r-hub/containers). We were accidentally running stale R devel (from December 2023) because the other rhub images stopped being updated. (One exception to be done as a follow on: #41416)
* Resolve a number of extended test failures

With this PR R extended tests should be all green with the exceptions of:

* Two sanitizer jobs (test-fedora-r-clang-sanitizer, test-ubuntu-r-sanitizer) — which are being investigated / fixed in #41421
* Valgrind — I'm running one last run with a new suppression file. 
* Binary jobs — these work but fail at upload, see #41403 (comment)
* Windows R Release — failing on main, #41398

### Are these changes tested?

By definition.

### Are there any user-facing changes?

No.

* GitHub Issue: #41402

Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
raulcd pushed a commit that referenced this issue Apr 29, 2024
@jonkeane @assignUser @raulcd
GH-41402: [CI][R] Update our backwards compatibility CI any other R 4…
85f3edc 
….4 cleanups (#41403)

### Rationale for this change

Keep up with the state of the world, ensure we are maintaining backwards compatibility.

Resolves #41402

### What changes are included in this PR?

* Bump to 4.4 as the release
* Remove old 3.6 jobs now that we no longer support that; clean up code where we hardcode things fro 3.6 and below
* Move many of our CI jobs to [rhub's new containers](https://github.com/r-hub/containers). We were accidentally running stale R devel (from December 2023) because the other rhub images stopped being updated. (One exception to be done as a follow on: #41416)
* Resolve a number of extended test failures

With this PR R extended tests should be all green with the exceptions of:

* Two sanitizer jobs (test-fedora-r-clang-sanitizer, test-ubuntu-r-sanitizer) — which are being investigated / fixed in #41421
* Valgrind — I'm running one last run with a new suppression file. 
* Binary jobs — these work but fail at upload, see #41403 (comment)
* Windows R Release — failing on main, #41398

### Are these changes tested?

By definition.

### Are there any user-facing changes?

No.

* GitHub Issue: #41402

Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
assignUser added a commit that referenced this issue Apr 29, 2024
@assignUser
GH-41398: [R][CI] Windows job failing after R 4.4 release (#41409)
00df70c 
### Rationale for this change

We can't throw warnings on cran.

### What changes are included in this PR?

Update function to match changes in libarrow added in GH-39864

### Are these changes tested?

CI
### Are there any user-facing changes?

No

* GitHub Issue: #41398

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser
Copy link
Member

Issue resolved by pull request 41409
#41409

tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@jonkeane @assignUser @tolleybot
apacheGH-41402: [CI][R] Update our backwards compatibility CI any oth…
dda44a7 
…er R 4.4 cleanups (apache#41403)

### Rationale for this change

Keep up with the state of the world, ensure we are maintaining backwards compatibility.

Resolves apache#41402

### What changes are included in this PR?

* Bump to 4.4 as the release
* Remove old 3.6 jobs now that we no longer support that; clean up code where we hardcode things fro 3.6 and below
* Move many of our CI jobs to [rhub's new containers](https://github.com/r-hub/containers). We were accidentally running stale R devel (from December 2023) because the other rhub images stopped being updated. (One exception to be done as a follow on: apache#41416)
* Resolve a number of extended test failures

With this PR R extended tests should be all green with the exceptions of:

* Two sanitizer jobs (test-fedora-r-clang-sanitizer, test-ubuntu-r-sanitizer) — which are being investigated / fixed in apache#41421
* Valgrind — I'm running one last run with a new suppression file. 
* Binary jobs — these work but fail at upload, see apache#41403 (comment)
* Windows R Release — failing on main, apache#41398

### Are these changes tested?

By definition.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#41402

Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@assignUser @tolleybot
apacheGH-41398: [R][CI] Windows job failing after R 4.4 release (apac…
9bf93cf 
…he#41409)

### Rationale for this change

We can't throw warnings on cran.

### What changes are included in this PR?

Update function to match changes in libarrow added in apacheGH-39864

### Are these changes tested?

CI
### Are there any user-facing changes?

No

* GitHub Issue: apache#41398

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
raulcd pushed a commit that referenced this issue May 3, 2024
@assignUser @raulcd
GH-41398: [R][CI] Windows job failing after R 4.4 release (#41409)
e3c5060 
### Rationale for this change

We can't throw warnings on cran.

### What changes are included in this PR?

Update function to match changes in libarrow added in GH-39864

### Are these changes tested?

CI
### Are there any user-facing changes?

No

* GitHub Issue: #41398

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@jonkeane @assignUser @vibhatha
apacheGH-41402: [CI][R] Update our backwards compatibility CI any oth…
ebc9be0 
…er R 4.4 cleanups (apache#41403)

### Rationale for this change

Keep up with the state of the world, ensure we are maintaining backwards compatibility.

Resolves apache#41402

### What changes are included in this PR?

* Bump to 4.4 as the release
* Remove old 3.6 jobs now that we no longer support that; clean up code where we hardcode things fro 3.6 and below
* Move many of our CI jobs to [rhub's new containers](https://github.com/r-hub/containers). We were accidentally running stale R devel (from December 2023) because the other rhub images stopped being updated. (One exception to be done as a follow on: apache#41416)
* Resolve a number of extended test failures

With this PR R extended tests should be all green with the exceptions of:

* Two sanitizer jobs (test-fedora-r-clang-sanitizer, test-ubuntu-r-sanitizer) — which are being investigated / fixed in apache#41421
* Valgrind — I'm running one last run with a new suppression file. 
* Binary jobs — these work but fail at upload, see apache#41403 (comment)
* Windows R Release — failing on main, apache#41398

### Are these changes tested?

By definition.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#41402

Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@assignUser @vibhatha
apacheGH-41398: [R][CI] Windows job failing after R 4.4 release (apac…
138b794 
…he#41409)

### Rationale for this change

We can't throw warnings on cran.

### What changes are included in this PR?

Update function to match changes in libarrow added in apacheGH-39864

### Are these changes tested?

CI
### Are there any user-facing changes?

No

* GitHub Issue: apache#41398

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assignUser assignUser

Labels
Component: Continuous Integration Component: R Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
16.1.0
Development

No branches or pull requests
2 participants
@nealrichardson @assignUser