Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][R]: Update our backwards compatibility CI any other R 4.4 cleanups #41402

Closed
jonkeane opened this issue Apr 26, 2024 · 2 comments · Fixed by #41403
Closed

[CI][R]: Update our backwards compatibility CI any other R 4.4 cleanups #41402

jonkeane opened this issue Apr 26, 2024 · 2 comments · Fixed by #41403

Comments

@jonkeane
Copy link
Member

Describe the enhancement requested

I noticed some of our CI jobs like our backwards compatibility check haven't been updated for a number of versions — bumping those. I will also ensure we have R 4.4 in the right places.

Component(s)

Continuous Integration, R

@kou kou changed the title [CI] [R]: Update our backwards compatibility CI any other R 4.4 cleanups [CI][R]: Update our backwards compatibility CI any other R 4.4 cleanups Apr 26, 2024
@assignUser
Copy link
Member

This now also contains a minimum version bump and related changes and I think it would make sense to add it too 16.1, so I am adding this as a blocker.

@assignUser assignUser added this to the 16.1.0 milestone Apr 29, 2024
@assignUser assignUser added the Priority: Blocker Marks a blocker for the release label Apr 29, 2024
jonkeane added a commit that referenced this issue Apr 29, 2024
….4 cleanups (#41403)

### Rationale for this change

Keep up with the state of the world, ensure we are maintaining backwards compatibility.

Resolves #41402

### What changes are included in this PR?

* Bump to 4.4 as the release
* Remove old 3.6 jobs now that we no longer support that; clean up code where we hardcode things fro 3.6 and below
* Move many of our CI jobs to [rhub's new containers](https://github.com/r-hub/containers). We were accidentally running stale R devel (from December 2023) because the other rhub images stopped being updated. (One exception to be done as a follow on: #41416)
* Resolve a number of extended test failures

With this PR R extended tests should be all green with the exceptions of:

* Two sanitizer jobs (test-fedora-r-clang-sanitizer, test-ubuntu-r-sanitizer) — which are being investigated / fixed in #41421
* Valgrind — I'm running one last run with a new suppression file. 
* Binary jobs — these work but fail at upload, see #41403 (comment)
* Windows R Release — failing on main, #41398

### Are these changes tested?

By definition.

### Are there any user-facing changes?

No.

* GitHub Issue: #41402

Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
@jonkeane
Copy link
Member Author

Issue resolved by pull request 41403
#41403

raulcd pushed a commit that referenced this issue Apr 29, 2024
….4 cleanups (#41403)

### Rationale for this change

Keep up with the state of the world, ensure we are maintaining backwards compatibility.

Resolves #41402

### What changes are included in this PR?

* Bump to 4.4 as the release
* Remove old 3.6 jobs now that we no longer support that; clean up code where we hardcode things fro 3.6 and below
* Move many of our CI jobs to [rhub's new containers](https://github.com/r-hub/containers). We were accidentally running stale R devel (from December 2023) because the other rhub images stopped being updated. (One exception to be done as a follow on: #41416)
* Resolve a number of extended test failures

With this PR R extended tests should be all green with the exceptions of:

* Two sanitizer jobs (test-fedora-r-clang-sanitizer, test-ubuntu-r-sanitizer) — which are being investigated / fixed in #41421
* Valgrind — I'm running one last run with a new suppression file. 
* Binary jobs — these work but fail at upload, see #41403 (comment)
* Windows R Release — failing on main, #41398

### Are these changes tested?

By definition.

### Are there any user-facing changes?

No.

* GitHub Issue: #41402

Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
…er R 4.4 cleanups (apache#41403)

### Rationale for this change

Keep up with the state of the world, ensure we are maintaining backwards compatibility.

Resolves apache#41402

### What changes are included in this PR?

* Bump to 4.4 as the release
* Remove old 3.6 jobs now that we no longer support that; clean up code where we hardcode things fro 3.6 and below
* Move many of our CI jobs to [rhub's new containers](https://github.com/r-hub/containers). We were accidentally running stale R devel (from December 2023) because the other rhub images stopped being updated. (One exception to be done as a follow on: apache#41416)
* Resolve a number of extended test failures

With this PR R extended tests should be all green with the exceptions of:

* Two sanitizer jobs (test-fedora-r-clang-sanitizer, test-ubuntu-r-sanitizer) — which are being investigated / fixed in apache#41421
* Valgrind — I'm running one last run with a new suppression file. 
* Binary jobs — these work but fail at upload, see apache#41403 (comment)
* Windows R Release — failing on main, apache#41398

### Are these changes tested?

By definition.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#41402

Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
…er R 4.4 cleanups (apache#41403)

### Rationale for this change

Keep up with the state of the world, ensure we are maintaining backwards compatibility.

Resolves apache#41402

### What changes are included in this PR?

* Bump to 4.4 as the release
* Remove old 3.6 jobs now that we no longer support that; clean up code where we hardcode things fro 3.6 and below
* Move many of our CI jobs to [rhub's new containers](https://github.com/r-hub/containers). We were accidentally running stale R devel (from December 2023) because the other rhub images stopped being updated. (One exception to be done as a follow on: apache#41416)
* Resolve a number of extended test failures

With this PR R extended tests should be all green with the exceptions of:

* Two sanitizer jobs (test-fedora-r-clang-sanitizer, test-ubuntu-r-sanitizer) — which are being investigated / fixed in apache#41421
* Valgrind — I'm running one last run with a new suppression file. 
* Binary jobs — these work but fail at upload, see apache#41403 (comment)
* Windows R Release — failing on main, apache#41398

### Are these changes tested?

By definition.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#41402

Lead-authored-by: Jonathan Keane <jkeane@gmail.com>
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants