[C++][Parquet] Minor: moving EncodedStats by default rather than copying #41726
Comments
mapleFU
added a commit
that referenced
this issue
May 22, 2024
… than copying (#41727) ### Rationale for this change Moving EncodedStats because it holds two std::string. This could benifit for non-SSO optimized data for FLBA/String statistics ( It seems to be useless for SSO optimized data?) ### What changes are included in this PR? 1. construct `EncodedStats` by `std::move` 2. Making uncompressing size checking ahead of compressing ### Are these changes tested? Covered by existing. ### Are there any user-facing changes? No * GitHub Issue: #41726 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
|
Issue resolved by pull request 41727 |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this issue
May 25, 2024
…rather than copying (apache#41727) ### Rationale for this change Moving EncodedStats because it holds two std::string. This could benifit for non-SSO optimized data for FLBA/String statistics ( It seems to be useless for SSO optimized data?) ### What changes are included in this PR? 1. construct `EncodedStats` by `std::move` 2. Making uncompressing size checking ahead of compressing ### Are these changes tested? Covered by existing. ### Are there any user-facing changes? No * GitHub Issue: apache#41726 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Moving
EncodedStatsbecause it holds twostd::string. This could benifit for non-SSO optimized data for FLBA/String statistics ( It seems to be useless for SSO optimized data?)Component(s)
C++, Parquet
The text was updated successfully, but these errors were encountered: