GH-41726: [C++][Parquet] Minor: moving EncodedStats by default rather than copying #41727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
mapleFU
force-pushed
the
minor/enhancement
branch
from
cca042a
to
8faeb7a
Compare
wgtmac
approved these changes
May 21, 2024
github-actions
bot
added
awaiting committer review
|
@pitrou this is a short pr, would you mind take a fast glance? |
pitrou
approved these changes
May 22, 2024
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8967ddc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…rather than copying (apache#41727) ### Rationale for this change Moving EncodedStats because it holds two std::string. This could benifit for non-SSO optimized data for FLBA/String statistics ( It seems to be useless for SSO optimized data?) ### What changes are included in this PR? 1. construct `EncodedStats` by `std::move` 2. Making uncompressing size checking ahead of compressing ### Are these changes tested? Covered by existing. ### Are there any user-facing changes? No * GitHub Issue: apache#41726 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Moving EncodedStats because it holds two std::string. This could benifit for non-SSO optimized data for FLBA/String statistics ( It seems to be useless for SSO optimized data?)
What changes are included in this PR?
EncodedStatsbystd::moveAre these changes tested?
Covered by existing.
Are there any user-facing changes?
No