Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift] Update isValidBuilderType method to take a type instead of a value #42243

Closed
abandy opened this issue Jun 21, 2024 · 2 comments
Closed

[Swift] Update isValidBuilderType method to take a type instead of a value #42243

abandy opened this issue Jun 21, 2024 · 2 comments
Assignees
@abandy
Labels
Component: Swift Type: enhancement
Milestone
17.0.0

Comments

@abandy
Copy link
Contributor

abandy commented Jun 21, 2024

Describe the enhancement requested

Currently isValidBuilderType requires a user to pass an instance of a type. Updating the method to take the type and not require an instance.

Component(s)

Swift
@abandy
Copy link
Contributor Author

abandy commented Jun 21, 2024

take

abandy added a commit to abandy/arrow that referenced this issue Jun 21, 2024
@abandy
apacheGH-42243 [Swift] Update isValidBuilderType to not required inst…
bbfa924 
…ance of type
@github-actions github-actions bot mentioned this issue Jun 21, 2024
Merged
kou pushed a commit that referenced this issue Jun 21, 2024
@abandy
GH-42243: [Swift] Update isValidBuilderType to not required instance …
cb1f9b7 
…of type (#42244)

### Rationale for this change
isValidBuilderType should take a Type and not require an instance of a type in order to validate.

### What changes are included in this PR?
Updated isValidBuilderType to take a Type instead of an instance.

### Are these changes tested?
Yes

* GitHub Issue: #42243

Authored-by: Alva Bandy <abandy@live.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 17.0.0 milestone Jun 21, 2024
@kou
Copy link
Member

kou commented Jun 21, 2024

Issue resolved by pull request 42244
#42244

@kou kou closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abandy abandy

Labels
Component: Swift Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@kou @abandy