Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-42243: [Swift] Update isValidBuilderType to not required instance of type #42244

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

abandy
Copy link
Contributor

@abandy abandy commented Jun 21, 2024

Rationale for this change

isValidBuilderType should take a Type and not require an instance of a type in order to validate.

What changes are included in this PR?

Updated isValidBuilderType to take a Type instead of an instance.

Are these changes tested?

Yes

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit cb1f9b7 into apache:main Jun 21, 2024
7 checks passed
@kou kou removed the awaiting review Awaiting review label Jun 21, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 21, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit cb1f9b7.

There were 6 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 27 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants