Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-13671: [Dev] Fix conda recipe on Arm 64k page system #10963

Closed
wants to merge 2 commits into from
Closed

ARROW-13671: [Dev] Fix conda recipe on Arm 64k page system #10963

wants to merge 2 commits into from

Conversation

cyb70289
Copy link
Contributor

No description provided.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-13671

@cyb70289 cyb70289 mentioned this pull request Aug 19, 2021
Closed
@cyb70289 cyb70289 marked this pull request as draft August 19, 2021 07:37
@pitrou pitrou requested a review from xhochy August 19, 2021 08:52
@cyb70289
Copy link
Contributor Author

@github-actions crossbow submit conda-linux-gcc-py38-arm64

@github-actions
Copy link

Revision: 93d16b1

Submitted crossbow builds: ursacomputing/crossbow @ actions-786

Task Status
conda-linux-gcc-py38-arm64 Azure

@cyb70289
Copy link
Contributor Author

cyb70289 commented Aug 20, 2021 •
edited
Loading

I've validated this PR on both 64k and 4k page arm64 system. It works correctly.
I also tried night build conda image, it fails on 64k page system.

Images built from this PR: arrow-cpp, arrow-cpp-proc, parquet-cpp, pyarrow, pyarrow-test

@cyb70289 cyb70289 marked this pull request as ready for review August 20, 2021 08:00
@cyb70289 cyb70289 requested a review from kszucs August 20, 2021 08:05
xhochy
xhochy reviewed Aug 22, 2021
View reviewed changes
dev/tasks/conda-recipes/arrow-cpp/build-arrow.sh Outdated
if [[ "${target_platform}" == "linux-aarch64" ]]; then
# To support both 4k and 64k page arm64 systems
# See https://github.com/apache/arrow/pull/10940
EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_JEMALLOC_LG_PAGE=16"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the sed workaround above for osx-arm64?

Suggested change
EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_JEMALLOC_LG_PAGE=16"
EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_JEMALLOC_LG_PAGE=16"
elif [[ "${target_platform}" == "osx-arm64" ]]; then
EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_JEMALLOC_LG_PAGE=14"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cyb70289
Copy link
Contributor Author

@github-actions crossbow submit --help

@github-actions
Copy link 

Usage: @github-actions crossbow submit [OPTIONS] [TASKS]...

  Submit crossbow testing tasks.

  See groups defined in arrow/dev/tasks/tests.yml

Options:
  -g, --group TEXT          Submit task groups as defined in tests.yml
  -p, --param TEXT          Additional task parameters for rendering the CI
                            templates
  -v, --arrow-version TEXT  Set target version explicitly.
  --help                    Show this message and exit.

@cyb70289 cyb70289 requested a review from xhochy August 23, 2021 02:03
@cyb70289
Copy link
Contributor Author

@github-actions crossbow submit conda-linux-gcc-py38-arm64

@cyb70289
Copy link
Contributor Author

@github-actions crossbow submit conda-osx-arm64-clang-py39

@github-actions
Copy link

Revision: 4a6730c

Submitted crossbow builds: ursacomputing/crossbow @ actions-787

Task Status
conda-linux-gcc-py38-arm64 Azure

@github-actions
Copy link

github-actions bot commented Aug 23, 2021 •
edited by cyb70289
Loading

Revision: 4a6730c

Submitted crossbow builds: ursacomputing/crossbow @ actions-788

Task Status
conda-osx-arm64-clang-py39 Azure

[Yibo] The failure looks related to libcurl version: https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=10305&view=logs&j=cf796865-97b7-5cd1-be8e-6e00ce4fd8cf&t=9f7de14c-8ff0-55c4-a998-d852f888262c

@kszucs
Copy link
Member

kszucs commented Sep 2, 2021

@github-actions crossbow submit conda-osx-arm64-clang-py39

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Revision: 32c28be

Submitted crossbow builds: ursacomputing/crossbow @ actions-809

Task Status
conda-osx-arm64-clang-py39 Azure

@cyb70289
Copy link
Contributor Author

cyb70289 commented Sep 2, 2021

There's a jira issue to track OSX job failures
https://issues.apache.org/jira/browse/ARROW-13743

@cyb70289
Copy link
Contributor Author

cyb70289 commented Sep 7, 2021

@github-actions crossbow submit conda-osx-arm64-clang-py39

@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Revision: c35cf61

Submitted crossbow builds: ursacomputing/crossbow @ actions-831

Task Status
conda-osx-arm64-clang-py39 Azure

@cyb70289
Copy link
Contributor Author

cyb70289 commented Sep 7, 2021

@kszucs @xhochy I've rebased. OSX test passed now.

kszucs
kszucs approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cyb70289!

@kszucs kszucs closed this in 6c7c4f0 Sep 7, 2021
@cyb70289 cyb70289 deleted the arm-64k-page branch September 7, 2021 12:38
zeroshade pushed a commit to zeroshade/arrow that referenced this pull request Sep 12, 2021
@cyb70289
ARROW-13671: [Dev] Fix conda recipe on Arm 64k page system
718da6e 
Closes apache#10963 from cyb70289/arm-64k-page

Authored-by: Yibo Cai <yibo.cai@arm.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
@cyb70289 @ViniciusSouzaRoque
ARROW-13671: [Dev] Fix conda recipe on Arm 64k page system
99b4820 
Closes apache#10963 from cyb70289/arm-64k-page

Authored-by: Yibo Cai <yibo.cai@arm.com>
Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
@asfimport asfimport mentioned this pull request Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs approved these changes

@xhochy xhochy Awaiting requested review from xhochy

Assignees
No one assigned
Labels
Component: C++ Component: FlightRPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyb70289 @kszucs @xhochy