Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-13671: [Dev] Fix conda recipe on Arm 64k page system #10963

Closed
wants to merge 2 commits into from
Closed

ARROW-13671: [Dev] Fix conda recipe on Arm 64k page system #10963

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b484142
ARROW-13671: [Dev] Fix conda recipe on Arm 64k page system
cyb70289 Aug 19, 2021
c35cf61
remove apple m1 workaround
cyb70289 Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dev/tasks/conda-recipes/arrow-cpp/build-arrow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,13 @@ fi

if [[ "${target_platform}" == "osx-arm64" ]]; then
# We need llvm 11+ support in Arrow for this
EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_GANDIVA=OFF"
# Tell jemalloc to support 16K page size on apple arm64 silicon
EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_GANDIVA=OFF -DARROW_JEMALLOC_LG_PAGE=14"
sed -ie "s;protoc-gen-grpc.*$;protoc-gen-grpc=${BUILD_PREFIX}/bin/grpc_cpp_plugin\";g" ../src/arrow/flight/CMakeLists.txt
sed -ie 's;"--with-jemalloc-prefix\=je_arrow_";"--with-jemalloc-prefix\=je_arrow_" "--with-lg-page\=14";g' ../cmake_modules/ThirdpartyToolchain.cmake
elif [[ "${target_platform}" == "linux-aarch64" ]]; then
# Tell jemalloc to support both 4k and 64k page arm64 systems
# See https://github.com/apache/arrow/pull/10940
EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_GANDIVA=ON -DARROW_JEMALLOC_LG_PAGE=16"
else
EXTRA_CMAKE_ARGS=" ${EXTRA_CMAKE_ARGS} -DARROW_GANDIVA=ON"
fi
Expand Down