Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-14421: [C++] Implement Flight SQL #12013

Closed
wants to merge 5 commits into from
Closed

ARROW-14421: [C++] Implement Flight SQL #12013

wants to merge 5 commits into from

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Dec 21, 2021 •
edited
Loading

Implement Flight SQL in C++ and Java, and add the protocol definitions.

This is a combination of multiple pull requests, merged into one branch before merging into master.

Closes #10906 (ARROW-12922).
Closes #11507 (ARROW-14421).
Closes #11989 (ARROW-15112).
Closes #12021 (ARROW-15187).
Closes #12035 (ARROW-15198).

@rafael-telles @lidavidm
ARROW-12922: [Java] Add flight-sql to the flight package
645edf3 
Introduction
This experimental PR implements Flight SQL, which formalizes SQL semantics on top of Flight. This follows designs and is a continuation of a PR started here. You can find the original proposal here, although the document has since drifted from the actual implementation.

An Overview of this PR
This PR adds a new module within Flight called flight-sql.
flight-sql is a new Flight API that provides a standard way for clients and servers to communicate with SQL-like semantics.
Like other Flight APIs, flight-sql does not provide implementation details that dictate how a client and server communicates with each other, it simply provides the SQL semantics and apply them onto the Flight API.

A Walkthrough of the New Module
FlightSql.proto introduces new SQL protobuf objects.
FlightSqlClient introduces a new wrapper for a FlightClient that adds the Flight SQL semantics on the client side.
FlightSqlProducer introduces a new FlightProducer API that adapts classic Flight requests into SQL operations.
FlighSqlExample is a sample FlightSQL server implementation.

Note that there are likely a few remaining items to be fleshed out, but they mostly pertain to metadata and adding to the list of formally specified metadata items. Also, this is experimental and has not formally been adopted yet.

Squashed commit of the following:

commit 36656e39db4451f71567cf0543a829900d91237e
Author: Vinicius Fraga <62815192+vfraga@users.noreply.github.com>
Date:   Mon Dec 6 16:51:54 2021 -0300

    Fix Subqueries SqlInfo in Protobuf and SqlInfoBuilder (#223)

commit f828df65b2b28ca376e2bda8fadaef00b547fb63
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Dec 6 15:07:04 2021 -0300

    Update FlightSql.proto docstrings

commit 6ddfe7c6da71218b2308df2a862990754a8ef43c
Author: Jose Almeida <53087160+jcralmeida@users.noreply.github.com>
Date:   Fri Dec 3 13:59:43 2021 -0300

    [Java] Address Comments from ratification. (#222)

    * Refactor reference to schema in the database to db_schema_*

    * Add tableRef class and refactor call from client to use it

    * Remove tableRef from GetTables

    * Fix checkstyle issues

    * Set fields as final in the TableRef

commit 0920e45b0efe391915ff7ef571d6c361f9be2e91
Author: Vinicius Fraga <sxvinifp@gmail.com>
Date:   Thu Oct 28 17:45:54 2021 -0300

    Fix Maven Build after rebase with master

commit d165ea7f1a4f7cff154b715924b9c2e011e158a0
Author: Vinicius Fraga <sxvinifp@gmail.com>
Date:   Thu Oct 28 17:31:06 2021 -0300

    Increase Arrow Flight SQL Version in POM

commit d5cc2bc081b68701cf1485bc4a96bca207ca0698
Author: Vinicius Fraga <sxvinifp@gmail.com>
Date:   Thu Oct 28 15:27:10 2021 -0300

    Fix rebase issues

commit dc468bc2584d88b60c2d550223cbe93ba5de1784
Author: Vinicius Fraga <sxvinifp@gmail.com>
Date:   Wed Oct 27 17:31:41 2021 -0300

    Fix checkstyle

commit b619be85134e12824f2166382d4939838fef6e10
Author: Vinicius Fraga <sxvinifp@gmail.com>
Date:   Wed Oct 27 15:51:23 2021 -0300

    Add SqlOuterJoinSupportLevel to SqlInfoBuilder

commit e7b823993bf20d17bc46ff6a9dc2fe9531843227
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Oct 25 15:37:11 2021 -0300

    Implement SqlInfoProvider helper class (#176)

    * Implement SqlInfoProvider helper class

    * Added further javadocs to SqlInfoBuilder

    * Properly links the SqlInfoBuilder Javadocs to the SqlInfo one

    Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com>

commit 0c2d19d0aceb3589cc073596e4060e86dc7ce69b
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Tue Oct 19 15:03:02 2021 -0300

    Fix some decos on FlightSql.proto

commit 9ffd2a799f8be5434c2812373ecae82fb73bdef4
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Tue Oct 19 14:02:03 2021 -0300

    Fix supportsConvert docs on FlightSql.proto

commit d5614b580a6ca4544d3ca7b487451657dd03c6bf
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Oct 18 17:49:42 2021 -0300

    Fix test failures after rebase

commit afed3187ff42c08296c532bb17e5f6681afd0b4c
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Oct 18 15:56:42 2021 -0300

    Remove getter and use static variable for Schemas

commit eb39c6bbf264827f9e445be2c99e791319337f03
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Oct 18 15:56:10 2021 -0300

    Refactor variable name from CrossReference

commit 215beeb4559d841dd7dfb786bd87ceeb79a16b07
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Oct 18 15:55:18 2021 -0300

    Typo on message CommandGetCrossReference

commit f6f0188734a2cdc80dfbd2d090528a2b8d73eac0
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Oct 18 15:25:42 2021 -0300

    Add documentation to cross reference fields on proto file

commit b56ff0a833e811133d06e2424c4f4efa6eef7cac
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Oct 18 15:14:10 2021 -0300

    Refactor schemas retrieval from imported, exported keys and cross-reference

commit fb6026d0d006320f522302fbbafa56ac2115bcfb
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Oct 18 14:22:20 2021 -0300

    Add a test to cross-reference command from flight-sql

commit 250e2c014d68f9317511c58cc4e636ae41c2e247
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Oct 18 14:21:54 2021 -0300

    Implement cross-reference logic on server

commit 1dac11eba240ed7e369b21f0a31e50066f160e71
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Oct 18 14:21:11 2021 -0300

    Add CrossReference methods to SqlProducer

commit 268ca19a032c4bb1ac13b7f24a949e1bca142b4b
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Oct 18 14:19:49 2021 -0300

    Add getCrossReference method to sqlClient

commit 089b11dfb58c6f4090091ddd7f492b80a5476577
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Oct 18 12:00:42 2021 -0300

    Add CommandGetCrossReference on FlightSql.proto

commit c5e9865f7c395f0a361c847e02ac726f3c00f20a
Author: JrJuscelino <56421957+JrJuscelino@users.noreply.github.com>
Date:   Mon Oct 18 15:30:17 2021 -0300

    [FlightSQL] Add enum for and map vector for supportsConvert (#171)

    * Define enum to supports convert

    * Add map vector to schema template

    * Revert accidental changes on FlightSqlProducer

    * Rename SQL_JOINS_SUPPORT_LEVEL to SQL_OUTER_JOINS_SUPPORT_LEVEL

    * Improve SUPPORTED_CONVERSION_FUNCTIONS doc

    * Change * imports to singles imports on FlightSqlProducer

    * Revert wrong chance on FlightSqlProducer

    * Update java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlProducer.java

    Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

    Co-authored-by: Vinicius Fraga <62815192+vfraga@users.noreply.github.com>
    Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

commit a4de98dea92932065cc8297813d58e120990ccf4
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Oct 13 13:54:24 2021 -0300

    Fix CheckStyle issues

commit 30cad1bfa1b347b32ab095cdd429cfd6017f8b04
Author: Vinicius Fraga <62815192+vfraga@users.noreply.github.com>
Date:   Tue Oct 12 17:21:24 2021 -0300

    Add Flight SQL Client Demo App to Flight SQL Package (#134)

    * Implemented FlightSqlClientDemoApp

    * Use try-with-resources

    * Move trw-with-resources to DemoApp only

    * Add back commons cli to pom

commit e30bb4c2546ada6c8280494033777be9b3da8133
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 12 15:54:57 2021 -0300

    Propagate grpc version to arrow-flight/pom.xml

commit 311bf36a674e0fdcf48bfc91cdc6cbf84799e043
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Oct 12 18:47:57 2021 +0000

    [FlightSQL] Add missing method for creating bitmask from GetSqlInfo option enum (#148)

    * Add util method for creating bitmask from multiple protobuf enums for FlightSql GetSqlInfo enum

    * Add test cases for utility method for creating bitmask from protobuf options

    * Make changes regarding to reviews

    Co-authored-by: Rafael Telles <rafael@telles.dev>

commit b315cae933048db1cc1a34d550a76b5e142a07a3
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 12 13:49:38 2021 -0300

    Remove unused imports on FlightSqlExample

commit 68c1a461c7809146274e2a12e3bee67775b976b5
Author: Vinicius Fraga <sxvinifp@gmail.com>
Date:   Tue Oct 12 12:07:21 2021 -0300

    Fix Flight SQL Dependency problems

commit 8a57e9589a9e4a5c5e7c7cc875e55110cacf5605
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 5 15:45:54 2021 -0300

    Fix Schema serialization and deserialization on Flight SQL methods

commit 78a6df4c48e1c36da1e2bfede5298c23992160f4
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Sep 29 14:36:57 2021 -0300

    Replace uint32 fields with int64 in GetSqlInfo

commit a535542f843472190d18c41aa7bc5e068327b487
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Sep 29 11:35:58 2021 -0300

    Fix FlightSQL protobuf documentation

commit abf57d7f3c937ea96f0066bcb28fd6247dce48bc
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Sep 27 16:55:17 2021 -0300

    Replace CSV string with string list for GetSqlInfo

commit d4883eaab8affc60a19f6b9c6af55383a72d4797
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Sep 27 11:43:54 2021 -0300

    Rewrite some of the documentation for FlightSql.proto and redefine some types for GetSqqlInfo

commit 6c676a97759f555db5a2edfd93a19b95ca9ca73e
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Sep 24 16:30:22 2021 -0300

    Add boolean value to dense union @ GetSqlInfo

commit bbcaa9c79760c0c042750896fd6ba8f872dda634
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Sep 24 15:06:35 2021 -0300

    Make GetSqlInfo return uint64 bitmask as one of the dense union fields

commit 926ab2a2ccc8115044b651ba18d063e40f01cdea
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Sep 22 17:50:28 2021 -0300

    Add test cases for bitshifting operations required for filtering out some SqlInfo data

commit 45dd21ecaf60318146beb2ab169ad74c93a21b62
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Sep 22 16:33:08 2021 -0300

    Change int32 bitmask to int128 bitmask for GetSqlInfo

commit 05377a8194f66f40f5764d1c7e9d8d62660b7cfd
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Sep 20 18:08:50 2021 -0300

    Enrich FlightSQL documentation in protobuf definition file

commit d34bf7a5ca912ede11b610c005c8d025c3408825
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Sep 20 15:01:51 2021 -0300

    Add missing comment for SQL_ALL_TABLES_ARE_SELECTABLE

commit 206822d13bc445ef282e05512365832424dda910
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Sep 14 23:04:59 2021 -0300

    Add more data to GetSqlInfo for FlightSql.proto

commit edba84d849ef12dfd60ee6abd0fe9c747da6a39a
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Sep 16 14:05:15 2021 -0300

    Remove redundant Ticket arguments from getStream* methods (#125)

commit 7c50815122be74424f176adc0eb64aed14c5cb98
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Sep 15 11:23:48 2021 -0300

    Redo AutoCloseable

commit 4262f8b6e0909ba865ca6a5635e9c2a92d39512b
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Sep 3 14:56:27 2021 -0300

    Fix maven build from different directories (#114)

commit 9d4a41eab05f53f982f532f67255252e3a9834e7
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Sep 2 15:06:33 2021 -0300

    Flight SQL Ratification Based On Community Feedback #8 (#113)

    * Change scope of arrow-memory-netty to test for flight-sql

    * Remove unused dependency arrow-memory-netty

    * Update common-pool2 and common-dbcp2 dependencies

    * Remove 'executions' from parent pom.xml for plugin protobuf-maven-plugin

    * Adjust protobuf-maven-plugin settings on pom.xml files

    * Move dep.protobuf.version and dep.grpc.version to top pom.xml

    * Remove <url> from arrow-flight's pom.xml

commit 46b4bce681fa91de6e1a030ebeaf227796f280e0
Author: Vinicius F <62815192+vfraga@users.noreply.github.com>
Date:   Thu Sep 2 11:16:44 2021 -0300

    Update CommandGetPrimaryKey from FlightSql.proto (#110)

    Include not null on docs

commit a1390f288c1149f1999548746b782d81c489f7c2
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Aug 31 15:15:54 2021 -0300

    Bump protobuf version

commit 3a1ab6380ce06bdb0e097991b34bec93ad232fe5
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Aug 26 16:43:25 2021 -0300

    Fix missing generated sources on built flight-sql jar (#101)

commit 1b10f60aabe928ebe58c2894959af25c37c27701
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Aug 26 14:16:40 2021 -0300

    Allow FlightSqlClient#getSqlInfo accept SqlInfo enum arguments (#99)

commit 8939ee6346d0ec11332facc45459b3949062c9fe
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Aug 26 13:32:47 2021 -0300

    Flight SQL Ratification Based On Community Feedback #7 (#98)

    * Remove scope from 'hamcrest' dependency on java/pom.xml

    * Use flight top-level module on parent pom.xml instead of declaring each one

    * Avoid using getStatement inside StatementContext methods

    * Make StatementContext.getQuery() return String

    * Minor fixes on pom.xml

    * Move 'os-maven-plugin' to parent pom.xml

    * Update protobuf generation on pom.xml files

    * Use ClassLoader#getResource to get network.properties on TestFlightSql

    * Bind to any ephemeral port on TestFlightSql

    * Move JDBC-Arrow type default conversion from JdbcToArrowConfig to JdbcToArrowUtils

    * Micro-optimization: initialize ArrayList with the right size

    * Fix null-check on PreparedStatement#setParameters

    * Avoid wrapping vector into a ImmutableList and then into an ArrayList on FlightSqlExample#getTablesRoot

    * Remove null-check on VectorSchemaRoot on FlightSqlClient#setParameters()

    * Remove the need of separate cache for ResultSets

    * Add missing 'final' modifiers

commit 26482f6665305155a29a6fb8ef401c619a7b699b
Author: Vinicius F <62815192+vfraga@users.noreply.github.com>
Date:   Wed Aug 25 16:30:38 2021 -0300

    Flight SQL Ratification Based On Community Feedback #6 (#94)

    * Refactored FlightSql Statement Constant names

    * Defined non-nullable parameters for FlightSql proto

    * Resolved minimal checkstyle issues

    * Added further documentation for catalog and schema

    * Refactored FlightSql proto comments to include more information

    * Added Field/FieldType notNullable methods

    * Refactored FlightSqlClient and FlightSqlExample to leverage Field notNullable method

    * Removed opaque query warning from FlightSql proto

    * Added the optional tag for the returned schema of getTables to proto

commit 7805e71dae21ba82ebd43d2fb36bf664d6c47de2
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Aug 25 11:39:51 2021 -0300

    Flight SQL - Declare Protobuf enums (#93)

    * Declare Protobuf enums for SqlInfo and UpdateDeleteRules

    * Improve SqlInfo docs

commit 74dc7951ed2f1c78cdf6c7ff21c56faee9d702ad
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Aug 24 14:24:24 2021 -0300

    Rearrange FlightSqlProducer#getStreamStatement arguments order

commit 733cc309af791a8f1990665df600cc7026935372
Author: Vinicius Fraga <sxvinifp@gmail.com>
Date:   Tue Aug 24 14:20:32 2021 -0300

    Added arrow-format to flight-sql pom

commit 61110d9fb7616f75941fbbb4d4f59e8ef7b38097
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Aug 24 13:25:30 2021 -0300

    Flight SQL Ratification Based On Community Feedback #5 (#91)

    * Delegate GetSchemaImportedKeys

    * Remove schema retrieval methods for catalog functions and delegate to constants

    * Add IPC encapsulation to Schema serialization

    * Fix checkstyle violations

    * Update javadoc for FlightSqlClient

    * Update documentation for FlightSql.proto

    Co-authored-by: Abner Eduardo Ferreira <abenaru@protonmail.ch>

commit d1f0df125fda1c057bad8b293a786027254bd36f
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 20 15:21:25 2021 -0300

    Add argument ticket to the getStreamStatement methods

commit 6dc4624ee45016c16841fbb73cb84e6f23dc199c
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 20 15:21:00 2021 -0300

    Add note to treat query as opaque

commit 24383b8c3b7bc5b563099f260002e3a3fe144e6e
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 20 15:20:33 2021 -0300

    Remove unused variable of cache

commit 505996c51df6ffc828cbd1541c8babb1a31a44b4
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Aug 20 15:02:46 2021 -0300

    Fix leaking Connections on FlightSqlExample

commit 6a52ebe874d6315831c13cc9d451d9d14179eed1
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Aug 19 16:11:25 2021 -0300

    Split CommandStatementQuery in 2 messages, one for Command and other for Ticket

commit 7028593148883cbc3ab383c6c1443ff9ed15f425
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Aug 19 14:04:26 2021 -0300

    Remove unused imports on FlightSqlClient

commit ca784600c2077415a327317d3fd9e3d063b23c67
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Aug 18 16:37:57 2021 -0300

    Fix missing client_execution_handle on CommandStatementQuery (#86)

commit b2ac91a3522218208d27066eb13719cfd71f5794
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Aug 18 14:40:11 2021 -0300

    FlightSQL Ratification based on Community Comments (round 2) (#85)

    * Remove unused client_execution_handler from Protobuf

    * Update documentation on CommandGetPrimaryKeys

    * Update documentation on CommandGetImportedKeys and CommandGetExportedKeys

    * Change exception type on FlightSqlClient#executeUpdate

    * Add @return to FlightSqlClient#executeUpdate JavaDoc

    * Switch order of key_name and key_sequence on CommandGetTableKeys documentation

    * Update JavaDoc for FlIghtSqlClient#clearParameters

    * Add private constructor to FlightSqlProducer.SqlInfo

    * Update JavaDoc for FlIghtSqlClient#clearParameters

    * Fix wrong CommandGetPrimaryKeys documentation on Proto file

    * Fix order of key_name and key_sequence

commit 0ce1e99c5deb82b144f63a42aff4da11e22863d1
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Aug 17 14:23:33 2021 -0300

    [WIP] FlightSQL Ratification based on Community Comments (#73)

    * Move FlightSql examples to their own subpackage

    * Fix checkstyle issues

    * fix: change Status use to CallStatus

    * Remove unnecessary overhead of wrapping nullable objects into Optionals for the sole purpose of null-checking

    * Replace Guava's Preconditions with the ones provided by Apache

    * Fix typo in FlightSql.proto

    * Fix ordering of schema for FlightSql.proto

    * Explain why reserved range of IDs for GetSqlInfo is not entirely in use

    * Add comment to CommandGetTables to explain the encoding of table_schema

    * Remove redundat information on schemas

    * Fixed Javadoc on some methods, added Thread interrupt to executeUpdate methods, and updated Signal exceptions to CallStatus with description

    * Replace int32 with uint32 for GetSqlInfo name representation

    * Replace AssertionError with StatusRuntimeException for whenever attempting to unpack an invalid protobuf message

    * add comment to FlightSql.proto to update_rule and delete_rule

    * Replace inconsistent exception handling with CallStatus predetermined exceptions

    * correct comment to CreatePreparedStatement on FlightSql.proto

    * Remove unused dependencies

    * fix: change Status use to CallStatus on FlightSqlProducer

    * Changed from if not null check to Objects requireNonNull on Flight SQL Client

    * Remove Nullable annotation

    * Changed from checkNotNull to Objects#requireNotNull with description on Flight SQL Example

    * Add CallOptions to every RPC call by the client

    * Fix Maven dependency problems and checkstyle violations

    * Replace generic Collections with Lists when order matters in an RPC call

    * Fix Javadoc for FlightSqlClient

    * Add description to StatusRuntimeExceptions

    * Add descriptions to Exceptions

    * Correct update_rule and delete_rule description on FlighSql.proto

    * Verify wheter Root is empty before sending request to server

    * Add call options to PreparedStatement

    * Replace constant checking of whether client is open with #checkOpen

    * Add CallOptions to #close for PreparedStatement

    * Refactor PreparedStatement usages of CallOptions

    * Fix broken tests

    * Fix FlightSql.proto documentation

    * Update documentation for format/FlightSql.proto

    Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

    * Fix checkstyle violations

    * Require non null tables for GetExportedKeys and GetImportedKeys

    * Not storing CallOptions in PreparedStatement

    * Update documentation comments for protobuf

    * Replace IntVector for UInt1Vector for delete_rule and update_rule

    * Fix protobuf for FlightSQL

    * Fix bug with empty metadata

    * Update update_rule and delete_rule documentation on proto

    * Remove explicit dependency on JDBC's DatabaseMetaData on UpdateDeleteRules

    * Use MessageOptions instead of FieldOptions on proto

    * Add missing JavaDoc about 'options' parameter

    * Fix CommandGetSqlInfo documentation

    * Add @throws to FlightSqlClient#checkOpen JavaDoc

    Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br>
    Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com>
    Co-authored-by: Rafael Telles <rafael@telles.dev>
    Co-authored-by: kylep-dremio <38920967+kylep-dremio@users.noreply.github.com>

commit 2499ee8b1c4742ff97bc058cfc608c345adb9d70
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Aug 10 15:15:55 2021 -0300

    Fix wrong PreparedStatement cache invalidation

commit 36f5fb7633446ba388ba5bf9580f21f3c521ccb4
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Aug 10 15:04:48 2021 -0300

    Fix missing code on adapter/jdbc/JdbcToArrowUtils.java due to rebase issue

commit e1622728ad72dc93e4cdde8484aa69db1509075a
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Aug 10 14:55:02 2021 -0300

    Fix rebase issues with FlightSql.proto

commit 9a28e51dd90d98579f148a2b7064af17a6bfd162
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Aug 10 14:46:55 2021 -0300

    Fix Arrow versions on new pom.xml files

commit b6fb92d1e0f462412175e02ea73f4ba7e6134fec
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Aug 9 14:52:58 2021 -0300

    Treat exception in executeUpdate as SQLException

commit 2a3836dc1e4eae31a2e4f7bb0962f0aaeec15a3c
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 6 18:01:37 2021 -0300

    Refactor the setters from prepared statement and add calendar types to it

commit 9840558976a1548640e7502e31725f1f295f019f
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 6 15:41:07 2021 -0300

    Add a method to clear the parameters from the prepared statement object

commit 4c50b95ce3cff4005d32fc6a1713512168815747
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 6 15:30:18 2021 -0300

    Fix checkstyle at FlightSqlClient class

commit 0c39ca23cd4771301db4fa39151b18fdbb410b1e
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 6 15:29:40 2021 -0300

    Deal with query with parameter in the preparedStatement

commit 7c69c87607382a51287c8f9f2f0d4f06932a1a59
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 6 15:29:02 2021 -0300

    Add a new test for preparedUpdate without binding parameter

commit 59c96c7459a7ad62d073b7f606de206161665642
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Aug 6 12:13:07 2021 -0300

    Fix leaking connections on connection pool

commit e14a4870f8308710de12009e24d7de932d4f71d2
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 6 11:17:56 2021 -0300

    Remove ignore from tests

commit 26f9ec138ede01981a09e4c599d4df97160ff397
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 6 11:16:35 2021 -0300

    Modify execute preparedStatement flow

commit 5ef5b098478dec18a54b2e659f7a04ab2c55ee4a
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 6 11:15:39 2021 -0300

    Create a validation for when vectorRoot is present

commit 63d242525dc9bb8050ceb8ff4239cc00b65b8996
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Aug 6 11:15:04 2021 -0300

    remove vectorRoot from execute and create a setter

commit 9b8a0bded3829352bd586828242686c0ae8c007e
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Aug 2 13:47:25 2021 -0300

    Remove unnecessary old files

commit 0bca0c7630fc50643d75c803dad97a19ea4e28f6
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Aug 2 13:33:35 2021 -0300

    Insert preparedStatement into a try-with-resources

commit 4bdf3f3ae4b3f22197d456eabb8dc472f30dbe7a
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Aug 2 13:32:46 2021 -0300

    Remove fail code used to force error

commit 3264877becf38ce9dc11bcde69e544aba3ad3167
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Jul 30 16:49:40 2021 -0300

    Deal with errors properly

commit 827fc5bc6ab0ac9698ddac8b7c618f1307cfa503
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Jul 30 12:01:26 2021 -0300

    Small refactor when getting preparedStatement due to rebase

commit f56c59878be71b9f1bd4d04c2f61e0c661beb764
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Jul 30 11:49:51 2021 -0300

    Add missing param to the java doc from executeUpdate Method

commit d90059e7c2b0510a3bf7c322e3e62728ce5c0fc2
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 15:29:14 2021 -0300

    Change preparedStatementLoadingCache to get from a ByteString

commit ef23515edd3e373b6226bd5ebe725289928972f5
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 14:21:30 2021 -0300

    Fix checkstyle

commit e9d293620f1b53c3b836d6fa5303fd010c7dc095
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 13:56:18 2021 -0300

    Fix checkstyle

commit 3218db5ffa2d3e6a2e8dea10b731f44ffac8d7ca
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 13:55:40 2021 -0300

    Add creation of Vector in a try with resources

commit 27930f30617e0898e894fd629200535f1edf209f
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 13:41:43 2021 -0300

    Refactor test from update at PreparedStatement

commit 1c5b435d4fbcff87a2054dd66dddd4efe3d4363c
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 13:41:05 2021 -0300

    Add while loop at flightStream and deal with errors

commit 74e16ce1fb71bb1fbc8f58babe4486183c1dd805
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 13:39:52 2021 -0300

    Nit: fix typo on putListener

commit fdd35739572316214264cfdb1c68cb22718f0366
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Jul 27 15:15:44 2021 -0300

    add logic to executeUpdate from preparedStatement

commit 524190749b2b30c77ddbda2e547edc55c193228c
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Jul 27 15:15:03 2021 -0300

    Change executeUpdate parameters

commit 5aff106cda8eb657e046084056021afd265156bb
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Jul 27 15:14:11 2021 -0300

    Refactor executeUpdate test

commit 41f4cb72a0b45ba649e6338d51eb372087c6336c
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Jul 27 11:08:18 2021 -0300

    Add new imports

commit 455208bb4f149683cb478ce8458e6b4d299c5766
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Jul 27 11:07:23 2021 -0300

    initial progress at update on preparedstatment

commit d939326e7fd53670e094b0c95a52a2030183278c
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 15:19:50 2021 -0300

    Refactor the code to not use string when getting from cache

commit 1aa639ef2606967c3c04370068a65118fa02677b
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Jul 26 15:12:31 2021 -0300

    Refactor prepareStatement to use Cache Object

commit b74ab1766649724d47256eabe9e739c2a612a670
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Jul 29 14:20:24 2021 -0300

    Fix wrong StreamListener usages and multiple instances of RootAllocators

commit 71781ecfde32dc6c170b62fa472823e201db8af8
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 26 14:44:48 2021 -0300

    Minor refactor: remove unused methods

commit b3af505ebf46c368976c6ae016cbab7cdc8d1ffe
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Jul 23 14:09:38 2021 -0300

    Fix checkstyle violations

commit c8013463a427d6493ac01e51456c36221b42c79b
Author: Ryan Nicholson <rnicholson@dremio.com>
Date:   Fri Aug 21 17:32:46 2020 -0700

    [FlightRPC] Flight SQL POC

    Add extensions in the Apache Arrow project’s Arrow Flight modules
    to provide a standard way for clients and servers to communicate
    with SQL-like semantics.

    Do not pull to master. A message to the mailing list will accompany this
    and another proposal in the coming days for discussion.

commit 5782fef9ad16c8617a7976ce4ba5377618ce034b
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Aug 2 15:36:58 2021 -0300

    Fix pom.xml for flight-sql

commit d4532723f00e99b7e9021f49b17572cd7bbd3b6c
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Jul 29 14:20:24 2021 -0300

    Fix wrong StreamListener usages and multiple instances of RootAllocators

commit e1305e5952d84c1fa1696b2bdc4a81aefa73c2ec
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 28 15:51:33 2021 -0300

    Replace String identifier for queries with ByteString defaults

commit 58cf3268e8e63fd0483eb689aa2211d3462b3e1c
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 27 17:22:21 2021 -0300

    Ensure connection is closed for Statement queries

commit d7a87e7fd0b03efbd451d0b6682ea2882a733039
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 27 13:47:06 2021 -0300

    Minor refactor: remove unused fields @ FlightSqlUtils

commit 9989e276992e7573ffe566b5db90037fd4d60ef2
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 27 13:38:12 2021 -0300

    Add UUID to Statements instead of empty identifier as to avoid conflicts between concurrent queries

commit 0bde81a4d77398929298df3e9e8612f0eefb69ef
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 27 13:26:15 2021 -0300

    Fix conflicts between tests for creating a new statement and checking its schema

commit 45e263d6adb58b95654ab9662870e5a9d859acc0
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 27 11:59:19 2021 -0300

    Add support for querying results upon creating statement

commit c9abb32048d00cc6a838e74f2810126fc0ecaf59
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 15:20:21 2021 -0300

    Nit: fix checkstyle

commit c2b0d82855f8633cddd2a58722eb28ae89f0b28c
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 15:20:21 2021 -0300

    Nit: fix checkstyle

commit e4893e6663c42c301b5d9785a6b0c95f89504450
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 15:19:50 2021 -0300

    Refactor the code to not use string when getting from cache

commit f948e0701395ae10227b36ad497d97acb7825182
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 14:28:57 2021 -0300

    Remove unnecessary extra space

commit 7fb25a4dd8f8d659cc958bb8813041473336e28b
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 28 14:27:29 2021 -0300

    Fix typo

commit dcb045a2fbbc85acd93e374925f1742a595f050c
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 26 16:23:54 2021 -0300

    Fix checkstyle violations

commit 9d44a9a1f96ccd699c868a18df9bab43f9416329
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Jul 26 15:58:58 2021 -0300

    Remove unused FlightSQLExample.proto

commit 4fd4ed51714114671198c30c7364e288836c3202
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Jul 26 15:58:38 2021 -0300

    Rename variable randomUUID

commit 5a0b71d41700cc18eb547dd32f0386ed06244b7c
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Jul 26 15:14:00 2021 -0300

    Remove prepareStatementCacheKey class

commit 02df453fa34399a9d92fdb5ab30a8e31bf99c117
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Mon Jul 26 15:12:31 2021 -0300

    Refactor prepareStatement to use Cache Object

commit dc64ab5a74a2571170e45a550144c132ccecb21f
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Jul 28 17:48:09 2021 -0300

    Fix TestFlightSql.testExecuteUpdate to not hang on tests

commit 9fa3520ec86ff114fc5caee1a12ecdf7974ecd61
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Jul 28 13:57:21 2021 -0300

    Fix AutoClosables.close usage

commit 73727f3ff9c1fdd5390d5f21d2dbcf33a6f961c7
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Jul 26 16:19:02 2021 -0300

    Improve testExecuteUpdate

commit b41ac7453e95b7e0f1ef0df688337786cd9a8747
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Jul 26 15:56:39 2021 -0300

    Implement FlightSqlClient.executeUpdate

commit 4587d9705e3c019f74e5cb6724c2f99c44d5e5ff
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 28 11:21:46 2021 -0300

    Fix GetSqlInfo tests

commit 4ad654ee59448154230e3470cc6f617998ceef39
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 28 11:07:16 2021 -0300

    WIP [Broken]: Expand tests for GetSqlInfo to check required args

commit 225774d5c021b44bd55f3099fa244fc30f8c672d
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 26 14:44:48 2021 -0300

    Minor refactor: remove unused methods

commit 5fb71003356f69afae04a4bdda7d20eabad3cd38
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 26 14:29:58 2021 -0300

    Update getSqlInfo to use constant integers to represent info names

commit 5c4264a44e1264997a42862c0c3918e5ed7f96d4
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 26 10:17:13 2021 -0300

    Make info args nullable for FlightSqlClient#getSqlInfo

commit f660b9eaef65cf094cd6debc043a76791f2491d8
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Jul 23 17:40:53 2021 -0300

    Update GetSqlInfo: separate each section of options by 500

commit 4a12774c707bf7ab6facc805e453d9ac292e9711
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Jul 23 16:30:21 2021 -0300

    Update FlightSQL GetSqlInfo: switch info from String to int for performance optimation

commit 18a2c14de631dfe7fa3343395e3824a089af1888
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Jul 23 14:09:38 2021 -0300

    Fix checkstyle violations

commit 80538369a9e6e2fc33dcaa3ed4cb94a5e975128a
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Jul 23 13:09:16 2021 -0300

    Add Imported and Exported keys schemas to Schemas class

commit 1e88534fa5b0a8a9cc3651499df0f5ad051bcb9d
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Jul 23 11:56:12 2021 -0300

    Fix JavaDoc for CommandGetImportedKeys methods

commit 18971c5d9589806e756577eaa5cd55d1e8e42a67
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Jul 23 11:49:14 2021 -0300

    Implement CommandGetImportedKeys

commit fb7fa006ae9b20e05a4ce00ab5e318c181bfbaba
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Jul 23 11:21:39 2021 -0300

    Change assertion of list from greater than 0 to equal to 1

commit 2eb731519eacfc13a8632752d121ccf48949d1cd
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Jul 23 11:21:14 2021 -0300

    add retrieval of resulSet to try-with-resources

commit d885d40770cd8228b3930db7515d77edd8bfcc65
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Jul 23 11:20:44 2021 -0300

    Rename method getSchemaForeignKeys

commit bbad34a3506a720012ebbacd667bbe67c0422dd2
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 18:08:40 2021 -0300

    make method saveToVectors deal with IntVector

commit 9f4fdcc8a8ed16ff170a1727094092f4e04c4e7c
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 18:08:15 2021 -0300

    Change empty string to null value

commit f0b634ab9edc1d496d7f642d69fd8def5b52f2b9
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 18:06:28 2021 -0300

    Change order of the vectors of FlightSqlExample

commit 4664ca77162380cea49c4972b5de126061f61ac3
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 17:49:29 2021 -0300

    Refactor commands to use StringValue whenever is necessary

commit 7f183c345606bc868d5cff8e125961a509e7b06d
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 17:48:43 2021 -0300

    Refactor creation of vectors for CommangGetExportedKeys

commit ef1721e80bb23f6f370b89b95bd13f03283f793e
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 15:52:57 2021 -0300

    Fix commentary on proto and getExportedKeys method

commit de9ddbd131256647c4084db2e2d50d85df7d4670
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Jul 22 14:41:48 2021 -0300

    Fix CheckStyle issues

commit bf580e83702cd1cc2e3c23b837ce062be88cecac
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Jul 22 14:37:25 2021 -0300

    Use StringValue instead of primitive string on CommandGetExportedKeys protobuf

commit 664f0433423d8bc863d5123997dd1122acff7f34
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Jul 22 14:27:59 2021 -0300

    Fix wrong usage of wasNull()

commit 303e512dd26fa3d06a64069bcda42b00ad105744
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 14:08:23 2021 -0300

    Deal with null values when using getInt

commit d13d4e308d6767661adef11f649fc5ec51e03cdc
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 14:07:05 2021 -0300

    Refactor variable name on proto message and methods

commit c579e520fe654f3c272f9677486d92e2b1e81fb1
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 13:41:06 2021 -0300

    Refactor null values and error dealing

commit 03fa69e770d989c5ac42405151f5f96158f1ba84
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 13:35:30 2021 -0300

    Refactor other tests to reflect the new table created for foreign keys tests

commit 573b4abd5ec7a2f991942a3dfde598a45c9665ec
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 13:35:02 2021 -0300

    create a test for getExportKeys command

commit 3e16ccad6977a0379f5f6327a2f0d177919cd5d0
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 13:33:58 2021 -0300

    Remove star import

commit 2989fdc0aa9275e4ab6772d60bb5bf9525e9399f
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 13:33:14 2021 -0300

    Refactor to use the new CommandGetExportedKeys

commit 4e987877eaf1a7c42cf6e100fc1c40a5ec967b03
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Jul 22 13:31:26 2021 -0300

    Remove unnecessary parameters from ExportedKeys

commit c6c7eec0a59f62dee57460be2ff5180a8cbc54bc
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Jul 21 13:14:29 2021 -0300

    Start separating commandForeignKey into two new commands

commit 363f03d4f642c6fc24cdbe6827e43aad4c6c68b2
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Jul 20 16:16:18 2021 -0300

    Refactor tests due to creation of new column of primaryKey

commit 6186e4f594a54fa49b9ef3de7fed69eb562324d8
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 22 17:35:10 2021 -0300

    Replace FlightSqlExample#buildSchema with helper methods

commit 155654e7989fb16e5ca15c6501101c9d5951484b
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 22 16:39:23 2021 -0300

    Clean up code by moving JDBC-to-Arrow conversions methods to utility class

commit e37aac3928fac0c9ea4b9046caedc89cb71c594c
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 22 15:59:31 2021 -0300

    Update FlightSql protobuf to allow nullable values as parameters for nullable fields

commit fcc5837702bc77b4525d0c545c574565e9ad3966
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 22 15:20:12 2021 -0300

    Change FlightSqlProducer from abstract class to interface

commit 4cfa308c43d647186e05786c016b3bb7b311e233
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 22 11:43:27 2021 -0300

    Fix Schema generation not setting an unknown column type to nullable

commit 10d052b104d99c367f7b4aee70e311b4db00939d
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 20:16:47 2021 -0300

    Extract calendar used by TestFlightSql

commit 70e4110b27d939e3f9e1149bf0a17d6766f28129
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 20:07:43 2021 -0300

    Minor refactor: reuse available helper methods

commit d9818eabf2a10ca42e1bd79a9c9d9f1f54dd255b
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 19:53:51 2021 -0300

    Fix broken tests for CreatePreparedStatement

commit 31174a3054f6d0d3483d871fe30c4b4ef32649de
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 19:31:03 2021 -0300

    Ignore broken tests

commit 71197d1cc87162791145a237fe65b3ca5fc42836
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 16:04:46 2021 -0300

    Minor refactor: apply DRY principle to repeated methods

commit 812223d21f0a58da4e98d0c23148ab86a88a32c0
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 15:55:23 2021 -0300

    Add support for null catalogs @ GetTables

commit b11aa3daa8372dfb0ecbdf57da7cd29fb4066b50
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 15:51:37 2021 -0300

    Fix GetCatalogs tests

commit 2e145507691f1a4aae02f1ae5191b1173275fb81
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 15:39:43 2021 -0300

    Fix checkstyle violations

commit d65370e6d0c8cb6cd35eae57bf62735b84c3361f
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 15:37:35 2021 -0300

    Extract helper method for retrieving schemas for GetSchemas

commit 7db5449cc330e56e1ed46bd25729d9c7a9b12544
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 15:33:05 2021 -0300

    Extract helper method for retrieving schemas for GetTableTypes

commit 55e8df060b212cc76de576ae5581413d97ea1f4b
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 15:11:06 2021 -0300

    Extract helper method for retrieving schemas for GetCatalogs

commit 78bd66923e16362d34107b63bc054cfaba83edfd
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 21 14:58:44 2021 -0300

    Extract helper method for retrieving schemas for GetTables

commit dec516fe78181c06feaba73c70ff95a779fbd3c7
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 20 13:57:47 2021 -0300

    Fix rebase conflicts

commit 28cacc898f5b0c5eac570cb511450c0c8632a70b
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 20 11:18:11 2021 -0300

    WIP: Working on fixing data consistency issue where catalog is null in some parts and "" in others

commit 7af0a93566c608ee9c28d45f891abf3e9635b3b8
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 17:58:55 2021 -0300

    Replace package-protected modifier with private

commit 449d31a255e2c229c5398a4b51c4144477018f39
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 17:15:07 2021 -0300

    WIP: Add support for GetSqlInfo: getSchemaSqlInfo

commit 5ba01e773fdde2ee3b8422ed4385efb18034ad5e
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 15:26:44 2021 -0300

    WIP: Add support for GetTableTypes: getStreamTableTypes

commit fc525a74df6af0e5fdbfef556933778ec222e0ea
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 15:03:51 2021 -0300

    WIP: Add support for GetTableTypes: getFlightInfoTableTypes

commit 4616c066a35ce67ef83aa983532c9efe325686fa
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 14:15:44 2021 -0300

    WIP: Start GetSchemas

commit d036e23741d51107222730b78f067f9214c24fac
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 13:32:33 2021 -0300

    WIP: Add support for GetCatalogs: GetStreamCatalogs

commit 0ff6da121202d7e3c1b4ad4417088874235820cb
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 13:21:58 2021 -0300

    WIP: Add support for GetCatalogs: GetFlightInfoCatalogs

commit 01024de74468dc79ed98ee2434c5693a08f39139
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Jul 21 16:25:19 2021 -0300

    Fix wrong ResultSet getter method on getStreamPrimaryKeys

commit 4011d095f2918333a52f3de0e6b7154b2fb909bd
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Jul 21 15:43:14 2021 -0300

    Refactor duplicate code on getFlightInfo* methods

commit c95eccf16d8f1d41b012ceada5ca277d3f576171
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Jul 21 15:34:38 2021 -0300

    Properly handle SQLException on CommandGetPrimaryKeys

commit 9cf4582cc121b0081e1afb4bd93abee15201c761
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Jul 21 15:34:17 2021 -0300

    Avoid handling empty strings as null on CommandGetPrimaryKeys

commit f484a56bd93caf84fbfe093b0be1114771e81260
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Jul 21 15:00:44 2021 -0300

    Implement FlightSqlExample's GetPrimaryKey command

commit d222c73828f8da94fac210d219ea875d0ab29393
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 20 13:50:42 2021 -0300

    Fix resource leaks for GetTables and CreatePreparedStatement

commit b07de66476408b7dcd52be0785e1b231a6ba13c7
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 20 12:36:23 2021 -0300

    WIP: Working on fixing data consistency issue where catalog is null in some parts and "" in others

commit ba722193a265e4ed5260c4db13b2c6a2dc4ea632
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 17:59:54 2021 -0300

    Replace package-protected modifier with private

commit 4a8f0f6bad2c7a3c8bfb2c919388c916d269e17b
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 17:40:33 2021 -0300

    Fix checkstyle violations

commit 0f6c5a6d0dc2580d1ce771c7bb30b9235cccdacb
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 15:43:14 2021 -0300

    Update Javadoc for FlightSqlExample#getArrowTypeFromJdbcType

commit dcdc114af8a4a1ad71df1bf3ffd78c1cd324c81b
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 15:42:23 2021 -0300

    Add Javadoc for FlightSqlExample#getVectorsFromData

commit 21128053fc6c7e8c43c9ebc09d32b8a5bfb5722a
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 15:39:16 2021 -0300

    Auto-close resources used for GetTables

commit 2239d113acb527379a7b8e1fef494398594688e8
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 15:09:16 2021 -0300

    Remove unnecessary null-check for ResultSet#getInt

commit 211192f304516a57c916261e45786d9c46591973
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 14:54:40 2021 -0300

    Fix checkstyle violations

commit ee4b6dca6798afad7ccc0d393c96ef0d622343c7
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 13:11:41 2021 -0300

    Remove unneeded static imports

commit 05c24b416721a81cafc9d0ad8f1abe4d097a90e1
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 13:00:33 2021 -0300

    Make default JDBC converter private with getter for decoupling and safety

commit 425b381b09925d7eff9251f5c8c46d9726d8b538
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 12:52:20 2021 -0300

    Add TODO note to remove work from FlightSqlExample's constructor

commit 6574db58763ed808a80fd25c55b378fb474b6d95
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 12:37:51 2021 -0300

    Remove unnecessary comments in code

commit 817d2bfb806777e56ab0f99b87b26176fcb433b5
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 12:33:03 2021 -0300

    Remove boilerplate code for creating a new Schema by reusing default converter from JdbcToArrowConfig#DEFAULT_JDBC_TO_ARROW_TYPE_CONVERTER

commit ea4f62079559df4e780ded431a9bdc8d533ad958
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 19 09:58:05 2021 -0300

    Add precision and scale to GetTables' schema

commit 91a4083caa1e86cf7b7a1dd24b3f29d2a285ad63
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Sat Jul 17 17:42:51 2021 -0300

    Fix checkstyle and dependency management errors

commit d37f4e6df0684137511708470d1acb0ac2b85747
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Sat Jul 17 17:35:27 2021 -0300

    Fix tests for GetTables -- shows correct schema

commit f810563ff5ac588c12aa328bb39fae97ab09a0bc
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Jul 16 18:42:50 2021 -0300

    WIP: test cases for GetTables

commit d357998d9168f8d8e191ef2b536f50380d962805
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Jul 16 16:51:52 2021 -0300

    WIP: Fix bug where GetTables returns null if includeSchema

commit 6e62f378d226fe1aa8e17576f50f91d587a768e4
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Jul 16 16:40:26 2021 -0300

    WIP: Fix GetTables for no schema queries

commit fb1376e01ccdda215c5417a5546a24001b527e8f
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Jul 16 15:44:05 2021 -0300

    WIP: Work on getTablesRoot

commit fd6c7c50eed1600cf2adf2a6453a0e06e9752ae5
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Jul 16 13:28:03 2021 -0300

    Update tests for GetTables -- start refactor to use proper schemas

commit d5915effa29cb5970202bcd7e10fc3bfd2a76526
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 15 16:42:55 2021 -0300

    Fix broken tests

commit 992c4baae6b612b23e84bc86715be8423a2b7e49
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 15 16:27:52 2021 -0300

    Remove unused static import

commit a1fb4969ba9d391d5a06574ba6ded7cc6e9a8839
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 15 16:25:01 2021 -0300

    Enable support for includeSchema in GetTables

commit c5144f4ef357894f20081cdc50179b7fdba02b9c
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 15 14:53:17 2021 -0300

    Remove unused fields

commit 429fb4d4d8d071b9796aac4d3b8d54fab79cd173
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 15 14:13:57 2021 -0300

    Fix checkstyle violations

commit cafcd6fbd3af3b10692f1659ec74629c8a5ac556
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 15 14:12:16 2021 -0300

    Fix broken Maven build

commit 40498cc00a7dd6e4f3656b7683f76b52119a8e02
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Jul 15 10:49:17 2021 -0300

    Fix test for GetTables

commit 89918e76fb89200eb7e4ed1d70a99712e195d382
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 14 18:15:24 2021 -0300

    Update tests for GetTables

commit d82990db9a3a1d22d0248be9d25dbb531097f599
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 14 17:22:41 2021 -0300

    Add test for GetSchemas

commit 65424b9e1d87845b5569bd54f15ff71e0ed4aaae
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 14 17:03:08 2021 -0300

    Split up tests for FlightSqlExample

commit 62735198376ca7f5b221f2fc0b8e915190ca8140
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 14 16:44:16 2021 -0300

    Add test for GetTableTypes

commit 86617615eb9cb1eb4ead0292d8aca8cb2cc09fc6
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Jul 14 11:10:45 2021 -0300

    Create test for GetCatalogs

commit c4c9e6127a60da4ae62b7413c4cb48895b199fb0
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 13 16:46:25 2021 -0300

    Update FlightSqlExample for code reusability

commit 44f7ed56da8c97bd4a6daae55e0845c57f798299
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 13 13:48:50 2021 -0300

    Add TODOs for future refactor

commit 6665829bca908a890dce23c89ee885638cd42171
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 13 12:04:54 2021 -0300

    Start re-implementation of tests for CommandGetTables

commit a4a5863f8b726a7790e5bb9cc4230f1597faa273
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 13 10:02:55 2021 -0300

    Update Javadoc; warn about premature closing of resources

commit 41fe35db750b9b4e3a430ba43e8563f917a1c515
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Jul 13 09:51:41 2021 -0300

    Fix bad assertion in tests for simple prepared statement

commit 6b62c13a9a917321534616b9d8d623c51da9d02f
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 12 20:12:05 2021 -0300

    Update tests

commit 7bcab261fe81e177ecb7e86c7817c6dc5147ffff
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 12 18:21:55 2021 -0300

    Clean-up: remove boilerplate code by replacing with tools provided by Arrow Flight JDBC Adapter

commit 9f28ddda170e8564db60d701390079f9e95c43b9
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 12 19:43:50 2021 -0300

    Remove unnecessary overridden method from FlightSqlExample

commit 52ebd2d2bbd9b316ba3df5c891be95ed19ba2a95
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 12 20:07:55 2021 -0300

    Replace static initializer block with @BeforeClass in tests

commit 139f62b0cc0ba9a85e3e7de1fafcfbbb5a3a5216
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 12 19:43:50 2021 -0300

    Remove unnecessary overridden method from FlightSqlExample

commit 7cce16a88d9586b58cf0aa2f777c30ae77bcfba8
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 12 19:41:18 2021 -0300

    Remove unnecessary singletonList in tests

commit d4d0b58fd28e0282a885e588bbc4b39ab50826ad
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 12 19:37:28 2021 -0300

    Replace me.alexpanov:free-port-finder with org.codehaus.mojo:build-helper-maven-plugin:reserve-network-port

commit f39e3726ebb8d761f02229444aa4ebca4be70127
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 12 18:44:49 2021 -0300

    Add Hamcrest as a root-level dependency

commit cc7cc3d4402c082a26d2e71c23cde767e07e88c2
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Mon Jul 12 15:56:07 2021 -0300

    Fix code style issues such as excessive usage of static imports

commit d0f8a97b03142b55a446fda59e70f23325421cd3
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Jul 9 18:22:35 2021 -0300

    Clear broken code for readability -- this will be useful for fixing things faster

commit 1619811f37b3c26eb5b7af2007b9afea19839aed
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Fri Jul 9 17:38:48 2021 -0300

    Fix broken Maven build

commit f813b5fb019ad21c345aefff876d936230d24a9b
Author: Kyle Porter <kporter@dremio.com>
Date:   Wed Jul 7 10:06:34 2021 -0700

    Add support for primary and foreign keys.

commit 090631fe22eb251a82e8e271cd3d3a073a48d6bb
Author: Kyle Porter <kporter@dremio.com>
Date:   Tue Jul 6 16:28:54 2021 -0700

    Additional CR changes.

    Note - FlightSqlExample is not functional and needs to be updated.

commit aacaee029b93d5ad618b29dec78ae94a1f8b9376
Author: Kyle Porter <kporter@dremio.com>
Date:   Mon Jul 5 17:12:44 2021 -0700

    Correct the dense_union type for schema return of SQL info.
    Correct some additional SQL -> Sql file renames.
    Reduce the test compilation problems (still more to do).

commit 3aab4a7ff026c1e6ab9b5d6a0d0878412f1a270d
Author: Kyle Porter <kporter@dremio.com>
Date:   Mon Jul 5 15:25:33 2021 -0700

    Update FlightSqlProducer to conform to new design.
    Rename files for SQL -> Sql.
    Correct compilation errors in client code, but design needs to be updated.

    Tests do not yet compile.

commit 54e6dfeb70acf892dec0c6bbe49850db14c4818b
Author: tifflhl <tiffanylamhl@gmail.com>
Date:   Thu Jan 21 18:15:59 2021 -0800

    Address code review comments (1)

    - Address code review comments from https://github.com/ryannicholson/arrow/pull/2

commit 4edf6b7e21ea8fb5cf14d48b8a88bf93b90b7ce1
Author: Ryan Nicholson <rnicholson@dremio.com>
Date:   Wed Sep 2 08:32:31 2020 -0700

    Rename "getSQLCapabilities" to "getSQLInfo" in FlightSQLProducer

commit ec981a298cee568ae27345295ec49d8109d2a37c
Author: Ryan Nicholson <rnicholson@dremio.com>
Date:   Tue Sep 1 17:44:18 2020 -0700

    Alter GetSQLCapabilies to GetSQLInfo pattern

    Alter GetSQLCapabilities to model after Hive Thrift's
    TCLIService.

commit 4d4082d172162c68dee2a098d7b229e93dd9c147
Author: Ryan Nicholson <rnicholson@dremio.com>
Date:   Tue Sep 1 09:45:38 2020 -0700

    FlightSQL.proto formatting feedback

    Update with initial formatting/naming feedback and
    add ResultsOrder enum.

commit 7409fb41bdafff93ade4e83603d697315409e0fa
Author: Ryan Nicholson <rnicholson@dremio.com>
Date:   Fri Aug 21 17:32:46 2020 -0700

    [FlightRPC] Flight SQL POC

    Add extensions in the Apache Arrow project’s Arrow Flight modules
    to provide a standard way for clients and servers to communicate
    with SQL-like semantics.

    Do not pull to master. A message to the mailing list will accompany this
    and another proposal in the coming days for discussion.
@rafael-telles @lidavidm
ARROW-14421: [C++] Implement Flight SQL
22bd624 
Squashed commit of the following:

commit 72ce72ba855909052f7dfb898105b419697157c8
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Dec 6 16:55:20 2021 -0300

    Fix documentation for GetSqlInfo on FlightSql.proto

commit 076187ec3aa18295c92de1f38b9036e66fa8ca7e
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Dec 6 15:02:45 2021 -0300

    Add better description to table types on FlightSql.proto

commit 9a9b536acf207456c8050d165c4f1a12c7d71010
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Dec 6 15:01:21 2021 -0300

    Change SQL_NUMERIC_FUNCTIONS result on sqlite_sql_info to uppercase

commit dd9d507997e1bcf88aeb3511889dcb3f6b777283
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Dec 6 15:00:19 2021 -0300

    Remove dependency on boost/lexical_cast.hpp

commit 023f71a12fbd233dbba2571c7935db454516293e
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Dec 3 16:47:34 2021 -0300

    Use std::generate_n to generate random string on sqlite_server.cc

commit 6a928ca82ae69e579d4785c092d069f6b2439ceb
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Dec 3 17:09:25 2021 -0300

    Move implementation of methods and data from SQLiteFlightSqlServer to SQLiteFlightSqlServer::Impl and remove dependency of boost-uuid (#221)

    * Use pimpl idiom on sqlite_server and add comments on protobuf file

    * Correctly implement impl pattern

commit cfe9e2ac79412d375e1415f40445589fd33500d6
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Dec 3 16:27:46 2021 -0300

    Use EXPECT_RAISES_WITH_MESSAGE_THAT on TestFlightSqlServer#TestCommandGetSqlInfoNoInfo

commit de8600ca83046bdb51b1a6e1c6420e36896d7e3d
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Dec 3 13:49:55 2021 -0300

    nit: Fix indentation on cpp_build.sh

commit ea94097953448a48ebd31215113859f00d06dc4a
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Dec 3 12:15:44 2021 -0300

    Use TCP instead on unix sockets on server_test.cc

commit 99ae0216466aee26944b31e10d46d2c3f372842d
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Dec 3 12:03:45 2021 -0300

    Remove need of RunServerInternal

commit 2b3839aff39b474d77d515e0ce6290e8e1a9f81a
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Dec 2 13:48:49 2021 -0300

    Remove generated protobuf enum from example application

commit 8431e41bddda5abc8aeec8a363b40deab352e5a4
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Dec 2 13:35:56 2021 -0300

    [C++] Address ratification comments (round 4 - part 4) (#215)

    * Make other methods from SQLite server example to return arrow::Result instead of Status

    * Fix bug for null values in numeric columns on SQLite server example

    * Structure catalog-schema-table tuple on a TableRef struct on client

    * Rename 'schema' to 'db_schema'

    * Use TableRef struct on server.cc

    * Undo renaming db_schema_filter_pattern

commit fe9d7dc5a1b26a00c789cee969e750479353f581
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Dec 2 13:28:23 2021 -0300

    Make sure to wait for server to be ready before running tests (#220)

    * Make sure to wait for server to be ready before running tests

    * Start server independently for each test

    * Use unique_ptr for server thread on server_test.cc

commit e8d8a13aa82c0ec929a103dcc81f250ab0dda02b
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Nov 26 13:59:04 2021 -0300

    [C++] Address ratification comments (round 4 - part 3) (#214)

    * Make other methods from SQLite server example to return arrow::Result instead of Status

    * Fix bug for null values in numeric columns on SQLite server example

    * Add comment regarding to performance on sqlite_statement_batch_reader

    * Separate GetSqlInfoResultMap from sqlite_server.h

    * Remove unused parameter on DoPutCommandStatementUpdate

commit c36b81706a9d6260a733b5ad48baa26694759ddc
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Nov 26 13:25:38 2021 -0300

    Remove PRECOMPILED_HEADERS option on arrow_flight_sql's CMakeList.txt

commit 9e3c928cd870c81f1e2f4e2210c1fb3b05a4182e
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Nov 25 16:24:16 2021 -0300

    [C++] Address ratification comments (round 4 - part 2) (#213)

    * Make FlightSqlClient::GetFlightInfo return a Result instead of Status

    * Make most methods on FlightSqlServerBase to return a Result instead of Status

    * Move private functions on server.cc to anonymous namespace

    * Fixes on doxygen and better readability on server_test.cc

    * Rename fields on client_test.cc to follow the convention

commit 7d74b7efce86f77fd1b42716cec4d6b7c3a3bd13
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Nov 25 11:15:37 2021 -0300

    [C++] Address ratification comments (round 4) (#212)

    * Fix minor issues on sql_info_internal

    * Change table_types parameter to be a pointer

    * Improve GetSqlInfo error in case of no info

    * Replace ArrayFromVector to ArrayFromJSON in most cases

    * Improve server_test assertions and code quality

commit 56d84e9fd210a74c0aea7fb4675b76e35e12de76
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Nov 19 14:27:50 2021 -0300

    Rename directory flight_sql to sql (#210)

commit 9fcacf22c236ce45fd31ce13b0c4cf1370dee877
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Nov 15 18:13:57 2021 -0300

    Fix CMake minor issue, add sql_info_types.h

commit 76d04ea0dff846a1a3f5bf0176af1e287f4c05d3
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Nov 15 17:36:24 2021 -0300

    [C++] Fix comments on ratification PR (round 3) (#205)

    * Fix comments pointed on review

    * Replace boost::variant to arrow::util::variant

    * Remove unused macros and redundant definitions

    * Refactor sql_info_internal to prepopulate builder pointers on constructor

    * Replace ArrayFromJSON usage to ArrayFromVector for consistency on tests

    * Remove mention to GetFlightInfoForCommand from doxygen

    * Remove copy constructors on SQLInfo related visitors

    * Remove move constructors on SQLInfo related visitors

commit fd9bd948002ec393b05a1dfe50f4c8dceb5e4635
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Nov 15 11:25:53 2021 -0300

    Fix build when BUILD_EXAMPLES or BUILD_TESTS is OFF

commit f0555708f3b386382b1f32e28c825dce9802171b
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Nov 12 13:03:49 2021 -0300

    Enable Flight SQL C++ on CI

commit 6c98d52656971a00cd863c40ca87708a6c1e4488
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Thu Nov 11 16:38:45 2021 -0300

    Fix FindSQLite3Alt.cmake

commit 3cee40c5ddf7fc066e2d473202576284a946e66b
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Nov 11 14:56:58 2021 -0300

    Fix code style issues

commit ec1c4d0e2b36ef51a18cd28fdad6783bd3d69430
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Nov 11 13:21:25 2021 -0300

    Fix ODR violation when linking protobuf

commit 2e48187c2c683ea82f79d1abef520b385ed66b69
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Thu Nov 11 13:53:06 2021 -0300

    Fix method docs on server.h

commit c778682eee06d1dd6bb744ce979b165b8c1b8bc4
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Nov 11 08:50:21 2021 -0300

    Change Status to arrow::Result on CreateStatementQueryTicket method

commit 45b58cb00a48a751b231ecd054fe48e6e8741767
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Nov 10 17:31:05 2021 -0300

    Add documentation on public method GetFlightInfo

commit 6908d3851b1c85a9db15bb58c20ab818d7a98ef2
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Nov 10 17:21:02 2021 -0300

    Change status type on sqlite classes

commit 26f0c194fce55951d1c4af96e69b3cd0862e046d
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Nov 10 17:20:35 2021 -0300

    Make parameter ordering consistent

commit 8ececc8b17431fc50b40d2a045f86adc1d41974b
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Nov 10 17:19:21 2021 -0300

    Remove old use of CreateStatementQueryTicket

commit 9e352e3a77231942562964c968926d32e3d4cea2
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Nov 10 17:18:48 2021 -0300

    Change CreateStatementQueryTicket to a free function

commit 776d739476793cd47f70f156e144f966ec338126
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Thu Nov 11 11:25:45 2021 -0300

    Fix method docs errors on server.h and sqlite example

commit 404b27deb0df2833175a58efe63eaf718e50ffd1
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Nov 10 17:29:01 2021 -0300

    [C++] Implement GetSqlInfo on server example (#193)

    * WIP: Implement GetSqlInfo on server-side

    * Fix build and missing code parts

    * Add test for map<int, list<int>> @ GetSqlInfo

    * Fix integration tests

    * Fix comments pointed on review

    * Fix comments pointed on review

    * Add more comments about the logic around DenseUnionArrays

    * Remove unnecessary includes on sqlite_server.cc

    * Fix comments pointed on review

    * Use std::vector reserve and assign to avoid allocating temporary object

    * Remove unused dependencies on server.cc

    Co-authored-by: Abner Eduardo Ferreira <abenaru@pm.me>

commit 817baf9a5d347fc5d8cbf9c598458fbb85acfc3a
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Nov 10 15:05:20 2021 -0300

    Fix code style issues

commit 93f93c4c1148b394b660461f20a8a7511ff23546
Author: Jose Almeida <53087160+jcralmeida@users.noreply.github.com>
Date:   Wed Nov 10 14:27:18 2021 -0300

    [CPP] Fix issues from client files in flight-sql (#201)

    * Order include and rename protocol namespace

    * Change a reference to pointer in the client client and refactor the name of namespace on functions

    * Nit: remove empty line

    * Improve naming from protocol::sql namespace

    * Fix include and its orderding

commit 0519976bc9299607444c0f21141b939da6142da0
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Nov 10 14:23:05 2021 -0300

    Update vcpkg.json and remove unused variable on CMakeLists.txt (#200)

commit df1ce715fe6382979ceaa11cfc6e66d5219a5562
Author: Jose Almeida <53087160+jcralmeida@users.noreply.github.com>
Date:   Wed Nov 10 13:32:53 2021 -0300

    [CPP] Modify the way arrays are created in tests (#199)

    * Create array using method ArrayFromJson

    * Create array using method ArrayFromJson in server tests

    * improve conditional from if statement

commit 35a530ae5a8e0ca2dd5374bbddc94ebe10aef745
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Wed Nov 10 12:13:15 2021 -0300

    Fix FindSQLite3Alt.cmake

commit 5e1c200bffcec0e7f3a4038177233f5df9e46957
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Wed Nov 10 08:38:32 2021 -0300

    Fix linter erros on FindSQLite3Alt.cmake

commit 5f5ea06da8b7c62ea9419add7750f37fdedbf87f
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Wed Nov 10 08:37:05 2021 -0300

    Fix wrong parameter name on SetParameters docs on client.h

commit d40ef9994e532538615d4ca16a908db1dd8df631
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Nov 9 17:57:42 2021 -0300

    Reestructure FlightSqlClient to use virtual methods (#195)

commit 093b539df8f16e6e319869b7acbdae7789e91e47
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Tue Nov 9 16:03:32 2021 -0300

    Fix protobuf version on flight-core

commit 71f877df2e34b10e5c83e3540aca164ec0d46873
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Mon Nov 8 16:13:34 2021 -0300

    Remove wrong line on CmakeLists

commit 0b32b272ac1bd9b16d1bd4a7d2521db9780ffc30
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Mon Nov 8 15:03:58 2021 -0300

    implement FindSQLite3Alt on cmake modules

commit e2e57ae39876e1978138ca2b3d66ea9ecacaf7fc
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Thu Nov 4 13:04:00 2021 -0300

    Fix sql_client close before server stop server test

commit f604d468f9ba885a51f738c93c055d8f8d064f19
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Thu Nov 4 13:00:14 2021 -0300

    Fix sql_cliente close before server on server test

commit 9135703c25e4f54bd3d487676ce62739fbb3e52e
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Thu Nov 4 12:41:09 2021 -0300

    server.reset() and sql_client.reset() on server test TearDown

commit 2483ff4cfd7674a2ad5f6a432569419bcbf179d9
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Thu Nov 4 11:49:11 2021 -0300

    Change sql_client to unique_pointer on server test

commit 46569759a234cf62a1897bdd2ae12687faba852c
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Wed Nov 3 18:23:23 2021 -0300

    Change server to unique pointer on server tests

commit 698645d127de4647e72cc93236f4700fc0a7a6ea
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Wed Nov 3 17:26:24 2021 -0300

    fix server stop on serve rt

commit 70bda0c5c117121787922987b6687749c73a2ea0
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Wed Nov 3 16:01:06 2021 -0300

    Fix test_server

commit 24343e24df274eb1566971ab139f7ac33dc5fb6a
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Wed Nov 3 15:42:56 2021 -0300

    Fix memory leak with mock

commit 89b4f17cf9aac989f9aa09fa6a0d2113532d9a9d
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Wed Nov 3 14:04:58 2021 -0300

    fix: correct issues on tests

commit 996c708e6835adad8468d5ece6ba5e5ca2693d4b
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Tue Nov 2 16:28:08 2021 -0300

    Format test files

commit d480e77dd7c54a18823f2af3f676755d8f4e8785
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Thu Oct 28 14:55:12 2021 -0300

    Made fixture to client_test.cc to avoid duplication

commit 75f67ad5e2cefde1cd0d6145a928066b6a9b5215
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Wed Oct 27 11:02:19 2021 -0300

    Fix some issues on CMake and Server Test

commit 4abcd45a0e0706c9d8da1cbb79807971acbb0bf1
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Tue Nov 2 15:18:00 2021 -0300

    fix: merge test client

commit 39f63c24e41a8f9d83793696e38435dc83890e87
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Thu Oct 28 14:55:12 2021 -0300

    Made fixture to client_test.cc to avoid duplication

commit 9ef1cae7645fc4456d55d6bd8e365368b69b8533
Author: Juscelino Junior <juscelinojunior@id.uff.br>
Date:   Wed Oct 27 11:02:19 2021 -0300

    Fix some issues on CMake and Server Test

commit 697cde3dab946f727d56d7a0cbdec68ce7b9a301
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Nov 3 17:54:35 2021 -0300

    [C++] Ensure client_test.cc does not violate ODR (#192)

    * Ensure client_test.cc does not violate ODR

    * Format CMakeLists.txt

commit 9716a20c949717eeb3db064df9ee15184d0bea2d
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Nov 3 16:12:07 2021 -0300

    Fix issues reported by cppcheck

commit 92c546444714402dbf7e25f6643c08951e98c800
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Nov 3 13:17:52 2021 -0300

    Remove unused variable on CMakeLists.txt

commit f080caa3739a71992bf11ec37c03485eb604f763
Author: Jose Almeida <53087160+jcralmeida@users.noreply.github.com>
Date:   Tue Nov 2 17:42:37 2021 -0300

    [CPP] Fix on sqlite classes from FlightSqlServer (#181)

    * Change FlightMetadataWriter and FlightMessageReader from unique_ptr to raw ptr

    * Change reinterpret_cast to dynamic_cast

    * Add const to sqlite3Stmt getter

    * Add const to string parameter

    * Using ARROW_ASSIGN_OR_RAISE to buffer and batch creation

    * Change from unique_ptr to raw ptr

    * Change sqlite_tables_schema_batch_reader extension from cpp to cc

    * Avoid instantiate a string object

    * Make ExecuteSql return Status

    * Change Create methods from sqlStatement to return Result<T>

    * Fix from rebase

    * Fix from rebase

    * Fix server initialization

    * Fix checkstyle

    * Add missing ;

    * Fix docs on methods

    * add explicit to sqlite_server.h constructor

    * Fix double free

    * Add comment of ownership to SQLiteFlightSqlServer constructor

    * Fixed possible close with null_ptr on sqlite classes

    * Fix style issues

    * Use static_cast instead of dynamic_cast

    * Fix other review comments

    * Use 'static_cast' when casting scalars on sqlite_server.cc

    * Fix comments pointed on review

    Co-authored-by: Rafael Telles <rafael@telles.dev>

commit c079a477bb849594ff1e899dab4983519bed8d90
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Nov 2 17:30:40 2021 -0300

    [C++] Use util::optional on Flight SQL structs (#191)

    * Use optionals on Flight SQL command structs

    * Use delete instead of free() on server_test.cc

    * Un-nest PreparedStatement class from FlightSqlClient

    * Make PreparedStatement::IsClosed const

commit b26bfc40d4a85d0a685d7a985e1541828f613027
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Nov 2 14:54:53 2021 -0300

    [C++] Other fixes for ratification (#190)

    * Rename sqlClient to sql_client on test_app_cli.cc

    * Add missing parameters on PreparedStatement constructor

    * Add NOTE to PreparedStatement destructor

    * Parse PreparedStatement's dataset and parameters schema when constructing

    * Rename Flight SQL Actions constants

    * Remove unnecessary 'using' keyword on server.h

    * Clean up header files and includes

    * Rename getters for schemas on PreparedStatement and make them const

    * Handle possible protobuf parsing errors on server.cc

    * Move CreateStatementQueryTicket implementation to sql namespace

commit 8095b6e9b8593fb15d528c863f9d9a8963b02013
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Nov 1 14:04:48 2021 -0300

    Remove unused includes on server.h

commit 166bb6b40544ea0a58354b1e553711338ceddcea
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Nov 1 14:02:01 2021 -0300

    Rename directory flight-sql to flight_sql

commit d89a82ee66a67e22e88dca5a766a3c0e57d9c1f1
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Oct 28 17:57:08 2021 -0300

    Remove unnecessary const modifiers on client interface

commit 838469fae0a8cab867d3574a74d0ffccd6a5faa4
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Oct 28 17:23:04 2021 -0300

    Remove explicit using of GFlags namespaces

commit 3d0dcfecb203fe89354a0422592873a17bc8ca92
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Oct 28 17:07:26 2021 -0300

    [C++] Remove templating from client interface (#184)

    * Fix variable initialization

    * Remove templating from FlightSqlClient and PreparedStatement classes

    * Fix inconsistent member names

    * Make PreparedStatement an inner class of FlightSqlClient

    * WIP: Use references on FlightCLientImpl methods

    * Use shared_ptr<FlightClientImpl> to avoid dangling pointers

    * Log error when deleting PreparedStatement

    Co-authored-by: Jose Almeida <almeidajcr90@gmail.com>

commit f1199debe277b0629692d27d0a409b016b6107df
Author: Jose Almeida <53087160+jcralmeida@users.noreply.github.com>
Date:   Thu Oct 28 16:56:28 2021 -0300

    Add ARROW_EXPORT and change designated initializer from struct (#189)

commit 4dfa02606adbea3947696024d9fc50a6336bbce9
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Oct 27 13:17:40 2021 -0300

    Handle errors on all Parse and Unpack calls to Protobuf (#185)

commit 92b7b48a346f46d4f0049ea6479a29609ade7399
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 26 17:52:14 2021 -0300

    Improve DoPutUpdateResult parsing

commit 6ab6e27e2262a5bc535e075747693e97740ee190
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Oct 26 13:49:46 2021 -0300

    Change ASSERT_TRUE to AsserTableEqual()

commit 30929b7920d477c2a9f2d7d69dc5d9253c4349f2
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 26 11:55:35 2021 -0300

    Fix linting issues

commit 5acfa2325674dd61a31e6146e5e29289d1ffbd72
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 26 11:29:48 2021 -0300

    Fix compiler warnings on client_impl.h

commit fdbe5f1a6368d3232bc62fea0cd4663e61e67cf8
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 26 11:19:41 2021 -0300

    [C++] Wrap Protobufs on server (#182)

    * WIP: Wrap CommandStatementQuery protobuf into a struct

    * Wrap all Protobuf for commands on server

    * Change Parse methods as anonymous functions

commit 5010c1baac182dc7b318e67a6c91da3d4cf66f79
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Oct 25 15:42:35 2021 -0300

    Fix flaky tests

commit ba7332757b197a34c2b3619690419816f0c62820
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Oct 25 15:00:08 2021 -0300

    [C++] Improvements on CMakeLists.txt (#178)

    * Remove extra options on CMakeLists.txt

    * Remove GRPC-related instructions from CMakeLists.txt and guard SQLite requirement on ARROW_BUILD_TESTS

    * Remove redudant dependencies on CMakeLists.txt

commit 9a96bbdcd1befd5c93aa9bbd47dcd4a78c070666
Author: Jose Almeida <53087160+jcralmeida@users.noreply.github.com>
Date:   Mon Oct 25 14:23:50 2021 -0300

    [CPP] Change the way arrays are created in flight-sql tests (#179)

    * Create arrays using methods MakeArrayOfNull and ArrayFromJSON

    * Fix checkstyle

    * Remove macro declare binary array

commit 3895b53c5a49b37ebc403c7aa4f897eb06a85209
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Oct 25 11:26:31 2021 -0300

    [C++] Improve Client interface (#180)

    * Use '#pragma once' on header files

    * Remove ghost parameter on Doxygen for PreparedStatement.Execute

    * Change client interface to use Result instead of Status

    * Rename sqlClient to sql_client on tests

commit 655d8dd0b88ccfc0905226dc6fa1058c9917f22c
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Oct 22 16:26:19 2021 -0300

    Use ASSERT_OK on client_test.cc

commit 87e02ac0921ff4277adf8dae10347f222c9b0c37
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Oct 21 14:06:38 2021 -0300

    Fix linter issues

commit 8b5324f730ca55cc556b3e9517ca40af7826dac6
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 19 11:18:17 2021 -0300

    Rename flight-sql/server.cpp to server.cc

commit e9aafe7c3e9dafa348bf9efea9bc8e2dfd3d091f
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 19 11:09:31 2021 -0300

    [C++] CommandGetCrossReference (#172)

    * Add CommandGetCrossReference on FlightSql.proto

    * Implement CommandGetCrossReference on C++ client

    * Implement CommandGetCrossReference on C++ server example

    * Update FlightSql.proto

    * Update FlightSql.proto

commit 84ae269e1f131e175bc254cb7bef408b957870a7
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Oct 18 16:10:10 2021 -0300

    Implement CommandPreparedStatementUpdate on SQL server example (#169)

    * Implement CommandPreparedStatementUpdate on SQL server example

    * Refactor sqlite_server to avoid duplication

commit d0e94764bbfc0dc0f6485b122b875f6de1d6e58c
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Oct 18 14:21:42 2021 -0300

    Fix wrong error messages on server.cpp

commit 6248009942d05bd955c1f6e4ef4a67c8ac3311bb
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Oct 14 17:59:19 2021 -0300

    Rename server files

commit a89a8ffec3a0080cc0ab28fe78599c50afc6c782
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Oct 14 17:28:38 2021 -0300

    Fix CheckStyle issues

commit b30041539f491f31df46abd94e121cd870931905
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Oct 14 14:15:38 2021 -0300

    Fix resource leak where record batch is being created for client_impl.h

commit 5d03029a092075b7ff816cf32f995f864aaf4bb0
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Oct 13 17:57:26 2021 -0300

    Minor refactor: move variables closer to used

commit ade534d655d4ad99da920db891015774a034f2df
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Oct 13 16:04:20 2021 -0300

    Fix SIGSEV in test case for PreparedStatement.ExecuteUpdate with parameter binding

commit b9205c1de5b11e89c3c3bee5d24305f2ba8bd4ad
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 13 15:32:41 2021 -0300

    Refactor ExecuteUpdate with parameter binding test

commit 14d2725e337e1d297eeb6638742f94c5bf560728
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Oct 13 14:46:46 2021 -0300

    WIP: Refactor test cases for PreparedStatement.ExecuteUpdate to use lambda functions

commit 464248d4ef4fa8b9f17be8b96f5671f0f9eec2a6
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Wed Oct 13 12:05:25 2021 -0300

    WIP: Refactor test cases for PreparedStatement.ExecuteUpdate

commit 86fe0463d75db9059b4a73a3d71a4a17ccf05905
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Oct 12 17:33:48 2021 -0300

    Fix rebase issues

commit d9ab9348e49ed2aef29183df0f0315693cc6b676
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Oct 12 17:19:46 2021 -0300

    Add test case for PreparedStatement.ExecuteUpdate with parameter binding

commit 2d23d07476b9be306507a00b76ffd8eae5053b7b
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Tue Oct 12 16:36:22 2021 -0300

    Fix broken test for PreparedStatement.ExecuteUpdate without parameter binding

commit 22320fd20ecf83e92406df0dd3c3d97d7f465895
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Oct 8 18:04:35 2021 -0300

    Make changes regarding to reviews

commit 247be5bc7b0fdef71d4ce16747fc1185b59bb245
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Oct 8 18:04:35 2021 -0300

    Make changes regarding to reviews

commit a9c11db01101843e96e8c88468959bd9b8e21e4f
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Oct 8 15:07:01 2021 -0300

    Add integration tests for PreparedStatement query

commit 54ecc387d745b38b66f1bd6a1d0d96cc05cd9ffa
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Oct 8 14:04:05 2021 -0300

    Add missing docs for GetArrowType

commit b8417b1a2295730772de68975b7a82c0e1bb655d
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Oct 8 13:55:19 2021 -0300

    Remove GetArrowType method duplicate

commit 66a0e41244bc3aa2df7a935dfcd2cc735d3bb138
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Oct 7 13:35:55 2021 -0300

    Implement parameter binding on Flight SQL server and example

commit 1bf1ea0dd737c89be10646be2a99b6bd08c3106f
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 5 15:15:03 2021 -0300

    WIP: Implement prepared statement on server example

commit 1e437aa119dd8d807918ba46b7b8ec8076142a35
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 5 14:00:35 2021 -0300

    Add Create/Close prepared statement actions to sql_server

commit 6e2c9e9bf84ccad95cf700a3ac4b94d7636039b7
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 12 15:27:09 2021 -0300

    [C++] Implement CommandGetImportedKeys and CommandGetExportedKeys (#163)

    * Implement CommandGetImportedKeys and CommandGetExportedKeys on Flight SQL Server example

    * Refactor DoGet methods to reduce code duplication

commit 171d540ac82c3b4bfbb0a5ab53f9d9362dc7c67e
Author: Jose Almeida <53087160+jcralmeida@users.noreply.github.com>
Date:   Tue Oct 12 14:31:14 2021 -0300

    [CPP] Implements GetPrimaryKeys on flight sql server (#162)

    * Add Schema template for the primary keys

    * Implement GetPrimaryKeys on server

    * Add an integrated test for GetPrimaryKeys

    * Fix checkstyle

    * Add a comment to the query on primary keys query

    * Use GetFlightInfoForCommand helper method on GetFlightInfoPrimaryKeys

    Co-authored-by: Rafael Telles <rafael@telles.dev>

commit e8efe631e106c2dc9788af6db99899353a7b10d4
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Oct 8 15:57:04 2021 -0300

    Implement CommandGetTableTypes on server example

commit 042fcc250c597bb03e95901b739251b68ff04557
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 8 15:17:46 2021 -0300

    use variable close to its use

commit afd0e3e8c6af317d23dbfb0ad64b9ee8c1aeaf21
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 8 15:17:00 2021 -0300

    Add comment when calling ReadMetadata on DoPut

commit 51462791dcb003b4b2e56795403577e646ef78b7
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 8 15:16:28 2021 -0300

    Sort includes alphabetically

commit 2f1c93585632e62e6baf73c6f0d5f977015eca31
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 8 15:15:54 2021 -0300

    change const references from setParameters method

commit 8327b47cb50c3808e0ed06fc63ac99419efc3a35
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 8 14:21:43 2021 -0300

    change (void) to ASSERT_OK on test

commit 432b0267573138134219e78d22fc9aea4e4c92f6
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 8 14:21:26 2021 -0300

    Implement method GetResultSetSchema

commit eb2f76ce63cbbe514288886f9c8ab5c0157971c9
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 8 13:39:56 2021 -0300

    Add missing docs to prepared statement methods

commit e3facf744f7ad0d4466a28121a522a8542020387
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 8 13:27:35 2021 -0300

    Add prepared statement parameter binding to test app

commit b59afc612594fdcfa64f1d633c263856f044d25b
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 8 13:27:11 2021 -0300

    Create a mocked client test for parameter binding

commit 15a6b3d17ce168a30c83049185bd9a97c7ad5311
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 8 13:26:00 2021 -0300

    Pass option to DoPut CALL

commit b19552ee18036912f21994f20349fb831206b345
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 8 13:25:35 2021 -0300

    Fix add a break line

commit b2b1b8c3c854048ef793160e69a8f098ab4133a0
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 14:50:34 2021 -0300

    Add macro ARRROW_RETURN_NOT_OK

commit 9ccb72e90d2bee8d77b704156f99f2785665191e
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 14:49:28 2021 -0300

    remove TODO

commit 7f9daa9f467461c3b4010417588131c05b8d8fa8
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 14:49:00 2021 -0300

    remove unused code from test_app

commit 832aec33f9b3667e7d60681a1acd70f3bcdb26d6
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 13:29:57 2021 -0300

    add paremter binding to query execution with prepared statement

commit e98fd67350e7c8839a1bdc361cb55c07a026e501
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 13:29:25 2021 -0300

    Add methods to set and get parameters

commit e85e8f84e04a1e6fb60672ae352481fd45a8a3fc
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 15:39:18 2021 -0300

    Fix checkstyle

commit 46c568171b8d0f45a19b6929e5fac7f6d605e64b
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 5 13:14:55 2021 -0300

    Implement CommandGetSchemas

commit ca738150306bab8866f4398749d697fdfddf7000
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Oct 7 17:49:05 2021 -0300

    Add missing docs for DoPutCommandStatementUpdate

commit 08b029434dcae677e27f53fe4cc1d7fec02f0b7e
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Oct 7 14:20:27 2021 -0300

    Implement CommandStatementUpdate on server example

commit ac77dbc9b310271b8ec578d96299e8b05dc4cb0b
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Oct 7 17:52:07 2021 -0300

    Change SqliteStatement.Reset argumento to pointer

commit dcc8f7fb5f80d69abe78334dd0eb0ad770411772
Author: Abner Eduardo Ferreira <abenaru@protonmail.ch>
Date:   Thu Oct 7 15:37:01 2021 -0300

    Add GetSqlInfo on client side for FlightSQL

commit f8f404ada1c5fd778a60912597c61f5f1a0d8bd4
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Oct 7 15:06:11 2021 -0300

    Remove duplicate import

commit 3c3b928fd22ad1b35421eb7108dfa336f5bc3073
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 14:44:12 2021 -0300

    Make the mock object be called twice

commit a9361aa41958be9494da639a6bc495b31bf4120f
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 14:16:18 2021 -0300

    Remove options as parameter from PreparedStatement methods

commit 6759818b9567692dad9e6166a897b06041f98b66
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 14:04:10 2021 -0300

    Make the destructor call the Close method

commit 8f23bd5953697a7559d9e8818f91ff65c9cd4969
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 13:50:24 2021 -0300

    rename the variable of the CommandPreparedStatementQuery

commit d30cef29e2a51c2bc4d476471b0e7740dd029098
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 13:49:51 2021 -0300

    Move constructor to the top of the file

commit de161ec9d10eb1a8cf563e4b33cce247f24fd764
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 13:49:17 2021 -0300

    Remove extra lines and duplicated import

commit 8d60000190848035b3d138a3f92ea6ad331d2b3d
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 16:42:19 2021 -0300

    Remove duplicate function due to rebase

commit 78b454094835bff1a829f3dec1e3cbb4a5d0fcf3
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 16:28:22 2021 -0300

    Modify the constructor of the PreparedStatement

commit f80bfafaa4b93513010b0fe4651720a87f6f8a25
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 16:28:10 2021 -0300

    Pass options to the client calls

commit 4b0adb6cabf9f357ca7afe53ea64d5b8a0aa262d
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 15:13:30 2021 -0300

    Fix test_app for prepared statement execution

commit 297b7f06968e859149b6adca4aa4d4f7d5e2f637
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 15:09:04 2021 -0300

    Treat if the statement is already closed

commit a46dd6db945744c0b7f7ae81cf4abc6a07475f2d
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 14:59:15 2021 -0300

    Adding missing files from rebase

commit 9414a2ef4a054ced35ed7c49dd9963db879dfa01
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 14:59:05 2021 -0300

    Fix checkstyle

commit a5c362c2f59929f3fe4077c87f882a3f1b09ebca
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Oct 5 22:31:36 2021 -0300

    Add a branch on test_app to execute a query with PreparedStatement mode

commit fe96fe096dbba6088808dee434f262aeda5d304b
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Oct 5 22:31:09 2021 -0300

    Refactor the creation of the PreparedStatement on sql_client

commit ea75e69ba05b25b5aaa9752a91cd046edd1135f7
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Oct 5 22:18:31 2021 -0300

    Create a mocked sql_client test for the preparedStatement

commit ee1ed1930d8f3374760388f7ac394f6197174629
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Oct 5 22:18:12 2021 -0300

    implemenet methods PreparedStatemenetClass in sql_client

commit 83b1c169d6604b346d373509e301cb10f56aec49
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Oct 5 22:16:37 2021 -0300

    Add PreparedStatementClass to sql client

commit 3b08157e1ab88515e4f67c966868ccd31a4ac033
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Sep 29 17:16:52 2021 -0300

    Implement CommandGetSchemas

commit 3066113d217e508d409c27c8eb626682057cd629
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 15:39:18 2021 -0300

    Fix checkstyle

commit 70800d0a19d046aefd6b4ced477a9a339846e81d
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Sep 28 16:09:27 2021 -0300

    Add the schemas to be used by the GetTabkes

commit 2a221a6a957c479253fa820c792fec6e573df2c6
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 5 13:14:55 2021 -0300

    Implement CommandGetSchemas

commit 1036ec8c11f1a7992f7a435762702dbc199152c7
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 13:39:21 2021 -0300

    Remove extra line

commit a7ff4573a72ffed2eb401ae291b29dc0b3477b12
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 13:39:09 2021 -0300

    Add missing return at docs from SqlSchema methods

commit 6c52c281353322d9416e10d2d393bbfe46ffbcfd
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 13:35:22 2021 -0300

    Passes the rc variable as reference to Reset method

commit b7089548f4219cbb8e994d24da427a0bd060aa00
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Oct 7 13:32:12 2021 -0300

    Remove unused RecordBatchReader

commit 250a3c4b4a3db0967c17bb8384c8e3ad7976d598
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 16:11:18 2021 -0300

    Add missing include

commit 95e7507622be9037b819a17ed7f1163dad1893a1
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 16:00:20 2021 -0300

    Fix missing files from rebase

commit acfaec0df1c08c32907cb05093fd2b23ddf2dbcb
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 14:15:41 2021 -0300

    Add a variable to control the execution flow

commit d10d1916c3cf7777029b4803f2d86045799a6da6
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 14:15:19 2021 -0300

    Add a method to reset the statement to its original condition

commit ec0319c26d2c44e7f30855066e3212064e7f4d03
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 13:25:19 2021 -0300

    Fix checkstyle

commit 6bf3fdecf5f55e0715a354c09b89ec5407e14624
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 12:00:26 2021 -0300

    change parameter from string to char* on GetArrowType method

commit 4f0807a7eb8d99e363ce07e33364acc164621a89
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 12:00:03 2021 -0300

    Remove status from sqlite use

commit 05d6280326872b3f7f75bc51b8e8f91ef49979c1
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Oct 6 11:59:30 2021 -0300

    Move anonymous function to the top of file

commit d962a33462b2061e9926a540f016d761247fbec5
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Oct 5 16:04:37 2021 -0300

    Fix checkstyle

commit 9f90bdec11c5827d6ac790f5345a2707b5d1b9a5
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Oct 5 16:01:52 2021 -0300

    Refactor constructor from the class sqlite_tables_schema_batch_reader

commit 61af7d444e635855fe0854dfba49d26cf75f38ac
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Oct 5 16:01:22 2021 -0300

    Fix import order

commit 5e2071c84e3775f09814548655986456bd257f1a
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Oct 5 16:01:11 2021 -0300

    Decouple method PrepareQueryForGetTables from the class

commit 449938b94b5b1d4ba241ec31ad57ee3ab91aee15
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Oct 5 16:00:16 2021 -0300

    Remove extra space

commit e5ea5eba96bb9fbce298454441cd2d62cd7a1b7c
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 1 18:15:41 2021 -0300

    Pass the query to the batch reader vector for the table with schemas

commit abe5af8dd3412531a46aa35fa03d02b78200481f
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 1 18:15:14 2021 -0300

    Invert order of vector on tests

commit 4a99053103e53a08c6f8398d3473351ea8f450b2
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Oct 1 18:14:15 2021 -0300

    Add method prepareQuery

commit bd19a660f588e6a4e17907a6ff972e05407aa0cf
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 16:45:24 2021 -0300

    Fix checkstyle

commit 9a838a9dd04279526b5b3d25b683556f0526b6c6
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 16:44:07 2021 -0300

    Update CMakeLists.txt

commit 574878f2e7cec50658b19fd3668a0755795d8769
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 16:43:57 2021 -0300

    Set values from catalogs and schema as null

commit 0aa1cab6dd1743d59ed5f9252b7fc3cd54649e4e
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 16:43:41 2021 -0300

    Modify Macro from builder to deal with null values

commit b8d8396a1b2585d4f02895c91a850fe90d559550
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 15:39:52 2021 -0300

    change constructor initialization

commit 8e846c84631e6dcf2dce99d129e8b788c12aae57
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 15:39:18 2021 -0300

    Fix checkstyle

commit 60b8326c29411d709dcf43b4b2aca9277d8baa99
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 15:09:11 2021 -0300

    Add more test for the GetTables

commit 5bc0e9f2449cad3f128a936194682c7e52f9b8cf
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 15:08:57 2021 -0300

    Add a DECLARE_BINARY_ARRAY for testing

commit 01266d72b56edc38071b83bfcabc8257be277cfc
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 15:08:23 2021 -0300

    Add table type filter to the query

commit 8a02752d9f1ef897937e0c48f98c42213f2f8672
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 15:07:45 2021 -0300

    Refactor methods that parse the table type to field type

commit a0f32ba9ab4bf390110d772c353592f018d5f692
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 30 09:59:53 2021 -0300

    Refactor test from GetTables

commit 8a3dc6d8e20cf8826849453607dae92b83d6050d
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Sep 29 11:28:54 2021 -0300

    Add new tests to GetTables

commit aef712a73a4640c76088e08cd8ca339b934e16e0
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Sep 29 11:28:41 2021 -0300

    Add new filter to the query on GetTables

commit 814dc10579876ef44017a9bb74eec0efef224fd7
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Sep 29 11:28:23 2021 -0300

    Refactor the name of class sqlite table schema batch reader

commit 7d53dd6a3343569fca9279e9968c5f7678895fcc
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Sep 28 16:09:39 2021 -0300

    Add class to tge CMakeLists.txt

commit 86a0ba0b3d1a186dab33c48ffedaa1ebbbcfbf63
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Sep 28 16:09:27 2021 -0300

    Add the schemas to be used by the GetTabkes

commit 6b6d9c2b9bc13d2a46b13dce81f9f16f723fbaf8
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Sep 28 16:09:09 2021 -0300

    Include methods GetTablesFlightInfo and DoGetTables

commit 203e64f1116072e06874430be839832824965f04
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Sep 28 16:08:46 2021 -0300

    Create a class to deal the DoGetTables when schema is included

commit cac2d9fb56408e223be9ea0ca76582e57a0f2223
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Oct 6 15:11:16 2021 -0300

    Fix style issues

commit c750b15a1c1d7543517f82bb3fe2594ad06d9e5b
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Oct 6 15:11:16 2021 -0300

    Fix style issues

commit b22fe92358cc1a8c5d7342ae0fda7101fbd00d19
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Sep 30 11:14:06 2021 -0300

    Undo unscoped changes to other files

commit e68f6e689d366a3b2299f7c3d7e948de724735d7
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Sep 29 17:16:52 2021 -0300

    Implement CommandGetSchemas

commit f1d9f9da9d297c8e17979623d32f6aeec95de654
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Sep 30 15:39:43 2021 -0300

    Fix checkstyle errors

commit 2fdc7c84cdfc1236baaf1f2fb478e6c8048d260f
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Sep 30 13:17:10 2021 -0300

    Fix problem when linking protobuf to flight-sql targets

commit 5e57cd15cb480bbd6f743009a6a763c8a8e26f0b
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Oct 5 13:14:55 2021 -0300

    Implement CommandGetSchemas

commit b8f5dda429b7aebbcc936270d3123ff0cc27f27d
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Sep 29 17:42:15 2021 -0300

    Make GetCatalogs return empty results

commit a631b4f97f43f9f7074888c6b0e158df13bc93e5
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Sep 28 22:30:11 2021 -0300

    Add comment about hardcoded GetCatalogs implementation

commit d754fdec6fbd724c50c81024d3e00a8bd7bfcd9a
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Sep 28 19:06:10 2021 -0300

    Fix minor comments on PR

commit 060e9b45998512f53d30f072693194a00c53e104
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Sep 28 16:04:32 2021 -0300

    Refactor tests to reduce duplication

commit 7add18f4f40f7865298c31f7a3a523be2e191f9e
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Sep 28 15:07:40 2021 -0300

    Implement CommandGetCatalogs

commit 5d3bc66c200abc30fd421ac7eb0c1c6bb87985cb
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Sep 28 16:30:11 2021 -0300

    Improve readability for SqliteFlightSqlServer setup

commit 68bec018bd9784327d27dc80b80c84e18077606c
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Sep 28 16:07:07 2021 -0300

    Fix minor comments on PR

commit 93c5a4ba70e2dd6b2083c8235255af095a3a703b
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Sep 28 14:27:29 2021 -0300

    Fix checkstyle errors

commit 2232dd67f3829aa61feea031809dad4543e75c21
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Sep 27 16:36:06 2021 -0300

    Add integration tests for Flight SQL server example

commit f7b6461ee156d05e602f4af287d1ae7be54794f2
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Sep 24 16:04:58 2021 -0300

    Add documentation to example classes

commit 3584fc07f7fd76ab46ab76215d609cb35d344c91
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Sep 24 15:42:35 2021 -0300

    Add missing sqlite3 dependency on vcpkg.json

commit 87fc8aae9cb0e5819dadc2f3a1ba394904f2acc2
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Sep 24 15:38:02 2021 -0300

    Implement Flight SQL example server using SQLite3

commit 9dd9a3216c735183039cd87fb9d077433fec17f1
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Sep 28 14:00:22 2021 -0300

    Change default Status return on GetFlightInfo and DoGet

commit 5bd548fb8f720397c1e7756151ac8c68190741c2
Author: Rafael Telles <rafael@telles.dev>
Date:   Fri Sep 24 15:35:25 2021 -0300

    Remove empty constructor and destructor from FlightSqlServerBase header

commit cffd1f4cbb5d9199bb47807e7fef131ac4359a7a
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Sep 24 15:20:36 2021 -0300

    Separate implementation from header file

commit 685ccd00406593a35ee4156004db5a4b9a499c03
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Thu Sep 23 11:38:27 2021 -0300

    Add missing else if on DoGet method

commit 4099ad21518a087ed818587be3e73ef84368398e
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Sep 22 15:16:52 2021 -0300

    Improve documentation on sql_server.h

commit 8aaee1edcf1e248bb62ec4c81e0ef52097879ec0
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Sep 22 14:29:16 2021 -0300

    Fix wrong arguments on server header file

commit 5f7a4c81195c7bf688e1f82cef8781f7299d89d0
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Sep 22 14:13:36 2021 -0300

    Implement missing branches on DoGet

commit c5d63016cf700fdd3bcd3526011608ac0482c652
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Sep 22 14:11:58 2021 -0300

    Add more statement to the getFlightInfo methods

commit a25bb904c90726473816ba9d6fc11be1441e111c
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Sep 22 14:00:27 2021 -0300

    Remove doPut* methods (not used yet)

commit eeb4a3531d607d9a57513a04ec98c5282e7cc681
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Sep 22 13:56:52 2021 -0300

    Remove flight-sql from CMakeLists.txt

commit 03425db52435102f9fa40e20da3d497c4d0410f8
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Wed Sep 22 13:52:52 2021 -0300

    Add flight-sql server header file

commit bf5cfeff437e045cbf38945c82f64bcb8fbc5f2f
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Sep 20 15:25:42 2021 -0300

    Change ExecuteUpdate output argument to raw pointer instead of unique_ptr<int64_t>

commit bd2890ee117d64bca9856b3705eadd4eecd95274
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Sep 17 16:24:24 2021 -0300

    Change order of call from ExecuteUpdate on test_app.cc

commit 5e11c8243312d6c1dc7cb4723ada6f2cff739940
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Sep 17 16:11:47 2021 -0300

    Checkstyle fix on flight-sql

commit 59e1c2897fc2adb0891072faad09c92745bb18c5
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Sep 17 16:11:36 2021 -0300

    Change order of output parameters on methods from flight-sql

commit 7aa4c14425b5b2628e16488166dcd9fe762454be
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Fri Sep 17 16:09:25 2021 -0300

    Change rows on executeUpdate to a unique_ptr

commit 015d015ea7da2f8347c63b76c55768656b8d8f27
Author: Rafael Telles <rafael@telles.dev>
Date:   Thu Sep 16 10:30:27 2021 -0300

    Refactor client_impl to reduce duplication on FlightDescriptor build

commit 83db0122781b94c23557837661a27659ae8e4af7
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Sep 14 16:56:07 2021 -0300

    Create a mock test for execute_update method on sql_client

commit e078c057148c9ed91176036485e7c4a8363fb779
Author: Jose Almeida <almeidajcr90@gmail.com>
Date:   Tue Sep 14 16:55:50 2021 -0300

    Implement executeUpdate logic on sql client

commit 69dbdecccf977d6b3a6fb33a76047ab368af546e
Author: Rafael Telles <rafael@telles.dev>
Date:   Wed Sep 15 19:33:25 2021 -0300

    [C++] Implement Flight SQL client test application (#121)

    * Implement Flight SQL client test application

    * Adjust PrintResults to consider multiple endpoints

    * Remove mentions to Dremio

    * Minor fix

    * Sort 'using' statements on test_app.cc

    * Transfer ownership of FLightClient to FlightSqlClient on constructor

    * Use reference instead of pointers on PrintResults

    * Make client methods to be const

commit fde5c0022594146b971a635c337616ffe86e5bd1
Author: Jose Almeida <53087160+jcralmeida@users.noreply.github.com>
Date:   Tue Sep 14 11:42:48 2021 -0300

    [C++] Implements methods from flight-sql-client  (#120)

    * add a header file to the sql-client

    * Implements methods from sql-client

    * Add configuration files to the flight-sql

    * Change getFlightInfo to virtual and its constructor to protected

    * Create a mock test for getCatalogs

    * Remove unused test from CMakeLists.txt

    * Fix checkstyle on flight-sql files

    * Fix duplicate tests execution

    * Add test for getSchema from flightsql

    * Update flight headers and implements getTable and getTableTypes

    * Add other unit tests for metadata methods

    * Fix checkstyle errors

    * Implement missing methods GetPrimaryKeys, GetImportedKeys and GetExportedKeys

    * Refactor flight-sql/client.cc implementation

    * Remove unimplemented ExecuteUpdate test

    * Add google/protobuf/message include to flight-sql-client

    * Undo changes on flight/client.h and use templates for mocking FlightClient on FlightSqlClient

    * Use string references where parameters can not be null

    * Reorder FlightSqlClient method arguments

    * Avoid needing to use diamond syntax on FlightSqlClient

    Co-authored-by: Rafael Telles <rafael@telles.dev>

commit f3fe962c5838c345589320d7c559526650e87cde
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Sep 6 11:37:08 2021 -0300

    Fix checkstyle issues

commit 2ed7b0efae2a6128f13920ed4e18d6d7d7f0d803
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Aug 24 14:12:37 2021 -0300

    WIP: Clean up changes

commit 7dc836e789b390297e191471e4aa142386bf793b
Author: Rafael Telles <rafael@telles.dev>
Date:   Tue Aug 24 13:49:32 2021 -0300

    Update FindArrowFlightSql.cmake

commit 370c92ef1d9748feef8c61e2b19515a558124939
Author: Rafael Telles <rafael@telles.dev>
Date:   Mon Aug 23 15:28:53 2021 -0300

    WIP: Set up flight-sql project on cpp directory
@rafael-telles @lidavidm
ARROW-15112: [Integration][C++][Java] Implement Flight SQL integratio…
16a9df1 
…n tests

This adds Flight SQL scenarios for integration tests for C++ and Java implementations.
The integrations tests assert that:
- RPC objects built on clients are parsed correctly on servers
- Arrow vectors built on servers have the expected Arrow schemas when received on clients

Note: Had to separate integration tests in a new module within Java and C++ to avoid circular dependencies (Flight <-> Flight SQL)

While working on this I found some inconsistencies between both implementation, this PR also fixes these problems.

Closes #11989 from rafael-telles/flight-sql-integration-tests-2

Authored-by: Rafael Telles <rafael@telles.dev>
Signed-off-by: David Li <li.davidm96@gmail.com>
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-14421

@lidavidm lidavidm mentioned this pull request Dec 21, 2021
Closed
@lidavidm
Copy link
Member Author

This will need some wrangling when merged to ensure all the authors are preserved properly.

@rafael-telles
Copy link
Contributor

Thanks @lidavidm ! :)

@lidavidm
Copy link
Member Author

I'm asking around about the dev pipeline failures just to make sure of what's going on before proceeding.

@lidavidm lidavidm mentioned this pull request Dec 22, 2021
Closed
@rafael-telles @lidavidm
ARROW-15187: [Java][FlightRPC] Fix pom.xml for Flight integration tests
dc3f919 
Closes #12021 from lidavidm/flight-sql-pom

Lead-authored-by: Rafael Telles <rafael@telles.dev>
Co-authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm
Copy link
Member Author

FYI, this is the list of authors I plan to credit when merging, pulled out of Git (since the commits will be squashed):

Rafael Telles
Abner Eduardo Ferreira
Kyle Porter
Jose Almeida
Juscelino Junior
Ryan Nicholson
tifflhl
Vinicius Fraga

Please let me know if there's anyone else that should be credited or if I should update or correct any names. Thanks! (We need Name <email>, same format as Git)

@rafael-telles
Copy link
Contributor

rafael-telles commented Dec 22, 2021 •
edited
Loading

Thanks @lidavidm !
Please include James Duong <duong.james@gmail.com> (@jduo) in this list :)

@lidavidm
Copy link
Member Author

Kicked the docs build (though it looks unrelated to what's happening here).

@lidavidm
Copy link
Member Author

@github-actions crossbow submit -g nightly

@github-actions
Copy link

Revision: dc3f919

Submitted crossbow builds: ursacomputing/crossbow @ actions-1346

Task Status
almalinux-8-amd64 Github Actions
almalinux-8-arm64 TravisCI
amazon-linux-2-amd64 Github Actions
centos-7-amd64 Github Actions
conda-clean Azure
conda-linux-gcc-py36-cpu-r40 Azure
conda-linux-gcc-py36-cuda Azure
conda-osx-arm64-clang-py38 Azure
conda-osx-arm64-clang-py39 Azure
conda-osx-clang-py36-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-osx-clang-py38 Azure
conda-osx-clang-py39 Azure
conda-win-vs2017-py36-r40 Azure
debian-bookworm-amd64 Github Actions
debian-bookworm-arm64 TravisCI
debian-bullseye-amd64 Github Actions
debian-bullseye-arm64 TravisCI
debian-buster-amd64 Github Actions
debian-buster-arm64 TravisCI
example-cpp-minimal-build-static Github Actions
example-cpp-minimal-build-static-system-dependency Github Actions
homebrew-cpp Github Actions
homebrew-r-autobrew Github Actions
java-jars Github Actions
nuget Github Actions
python-sdist Github Actions
test-build-cpp-fuzz Github Actions
test-build-vcpkg-win Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-conda-python-3.10 Github Actions
test-conda-python-3.6 Github Actions
test-conda-python-3.6-pandas-0.23 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-kartothek-latest Github Actions
test-conda-python-3.7-kartothek-master Github Actions
test-conda-python-3.7-pandas-0.24 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-v3.1.2 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-v3.2.0 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-dask-latest Github Actions
test-conda-python-3.9-dask-master Github Actions
test-conda-python-3.9-pandas-master Github Actions
test-conda-python-3.9-spark-master Github Actions
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-debian-11-go-1.16 Azure
test-debian-11-python-3 Azure
test-debian-c-glib Github Actions
test-debian-ruby Github Actions
test-fedora-33-cpp Github Actions
test-fedora-33-python-3 Azure
test-fedora-r-clang-sanitizer Azure
test-r-arrow-backwards-compatibility Github Actions
test-r-depsource-bundled Azure
test-r-depsource-system Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-install-local Github Actions
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-offline-maximal Github Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rocker-r-base-latest Azure
test-r-rstudio-r-base-4.1-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-4.1-centos8 Azure
test-r-rstudio-r-base-4.1-focal Azure
test-r-rstudio-r-base-4.1-opensuse15 Azure
test-r-rstudio-r-base-4.1-opensuse42 Azure
test-r-ubuntu-21.04 Github Actions
test-r-versions Github Actions
test-skyhook-integration Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-18.04-python-3 Azure
test-ubuntu-18.04-r-sanitizer Azure
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-14 Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-c-glib Github Actions
test-ubuntu-default-docs Azure
test-ubuntu-ruby Github Actions
ubuntu-bionic-amd64 Github Actions
ubuntu-bionic-arm64 TravisCI
ubuntu-focal-amd64 Github Actions
ubuntu-focal-arm64 TravisCI
ubuntu-hirsute-amd64 Github Actions
ubuntu-hirsute-arm64 TravisCI
ubuntu-impish-amd64 Github Actions
ubuntu-impish-arm64 TravisCI
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions
wheel-macos-high-sierra-cp310-amd64 Github Actions
wheel-macos-high-sierra-cp36-amd64 Github Actions
wheel-macos-high-sierra-cp37-amd64 Github Actions
wheel-macos-high-sierra-cp38-amd64 Github Actions
wheel-macos-high-sierra-cp39-amd64 Github Actions
wheel-macos-mavericks-cp310-amd64 Github Actions
wheel-macos-mavericks-cp36-amd64 Github Actions
wheel-macos-mavericks-cp37-amd64 Github Actions
wheel-macos-mavericks-cp38-amd64 Github Actions
wheel-macos-mavericks-cp39-amd64 Github Actions
wheel-manylinux2010-cp310-amd64 Github Actions
wheel-manylinux2010-cp36-amd64 Github Actions
wheel-manylinux2010-cp37-amd64 Github Actions
wheel-manylinux2010-cp38-amd64 Github Actions
wheel-manylinux2010-cp39-amd64 Github Actions
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 TravisCI
wheel-manylinux2014-cp36-amd64 Github Actions
wheel-manylinux2014-cp36-arm64 TravisCI
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 TravisCI
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 TravisCI
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 TravisCI
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp36-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@lidavidm
Copy link
Member Author

lidavidm commented Dec 23, 2021 •
edited
Loading

Ok! A few last things.

There's a failure with the unity build enabled. Looks like we have to explicitly state arrow::Result (since there's also flight::Result).

The rest of these I need to dig into more:

Error: Failed to execute goal pl.project13.maven:git-commit-id-plugin:2.2.2:revision (for-jars) on project arrow-java-root: Could not complete Mojo execution... Unable to find commits until some tag: Walk failure. Missing commit 16a9df1 -> [Help 1]

Not sure what Maven is going on about here. The commit is part of this branch... I need to look more into this.

EDIT: nightly fails the same way. So I don't think it's a problem here.

There's also some failures due to ARROW-15181. I'll try to get a patch up soon, since it seems the flight-sql tests are more prone to this.

@rafael-telles
Copy link
Contributor

Thanks @lidavidm ! Looks like there is only one place we didn't explicitly use arrow::Result, this patch should fix it:

diff --git a/cpp/src/arrow/flight/sql/example/sqlite_statement_batch_reader.cc b/cpp/src/arrow/flight/sql/example/sqlite_statement_batch_reader.cc
index a5824ae255..08a03c4ca6 100644
--- a/cpp/src/arrow/flight/sql/example/sqlite_statement_batch_reader.cc
+++ b/cpp/src/arrow/flight/sql/example/sqlite_statement_batch_reader.cc
@@ -93,8 +93,8 @@ SqliteStatementBatchReader::SqliteStatementBatchReader(
       rc_(SQLITE_OK),
       already_executed_(false) {}
 
-Result<std::shared_ptr<SqliteStatementBatchReader>> SqliteStatementBatchReader::Create(
-    const std::shared_ptr<SqliteStatement>& statement_) {
+arrow::Result<std::shared_ptr<SqliteStatementBatchReader>>
+SqliteStatementBatchReader::Create(const std::shared_ptr<SqliteStatement>& statement_) {
   ARROW_RETURN_NOT_OK(statement_->Step());
 
   ARROW_ASSIGN_OR_RAISE(auto schema, statement_->GetSchema());

Do you prefer I open another PR for this?

@lidavidm
Copy link
Member Author

Yeah, do you mind opening a quick PR?

@rafael-telles
Copy link
Contributor

Sure! Just opened #12035

@rafael-telles @lidavidm
ARROW-15198: [C++][FlightRPC] Fix conda-python-hdfs build error on fl…
31fb76c 
…ight-sql branch

This should fix Crossbow build `conda-python-hdfs` on `flight-sql`:
https://github.com/ursacomputing/crossbow/runs/4612261742?check_suite_focus=true

Using `arrow::Result` on `SqliteStatementBatchReader::Create` to avoid confusing with `arrow::flight::Result`.

Closes #12035 from rafael-telles/flight-sql-fix-conda-python-hdfs-build

Authored-by: Rafael Telles <rafael@telles.dev>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm
Copy link
Member Author

@github-actions crossbow submit -g nightly

@github-actions
Copy link

Revision: 31fb76c

Submitted crossbow builds: ursacomputing/crossbow @ actions-1348

Task Status
almalinux-8-amd64 Github Actions
almalinux-8-arm64 TravisCI
amazon-linux-2-amd64 Github Actions
centos-7-amd64 Github Actions
conda-clean Azure
conda-linux-gcc-py36-cpu-r40 Azure
conda-linux-gcc-py36-cuda Azure
conda-osx-arm64-clang-py38 Azure
conda-osx-arm64-clang-py39 Azure
conda-osx-clang-py36-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-osx-clang-py38 Azure
conda-osx-clang-py39 Azure
conda-win-vs2017-py36-r40 Azure
debian-bookworm-amd64 Github Actions
debian-bookworm-arm64 TravisCI
debian-bullseye-amd64 Github Actions
debian-bullseye-arm64 TravisCI
debian-buster-amd64 Github Actions
debian-buster-arm64 TravisCI
example-cpp-minimal-build-static Github Actions
example-cpp-minimal-build-static-system-dependency Github Actions
homebrew-cpp Github Actions
homebrew-r-autobrew Github Actions
java-jars Github Actions
nuget Github Actions
python-sdist Github Actions
test-build-cpp-fuzz Github Actions
test-build-vcpkg-win Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-conda-python-3.10 Github Actions
test-conda-python-3.6 Github Actions
test-conda-python-3.6-pandas-0.23 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-kartothek-latest Github Actions
test-conda-python-3.7-kartothek-master Github Actions
test-conda-python-3.7-pandas-0.24 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-v3.1.2 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-v3.2.0 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-dask-latest Github Actions
test-conda-python-3.9-dask-master Github Actions
test-conda-python-3.9-pandas-master Github Actions
test-conda-python-3.9-spark-master Github Actions
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-debian-11-go-1.16 Azure
test-debian-11-python-3 Azure
test-debian-c-glib Github Actions
test-debian-ruby Github Actions
test-fedora-33-cpp Github Actions
test-fedora-33-python-3 Azure
test-fedora-r-clang-sanitizer Azure
test-r-arrow-backwards-compatibility Github Actions
test-r-depsource-bundled Azure
test-r-depsource-system Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-install-local Github Actions
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-offline-maximal Github Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rocker-r-base-latest Azure
test-r-rstudio-r-base-4.1-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-4.1-centos8 Azure
test-r-rstudio-r-base-4.1-focal Azure
test-r-rstudio-r-base-4.1-opensuse15 Azure
test-r-rstudio-r-base-4.1-opensuse42 Azure
test-r-ubuntu-21.04 Github Actions
test-r-versions Github Actions
test-skyhook-integration Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-18.04-python-3 Azure
test-ubuntu-18.04-r-sanitizer Azure
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-14 Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-c-glib Github Actions
test-ubuntu-default-docs Azure
test-ubuntu-ruby Github Actions
ubuntu-bionic-amd64 Github Actions
ubuntu-bionic-arm64 TravisCI
ubuntu-focal-amd64 Github Actions
ubuntu-focal-arm64 TravisCI
ubuntu-hirsute-amd64 Github Actions
ubuntu-hirsute-arm64 TravisCI
ubuntu-impish-amd64 Github Actions
ubuntu-impish-arm64 TravisCI
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions
wheel-macos-high-sierra-cp310-amd64 Github Actions
wheel-macos-high-sierra-cp36-amd64 Github Actions
wheel-macos-high-sierra-cp37-amd64 Github Actions
wheel-macos-high-sierra-cp38-amd64 Github Actions
wheel-macos-high-sierra-cp39-amd64 Github Actions
wheel-macos-mavericks-cp310-amd64 Github Actions
wheel-macos-mavericks-cp36-amd64 Github Actions
wheel-macos-mavericks-cp37-amd64 Github Actions
wheel-macos-mavericks-cp38-amd64 Github Actions
wheel-macos-mavericks-cp39-amd64 Github Actions
wheel-manylinux2010-cp310-amd64 Github Actions
wheel-manylinux2010-cp36-amd64 Github Actions
wheel-manylinux2010-cp37-amd64 Github Actions
wheel-manylinux2010-cp38-amd64 Github Actions
wheel-manylinux2010-cp39-amd64 Github Actions
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 TravisCI
wheel-manylinux2014-cp36-amd64 Github Actions
wheel-manylinux2014-cp36-arm64 TravisCI
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 TravisCI
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 TravisCI
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 TravisCI
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp36-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@rafael-telles
Copy link
Contributor

Took a look on these failures but they all seem unrelated to Flight SQL, beside the ARROW-15181 one.
Please let me know if there is anything else and I will try to solve as soon as possible.

@lidavidm
Copy link
Member Author

Agreed, that's what I'm seeing as well. The PR for ARROW-15181 is up at #12037. I'll merge this now, thanks to everyone for all their work here!

@lidavidm lidavidm closed this in 968e6ea Dec 23, 2021
@ursabot
Copy link

ursabot commented Dec 23, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = e60e6b0 and contender = 968e6ea. 968e6ea is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] ursa-i9-9960x
[Failed ⬇️0.09% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@rafael-telles
Copy link
Contributor

Thank you so much @lidavidm ! That's a very good way of ending 2021 for us :)
Happy holidays! 🥳

@lidavidm lidavidm deleted the flight-sql branch March 30, 2022 21:05
This was referenced Sep 13, 2022
Closed
Closed
Closed
Closed
Closed
@jorisvandenbossche jorisvandenbossche mentioned this pull request Feb 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: C++ Component: FlightRPC Component: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidavidm @rafael-telles @ursabot