ARROW-15198: [C++][FlightRPC] Fix conda-python-hdfs build error on flight-sql branch #12035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using with arrow::flight::Result
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
|
@github-actions crossbow submit test-conda-python-3.7-hdfs-3.2.1 test-conda-python-3.7-hdfs-2.9.2 |
lidavidm
changed the title
|
Revision: 966c434 Submitted crossbow builds: ursacomputing/crossbow @ actions-1347
|
lidavidm
pushed a commit
that referenced
this pull request
Dec 23, 2021
…ight-sql branch This should fix Crossbow build `conda-python-hdfs` on `flight-sql`: https://github.com/ursacomputing/crossbow/runs/4612261742?check_suite_focus=true Using `arrow::Result` on `SqliteStatementBatchReader::Create` to avoid confusing with `arrow::flight::Result`. Closes #12035 from rafael-telles/flight-sql-fix-conda-python-hdfs-build Authored-by: Rafael Telles <rafael@telles.dev> Signed-off-by: David Li <li.davidm96@gmail.com>
lidavidm
pushed a commit
that referenced
this pull request
Dec 23, 2021
Implement Flight SQL in C++ and Java, and add the protocol definitions. This is a combination of multiple pull requests, merged into one branch before merging into master. Closes #10906 (ARROW-12922). Closes #11507 (ARROW-14421). Closes #11989 (ARROW-15112). Closes #12021 (ARROW-15187). Closes #12035 (ARROW-15198). Closes #12013 from apache/flight-sql Lead-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: Abner Eduardo Ferreira <abenaru@protonmail.ch> Co-authored-by: James Duong <duong.james@gmail.com> Co-authored-by: Jose Almeida <almeidajcr90@gmail.com> Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Kyle Porter <kporter@dremio.com> Co-authored-by: Ryan Nicholson <rnicholson@dremio.com> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: tifflhl <tiffanylamhl@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix Crossbow build
conda-python-hdfsonflight-sql:https://github.com/ursacomputing/crossbow/runs/4612261742?check_suite_focus=true
Using
arrow::ResultonSqliteStatementBatchReader::Createto avoid confusing witharrow::flight::Result.