Skip to content

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Jan 16, 2023

DurationType was missing in the function to register the hash-based kernels (unique, dictionary_encode, etc)

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #15226 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @jorisvandenbossche

@pitrou pitrou merged commit 4d9228f into apache:master Jan 16, 2023
@jorisvandenbossche jorisvandenbossche deleted the gh-15226-duration-dict branch January 16, 2023 11:01
@jbrockmendel
Copy link

does this handle value_counts?

@jorisvandenbossche
Copy link
Member Author

Yes, it's for unique, value_counts and dictionary_encode

@ursabot
Copy link

ursabot commented Jan 16, 2023

Benchmark runs are scheduled for baseline = 7e6bcd1 and contender = 4d9228f. 4d9228f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.45% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.19% ⬆️0.06%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4d9228fd ec2-t3-xlarge-us-east-2
[Finished] 4d9228fd test-mac-arm
[Finished] 4d9228fd ursa-i9-9960x
[Finished] 4d9228fd ursa-thinkcentre-m75q
[Finished] 7e6bcd1b ec2-t3-xlarge-us-east-2
[Finished] 7e6bcd1b test-mac-arm
[Finished] 7e6bcd1b ursa-i9-9960x
[Finished] 7e6bcd1b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] dictionary_encode support duration types

4 participants