ARROW-4612: [Python] Use cython from PyPI for windows wheels build #3684
Conversation
| @@ -72,6 +72,9 @@ pushd %ARROW_SRC%\python | |||
| set PYARROW_BUILD_TYPE=Release | |||
| set SETUPTOOLS_SCM_PRETEND_VERSION=%PYARROW_VERSION% | |||
|
|
|||
| @rem Newer Cython versions are not available on conda-forge | |||
There was a problem hiding this comment.
Can you comment why it's important to get the newer Cython versions?
There was a problem hiding this comment.
We rely on certain fixes that are part of the latest Cython version and changed our pinning to >=0.29 some time ago. This then sadly broke the windows wheels build. The main problem here is not actually that we want a newer Cython but that since some time conda-forge no longer builds packages for Python 3.5.
There was a problem hiding this comment.
Then perhaps pip install Cython or pip install -U Cython (if it's already installed) is better than explicit pinning of a given version?
There was a problem hiding this comment.
I changed it to >=0.29 as I don't want to use -U.
|
I suppose these are the passing builds: https://github.com/xhochy/crossbow/branches/all?utf8=%E2%9C%93&query=build-35 |
|
@kszucs Yes, they are! |
|
Note that these changes won't take effect during the 0.12.1 release unless You cherry pick this commit as well. |
|
I think we need these as otherwise we won't have a Windows wheel. |
Crossbow builds: * https://ci.appveyor.com/project/xhochy/crossbow/builds/22453994 * https://ci.appveyor.com/project/xhochy/crossbow/builds/22453998 Author: Uwe L. Korn <uwelk@xhochy.com> Closes #3684 from xhochy/ARROW-4612 and squashes the following commits: ef3badf <Uwe L. Korn> Use newer pip version b1b8fa1 <Uwe L. Korn> Change cython pin to lower bound 82c2be0 <Uwe L. Korn> ARROW-4612: Use cython from PyPI for windows wheels build
Crossbow builds: * https://ci.appveyor.com/project/xhochy/crossbow/builds/22453994 * https://ci.appveyor.com/project/xhochy/crossbow/builds/22453998 Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#3684 from xhochy/ARROW-4612 and squashes the following commits: ef3badf <Uwe L. Korn> Use newer pip version b1b8fa1 <Uwe L. Korn> Change cython pin to lower bound 82c2be0 <Uwe L. Korn> ARROW-4612: Use cython from PyPI for windows wheels build
Crossbow builds: