Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4612: [Python] Use cython from PyPI for windows wheels build #3684

Closed
wants to merge 3 commits into from
Closed

ARROW-4612: [Python] Use cython from PyPI for windows wheels build #3684

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82c2be0
ARROW-4612: [Python] Use cython from PyPI for windows wheels build
xhochy Feb 18, 2019
b1b8fa1
Change cython pin to lower bound
xhochy Feb 18, 2019
ef3badf
Use newer pip version
xhochy Feb 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dev/tasks/python-wheels/win-build.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
conda update --yes --quiet conda

conda create -n arrow -q -y python=%PYTHON% ^
six pytest setuptools numpy=%NUMPY% pandas cython
six pytest setuptools numpy=%NUMPY% pandas

conda install -n arrow -q -y -c conda-forge ^
git flatbuffers rapidjson ^
Expand Down Expand Up @@ -72,6 +72,10 @@ pushd %ARROW_SRC%\python
set PYARROW_BUILD_TYPE=Release
set SETUPTOOLS_SCM_PRETEND_VERSION=%PYARROW_VERSION%

@rem Newer Cython versions are not available on conda-forge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment why it's important to get the newer Cython versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We rely on certain fixes that are part of the latest Cython version and changed our pinning to >=0.29 some time ago. This then sadly broke the windows wheels build. The main problem here is not actually that we want a newer Cython but that since some time conda-forge no longer builds packages for Python 3.5.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then perhaps pip install Cython or pip install -U Cython (if it's already installed) is better than explicit pinning of a given version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to >=0.29 as I don't want to use -U.

pip install -U pip
pip install "Cython>=0.29"

python setup.py build_ext ^
--with-parquet ^
--with-static-boost ^
Expand Down