Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing JS changes for arrow 16 #41261

Closed
wants to merge 5 commits into from

Conversation

domoritz
Copy link
Member

Here are some changes that were tagged for Arrow 16 that we would like to get in. I cheery picked the commits just to make it easier for you to see.

mbostock and others added 5 commits April 17, 2024 12:40
Merge after apache#40892.

This pull request also changes Dates to return timestamps instead of
Date instances (similar to Timestamps and for the same reason.

* GitHub Issue: apache#40959
Simpler version of apache#40712 that
preserves `get`.
* GitHub Issue: apache#39131
* use `node:` prefix for node imports
* remove `import` for types where it makes sense

* Closes: apache#39482
* GitHub Issue: apache#39482

---------

Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
@domoritz domoritz requested a review from raulcd April 17, 2024 16:53
@domoritz domoritz requested a review from trxcllnt as a code owner April 17, 2024 16:53
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@domoritz
Copy link
Member Author

Too late for the release. Will try to get these into 16.1.

@domoritz domoritz closed this Apr 17, 2024
@domoritz domoritz deleted the dom/arrow-js-16 branch April 17, 2024 22:56
@domoritz domoritz removed the awaiting committer review Awaiting committer review label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants