Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-42208: [Java] Fix the Test in flight-sql-jdbc-driver Module #42217

Merged
merged 1 commit into from
Jun 20, 2024
Merged

GH-42208: [Java] Fix the Test in flight-sql-jdbc-driver Module #42217

merged 1 commit into from
Jun 20, 2024

Conversation

llama90
Copy link
Contributor

@llama90 llama90 commented Jun 20, 2024 •
edited by github-actions bot
Loading

Rationale for this change

Adjust assertion message order for JUnit 5 compatibility.

What changes are included in this PR?

  • Reordering the arguments of assertEquals(expected, actual, message)

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@llama90 llama90 requested a review from lidavidm as a code owner June 20, 2024 09:52
@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #42208 has been automatically assigned in GitHub to PR creator.

@llama90
Copy link
Contributor Author

llama90 commented Jun 20, 2024

@vibhatha Could you execute @github-actions crossbow submit java-jars?

I found the reason, it was the wrong order of arguments in assertEquals. However, I couldn't figure out why it occurs intermittently at that time.

@vibhatha
Copy link
Collaborator

@github-actions crossbow submit java-jars

vibhatha
vibhatha reviewed Jun 20, 2024
View reviewed changes
...flight-sql-jdbc-driver/src/test/java/org/apache/arrow/driver/jdbc/ITDriverJarValidation.java
@@ -70,7 +70,7 @@ private static JarFile getJdbcJarFile() throws IOException {

assertNotNull(driverClassURL, "Driver jar was not detected in the classpath");
assertEquals(
"Driver jar was not detected in the classpath", "jar", driverClassURL.getProtocol());
"jar", driverClassURL.getProtocol(), "Driver jar was not detected in the classpath");
Copy link
Collaborator

@vibhatha vibhatha Jun 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are strings, so the IDE won't complaint, but how did we miss this in the CIs in the first place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'm curious about that too.

Actually, I have executed multiple mvn clean install commands to verify the changes. I never saw that message before merging the PR (to deal with the Flight Module) into the main branch. 🥲

Perhaps, I suspect that this workflow might be cached, similar to how the JNI workflow failed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably... It is fine, let's move forward. Thanks for quickly working on this fix.

@github-actions GitHub Actions
Copy link

Revision: 065c92a

Submitted crossbow builds: ursacomputing/crossbow @ actions-66f5fd63cd

Task Status
java-jars GitHub Actions

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jun 20, 2024
@lidavidm
Copy link
Member 

Error:    TestAceroSubstraitConsumer.testRunExtendedExpressionsProjectAndFilter:637 NullPointer Cannot invoke "org.apache.arrow.vector.ValueIterableVector.getValueIterable()" because "nameVector" is null

might be another thing to fix

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 20, 2024
@llama90
Copy link
Contributor Author

llama90 commented Jun 20, 2024 

Error:    TestAceroSubstraitConsumer.testRunExtendedExpressionsProjectAndFilter:637 NullPointer Cannot invoke "org.apache.arrow.vector.ValueIterableVector.getValueIterable()" because "nameVector" is null

might be another thing to fix

I checked the error, and it is caused by this PR. Can I open an issue and resolve it?

@vibhatha
Copy link
Collaborator

@llama90 I think that would be okay. It is more cleaner.
cc @lidavidm

This was referenced Jun 20, 2024
Open
Merged
@kou kou changed the title GH-42208: Fix the Test in flight-sql-jdbc-driver Module GH-42208: [Java] Fix the Test in flight-sql-jdbc-driver Module Jun 20, 2024
@lidavidm lidavidm merged commit 27bbc3c into apache:main Jun 20, 2024
21 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Jun 20, 2024
@lidavidm lidavidm mentioned this pull request Jun 21, 2024
Closed
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 27bbc3c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

@vibhatha vibhatha vibhatha approved these changes

Assignees
No one assigned
Labels
Component: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llama90 @vibhatha @lidavidm