Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-42224: [Java] Fix Typo in TestAceroSubstraitConsumer Test Method #42225

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

llama90
Copy link
Contributor

@llama90 llama90 commented Jun 20, 2024

Rationale for this change

Fixes a typo causing a NullPointerException in the test method

What changes are included in this PR?

  • Updating typo to fix Unit Test

Are these changes tested?

Yes

Are there any user-facing changes?

No.

@llama90 llama90 requested a review from lidavidm as a code owner June 20, 2024 16:47
Copy link

⚠️ GitHub issue #42224 has been automatically assigned in GitHub to PR creator.

@llama90
Copy link
Contributor Author

llama90 commented Jun 20, 2024

To verify this PR, I think we need to merge this PR.

@kou kou changed the title GH-42224: Fix Typo in TestAceroSubstraitConsumer Test Method GH-42224: [Java] Fix Typo in TestAceroSubstraitConsumer Test Method Jun 20, 2024
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase and then we can test

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 20, 2024
"Ch4IARIaL2Z1bmN0aW9uc19hcml0aG1ldGljLnlhbWwSERoPCAEaC2FkZDppM"
+ "zJfaTMyEhQaEggCEAEaDGNvbmNhdDp2Y2hhchoxChoaGBoEKgIQASIIGgYSBAoCEgAiBhoECgIoAhoTYWRkX3R3b190b19jb2x1"
+ "bW5fYRpGCi0aKwgBGgRiAhABIgoaCBIGCgQSAggBIgkaBwoFYgMgLSAiChoIEgYKBBICCAEaFWNvbmNhdF9jb2x1bW5fYV9hbmR"
"Ch4IARIaL2Z1bmN0aW9uc19hcml0aG1ldGljLnlhbWwSERoPCAEaC2FkZDppMzJfaTMyEhQaEggCEAEaDGNvbmNhdDp2Y2hhchoxChoaGBoEKgIQASIIGgYSBAoCEgAiBhoECgIoAhoTYWRkX3R3b190b19jb2x1bW5fYRpGCi0aKwgBGgRiAhABIgoaCBIGCgQSAggBIgkaBwoFYgMgLSAiChoIEgYKBBICCAEaFWNvbmNhdF9jb2x1bW5fYV9hbmR"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this diff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rolled back this! It's typo.

@lidavidm
Copy link
Member

@github-actions crossbow submit java-jars

Copy link

Revision: b7bc29f

Submitted crossbow builds: ursacomputing/crossbow @ actions-add4e3a312

Task Status
java-jars GitHub Actions

@llama90
Copy link
Contributor Author

llama90 commented Jun 21, 2024

@lidavidm I've just finished rebasing! You are so fast!

@lidavidm
Copy link
Member

Github notifies me on every push ^_^

@lidavidm lidavidm merged commit b71e71c into apache:main Jun 21, 2024
16 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Jun 21, 2024
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b71e71c.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants