ARROW-6142: [R] Install instructions on linux could be clearer #5027

nealrichardson · 2019-08-06T23:27:33Z

This updates the language in install_arrow() to follow the README revision that will land in https://github.com/apache/arrow/pull/4948/files#diff-563b2cb2c8c2d51b2ff6b177e2d84286R33.

The Jira ticket requested three things; this is #2 in the list. On #1, I defer to the C++ installation docs, which are already included in the install_arrow message, rather than duplicating content here. #3 is out of scope.

karldw · 2019-08-07T03:56:51Z

Thank you!

Other users who have the same question I asked in #1: the required packages to have a working R installation are libarrow-dev and libparquet-dev, but not any of the others.

kou · 2019-08-07T04:00:08Z

r/R/install-arrow.R

@@ -98,7 +98,8 @@ OR_SEE_DEV_GUIDE <- paste0(
 SEE_ARROW_INSTALL <- paste(
 "See the Apache Arrow project installation page",
 "<https://arrow.apache.org/install/>",
- "for how to install the C++ package from a PPA."
+ "to find pre-compiled binary packages for some common Linux distributions,",
+ "such as Debian, Ubuntu, CentOS, and Fedora."


We don't provide packages for Fedora yet...

Oops, I was blindly following #4948 (comment). Will revise.

nealrichardson · 2019-08-07T15:54:27Z

Thanks for the clarification @karldw, I misunderstood before. Will add reference to those two packages.

nealrichardson · 2019-08-07T18:54:01Z

Revised, PTAL

kou · 2019-08-07T21:34:52Z

r/R/install-arrow.R

- "for how to install the C++ package from a PPA."
+ "to find pre-compiled binary packages for some common Linux distributions,",
+ "including Debian, Ubuntu, and CentOS. You'll need to install 'libarrow-dev'",
+ "and 'libparquet-dev'."


libarrow-dev and libparquet-dev are right package names for Debian and Ubuntu.
But arrow-devel and parquet-devel are right package names for CentOS.

BTW, we can install only libparquet-dev or parquet-devel because libarrow-dev and arrow-devel are automatically installed as dependency.

Ok, revised accordingly.

kou

+1
We can merge this with a small fix. ("arrow" -> "Arrow")

Thanks!

kou · 2019-08-08T00:08:27Z

r/R/install-arrow.R

+ "to find pre-compiled binary packages for some common Linux distributions,",
+ "including Debian, Ubuntu, and CentOS. You'll need to install",
+ "'libparquet-dev' on Debian and Ubuntu, or 'parquet-devel' on CentOS. This",
+ "will also automatically install the arrow C++ library as a dependency."


Could you use "Arrow" instead of "arrow"?

kou · 2019-08-08T02:04:53Z

I'll merge this when CI is green.

nealrichardson · 2019-08-08T02:07:08Z

Here's my fork, which I'm guessing will finish faster: https://travis-ci.org/nealrichardson/arrow/jobs/569137979

codecov-io · 2019-08-08T02:19:19Z

Codecov Report

Merging #5027 into master will decrease coverage by 12.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #5027       +/-   ##
==========================================
- Coverage   87.33%   75.3%   -12.03%     
==========================================
  Files         895      57      -838     
  Lines      119946    3620   -116326     
  Branches     1418       0     -1418     
==========================================
- Hits       104751    2726   -102025     
+ Misses      14833     894    -13939     
+ Partials      362       0      -362

Impacted Files	Coverage Δ
r/R/install-arrow.R	`100% <ø> (ø)`	⬆️
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
go/arrow/memory/memory_avx2_amd64.go
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
cpp/src/parquet/column_scanner.cc
...p/src/gandiva/precompiled/epoch_time_point_test.cc
... and 829 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cfa7b3...80b142e. Read the comment docs.

kou · 2019-08-08T02:30:47Z

Thanks. CI is green. I'll merge this.

This updates the language in `install_arrow()` to follow the README revision that will land in https://github.com/apache/arrow/pull/4948/files#diff-563b2cb2c8c2d51b2ff6b177e2d84286R33. The [Jira ticket](https://issues.apache.org/jira/browse/ARROW-6142) requested three things; this is `#2` in the list. On `#1`, I defer to the C++ installation docs, which are already included in the install_arrow message, rather than duplicating content here. `#3` is out of scope. Closes apache#5027 from nealrichardson/no-ppa and squashes the following commits: 80b142e <Neal Richardson> s/arrow/Arrow/ 44c9659 <Neal Richardson> Tweak language again 36cfe28 <Neal Richardson> Further linux install revisions 79bd7e0 <Neal Richardson> One more PPurge 63f75bd <Neal Richardson> Revise install_arrow instructions for Linux Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>

This updates the language in `install_arrow()` to follow the README revision that will land in https://github.com/apache/arrow/pull/4948/files#diff-563b2cb2c8c2d51b2ff6b177e2d84286R33. The [Jira ticket](https://issues.apache.org/jira/browse/ARROW-6142) requested three things; this is `apache#2` in the list. On `apache#1`, I defer to the C++ installation docs, which are already included in the install_arrow message, rather than duplicating content here. `apache#3` is out of scope. Closes apache#5027 from nealrichardson/no-ppa and squashes the following commits: 80b142e <Neal Richardson> s/arrow/Arrow/ 44c9659 <Neal Richardson> Tweak language again 36cfe28 <Neal Richardson> Further linux install revisions 79bd7e0 <Neal Richardson> One more PPurge 63f75bd <Neal Richardson> Revise install_arrow instructions for Linux Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>

nealrichardson added 2 commits August 6, 2019 16:23

Revise install_arrow instructions for Linux

63f75bd

One more PPurge

79bd7e0

kou reviewed Aug 7, 2019

View reviewed changes

Further linux install revisions

36cfe28

kou reviewed Aug 7, 2019

View reviewed changes

Tweak language again

44c9659

kou approved these changes Aug 8, 2019

View reviewed changes

s/arrow/Arrow/

80b142e

kou closed this in 908b058 Aug 8, 2019

asfimport mentioned this pull request Aug 8, 2019

[R] Install instructions on linux could be clearer #22536

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARROW-6142: [R] Install instructions on linux could be clearer #5027

ARROW-6142: [R] Install instructions on linux could be clearer #5027

nealrichardson commented Aug 6, 2019 •

edited

Loading

karldw commented Aug 7, 2019

kou Aug 7, 2019

nealrichardson Aug 7, 2019

nealrichardson commented Aug 7, 2019

nealrichardson commented Aug 7, 2019

kou Aug 7, 2019

nealrichardson Aug 7, 2019

kou left a comment

kou Aug 8, 2019

nealrichardson Aug 8, 2019

kou commented Aug 8, 2019

nealrichardson commented Aug 8, 2019

codecov-io commented Aug 8, 2019

kou commented Aug 8, 2019

ARROW-6142: [R] Install instructions on linux could be clearer #5027

ARROW-6142: [R] Install instructions on linux could be clearer #5027

Conversation

nealrichardson commented Aug 6, 2019 • edited Loading

karldw commented Aug 7, 2019

kou Aug 7, 2019

Choose a reason for hiding this comment

nealrichardson Aug 7, 2019

Choose a reason for hiding this comment

nealrichardson commented Aug 7, 2019

nealrichardson commented Aug 7, 2019

kou Aug 7, 2019

Choose a reason for hiding this comment

nealrichardson Aug 7, 2019

Choose a reason for hiding this comment

kou left a comment

Choose a reason for hiding this comment

kou Aug 8, 2019

Choose a reason for hiding this comment

nealrichardson Aug 8, 2019

Choose a reason for hiding this comment

kou commented Aug 8, 2019

nealrichardson commented Aug 8, 2019

codecov-io commented Aug 8, 2019

Codecov Report

kou commented Aug 8, 2019

nealrichardson commented Aug 6, 2019 •

edited

Loading