Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-6142: [R] Install instructions on linux could be clearer #5027

Closed
wants to merge 5 commits into from
Closed

ARROW-6142: [R] Install instructions on linux could be clearer #5027

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63f75bd
Revise install_arrow instructions for Linux
nealrichardson Aug 6, 2019
79bd7e0
One more PPurge
nealrichardson Aug 6, 2019
36cfe28
Further linux install revisions
nealrichardson Aug 7, 2019
44c9659
Tweak language again
nealrichardson Aug 7, 2019
80b142e
s/arrow/Arrow/
nealrichardson Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions r/R/install-arrow.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ install_arrow_msg <- function(has_arrow, version, from_cran, os) {
# Point to compilation instructions on readme
msg <- c(SEE_DEV_GUIDE, THEN_REINSTALL)
} else {
# Suggest arrow.apache.org/install for PPAs, or compilation instructions
# Suggest arrow.apache.org/install, or compilation instructions
msg <- c(paste(SEE_ARROW_INSTALL, OR_SEE_DEV_GUIDE), THEN_REINSTALL)
}
} else if (!dev_version && !from_cran) {
Expand Down Expand Up @@ -98,7 +98,8 @@ OR_SEE_DEV_GUIDE <- paste0(
SEE_ARROW_INSTALL <- paste(
"See the Apache Arrow project installation page",
"<https://arrow.apache.org/install/>",
"for how to install the C++ package from a PPA."
"to find pre-compiled binary packages for some common Linux distributions,",
"such as Debian, Ubuntu, CentOS, and Fedora."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't provide packages for Fedora yet...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I was blindly following #4948 (comment). Will revise.

)

THEN_REINSTALL <- paste(
Expand Down
2 changes: 1 addition & 1 deletion r/tests/testthat/test-install-arrow.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ r_only({
test_that("Linux on release version gets pointed to PPA first, then C++", {
expect_match(
install_arrow_msg(FALSE, "0.13.0", os="linux"),
"PPA. Or, see the Arrow C++ developer guide",
"Fedora. Or, see the Arrow C++ developer guide",
fixed = TRUE
)
})
Expand Down