ARROW-590: [Integration][C++] Implement union types #6948
Closed
+206
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Based on PR #6934. |
pitrou
changed the title
pitrou
force-pushed
the
ARROW-590-union-integration
branch
from
ad9fe8f to
e4dd65c
Compare
Implement integration tests for sparse and dense unions. Enable them for C++ (only).
pitrou
force-pushed
the
ARROW-590-union-integration
branch
from
e4dd65c to
0646121
Compare
bkietz
approved these changes
Apr 15, 2020
Member
bkietz
left a comment
bkietz
left a comment
There was a problem hiding this comment.
LGTM
just a trivial typo we could fix later
Co-Authored-By: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement integration tests for sparse and dense unions.
Enable them for C++ (only).