ARROW-8450: [Integration][C++] Implement large offsets types #6934
Conversation
Implement integration tests for LargeList, LargeBinary and LargeString types. Enable them for C++ (only).
pitrou
force-pushed
the
ARROW-8450-integ-large-offset-types
branch
from
8d52a87 to
5240b14
Compare
|
AppVeyor build: https://ci.appveyor.com/project/pitrou/arrow/builds/32175567 |
|
Hmm, I notice the 64-bit offsets are serialized as JSON integers. @nealrichardson should they be serialized as strings instead? |
|
@pitrou I believe they should, looking for the relevant JIRA |
|
Hmm, it seems that even the "DATA" of int64 columns is output as JSON integers currently... |
|
Hmmm, that should have been changed in #5267 |
|
That seems to have been lost when it was migrated to Archery. |
bkietz
force-pushed
the
ARROW-8450-integ-large-offset-types
branch
from
8763f37 to
5240b14
Compare
bkietz
left a comment
bkietz
left a comment
There was a problem hiding this comment.
It was surprising to me that GetIntArray and WriteIntField were not being used to handle the data buffers of integer arrays (which would have fixed https://issues.apache.org/jira/browse/ARROW-8471 ). Some deduplication should be possible in a follow up
|
Yes, it seems so. |
|
merging |
2 participants
Implement integration tests for LargeList, LargeBinary and LargeString types.
Enable them for C++ (only).
Also add tests for recursive nested types.