Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix http head method request timeout #1185

Closed

Conversation

heyuyi0906
Copy link
Contributor

@heyuyi0906 heyuyi0906 commented Jul 25, 2020

#764

这里的实现是在ParseHttpMessage中增加了method判断;
似乎还有一种实现办法,利用read_progressively,然后在ProcessHttpResponse再做判断处理,哪种实现会好一些?

@heyuyi0906
Copy link
Contributor Author

image
load balancer ut没能通过,我的改动和load balancer应该没啥关系啊。

@zyearn
Copy link
Member

zyearn commented Jul 27, 2020

是这个单测本身的问题,我重启测试了

@zyearn
Copy link
Member

zyearn commented Jul 27, 2020

@heyuyi0906 现在挂在其它地方了,我看有一个是和http相关的。

@heyuyi0906
Copy link
Contributor Author

@heyuyi0906 现在挂在其它地方了,我看有一个是和http相关的。

好,我看下原因。

@heyuyi0906
Copy link
Contributor Author

似乎是brpc.baidu.com这个域名出问题了?

@chenBright
Copy link
Contributor

关闭该PR,该问题已经在 #2366 修复。

@chenBright chenBright closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants