Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: fix #764
Problem Summary:
解析HTTP HEAD请求的回包时,如果回包header中content-length不为0或者transfer-encoding为shunked,on_headers_complete未返回1,则parser会继续解析body。但是HTTP回包是不包含body部分的,就导致会parser一直等到rpc超时。
brpc/src/brpc/details/http_parser.cpp
Lines 1744 to 1752 in 4fa4bcd
brpc/src/brpc/details/http_parser.cpp
Lines 1753 to 1766 in 4fa4bcd
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: