Fix domain naming service host name buffer length #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanglimingcn
pushed a commit
to yanglimingcn/brpc
that referenced
this pull request
Jun 25, 2023
* extend domain-naming-service hostname length to 256 * extend domain-naming-service hostname length to 256
yanglimingcn
pushed a commit
to yanglimingcn/brpc
that referenced
this pull request
Oct 31, 2023
* extend domain-naming-service hostname length to 256 * extend domain-naming-service hostname length to 256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:#1911
Problem Summary:
hostname maybe exceed to 128 bytes according to RFC 1035 section 2.3.4.
#1965 has fixed this problem, but missing
src/brpc/policy/domain_naming_service.cpp.What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: