Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain naming service host name buffer length #2179

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Fix domain naming service host name buffer length #2179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e7b552
extend domain-naming-service hostname length to 256
ehds Mar 25, 2023
28150b9
extend domain-naming-service hostname length to 256
ehds Mar 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/brpc/policy/domain_naming_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ int DomainNamingService::GetServers(const char* dns_name,
}

// Should be enough to hold host name
char buf[128];
char buf[256];
size_t i = 0;
for (; i < sizeof(buf) - 1 && dns_name[i] != '\0'
&& dns_name[i] != ':' && dns_name[i] != '/'; ++i) {
Expand Down