requirements/requirements.in: It depends on grpc >= 1.34 #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make explicit what is already in requirements.txt with older version you will get errors like this accessing the CAS: [--:--:--][][] WARNING Failed to initialize remote https://freedesktop-sdk-cache.codethink.co.uk:11001: Received http2 header with status: 404
jjardon
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
|
To really update grpc, we need to commit the results of However, I happen to know this will not pass, partly because of new linting errors and partly because of pallets/click#2037 I've been working on this and should have a patch soon to update the requirements and pass tests soon... |
|
This current just updates the minimum version but doesn't refresh the versions we test with, considering these items to be orthogonal, I will go ahead and just merge this right away. Separately I am working on #1494 to hopefully fix the CI in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make explicit what is already in requirements.txt
with older version you will get errors like this accessing the CAS:
[--:--:--][][] WARNING Failed to initialize remote https://freedesktop-sdk-cache.codethink.co.uk:11001: Received http2 header with status: 404