Update requirements and fix resulting problems #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtristan
requested review from
BenjaminSchubert,
cs-shadow and
juergbi
as code owners
gtristan
force-pushed
the
tristan/refresh-deps
branch
3 times, most recently
from
530518c to
0515ca5
Compare
gtristan
changed the title
gtristan
force-pushed
the
tristan/refresh-deps
branch
5 times, most recently
from
0e519ee to
b94575f
Compare
Since around the release of click 8.x, we have an API break in the click.Path() parameter type, where one of it's public members we were relying on has gone missing. See upstream report: pallets/click#2037 This was fairly easy to work around.
gtristan
force-pushed
the
tristan/refresh-deps
branch
from
3ea71c0 to
4b7729c
Compare
Because it is currently raising a lot of false positives.
This includes the new `unspecified-encoding` error which is recently introduced for https://www.python.org/dev/peps/pep-0597/. All text files are now opened in utf8 encoding, binary mode files do not need any special treatment as they are treaded as byte streams, and in one case we silence the warning since we are wrapping the open() call in a CAS API.
…lly. In case github CI is horribly broken, we can use this script to run the CI locally.
This ensures that the script continues to work over time.
gtristan
force-pushed
the
tristan/refresh-deps
branch
from
1912db5 to
712a73e
Compare
…formatting This test was writing the YAML with ruamel.yaml and then asserting that we have the correct provenance, however as ruamel.yaml evolves we cannot be sure that the dump formatting will be exactly the same (as it has in this instance). To avoid confusion, create static copies of the project.conf so that the provenance can be tested properly.
This is due to an upstream issue in recent versions of ruamel.yaml:
https://sourceforge.net/p/ruamel-yaml/tickets/390/
This job used to run standard CI with the `nocover` flag to ensure that the tox env would not set things up with the `usedevelop` flag, which has historically been required for coverage collection for some reason. At this point, we run everything post py37 with the `nocover` flag because all these python versions have broken the cython/coverage combination. Since we *mostly* run CI with `nocover`, there is no point to keep this job around for now.
…lism As of recently, the test_deterministic_source_umask test from src/buildstream/testing/_sourcetests/source_determinism.py has been hanging. This is spuriously reproducible if you run the containers locally on your linux machine and try to run tox repeatedly with the following invocation: tox -e py37-plugins -- -n 4 -k "test_deterministic_source_umask" However, tests are hanging consistently in github CI, often with the last visible line readable in CI being the running of these source tests. It appears that the only way to have tests pass at all in github now is to disable the pytest-xdist parallelism.
gtristan
force-pushed
the
tristan/refresh-deps
branch
from
712a73e to
187d801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates the requirements
.txtfiles to ensure we're testing against versions of python libraries which would be found on systems we run buildstream on today.Some side effects of this include:
ruamel.yamllibrary.github/run-ci.shto help locally reproduce CI in docker environmentspytest-xdistusage again, since this is causing thetest_deterministic_source_umasktest to hang indefinitely in CI