[OPTIQ-282] {fn QUARTER(date)} is unsupported

[benoyantony]

No description provided.

[benoyantony]

Hello Committers,

Could you please review ?

[julianhyde]

I added a test for null values

    tester.checkNull("quarter(cast(null as date))");

and got an error. I think that if you change

    RexNode res =
        rexBuilder.makeCall(
            resType,
            SqlStdOperatorTable.EXTRACT_DATE,
            ImmutableList.of(rexBuilder.makeFlag(TimeUnitRange.MONTH), x));

and remote the resType argument it will correctly infer that the return type when applied to a nullable argument is a nullable BIGINT.

[julianhyde]

I also wanted to check whether the JDBC escape syntax works. I added

    tester.checkScalar("{fn QUARTER(DATE '1969-1-1')}", null, "");

and it failed. You need to add an entry to JdbcToInternalLookupTable.

The patch looks good, and we're close. Fix these two things and I will commit.

[julianhyde]

Checked in as a059f76.