Always check for aliases when deriving data types (apache#13)

olivrlee · Aug 18, 2023 · e03b950 · e03b950
1 parent 5344035
commit e03b950
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/core/src/main/java/org/apache/calcite/sql/SqlDataTypeSpec.java b/core/src/main/java/org/apache/calcite/sql/SqlDataTypeSpec.java
@@ -230,7 +230,11 @@ public RelDataType deriveType(SqlValidator validator) {
    */
   public RelDataType deriveType(SqlValidator validator, boolean nullable) {
     RelDataType type;
-    type = typeNameSpec.deriveType(validator);
+    // check if the type name is being used as an alias before calling `deriveType`
+    type = validator.getCatalogReader().getNamedType(typeNameSpec.getTypeName());
+    if (type == null) {
+      type = typeNameSpec.deriveType(validator);
+    }
 
     // Fix-up the nullability, default is false.
     final RelDataTypeFactory typeFactory = validator.getTypeFactory();

diff --git a/core/src/test/java/org/apache/calcite/test/UdtTest.java b/core/src/test/java/org/apache/calcite/test/UdtTest.java
@@ -29,6 +29,10 @@ private CalciteAssert.AssertThat withUdt() {
         + "     {\n"
         + "       name: 'foo',\n"
         + "       type: 'BIGINT'\n"
+        + "     },\n"
+        + "     {\n"
+        + "       name: 'TIMESTAMP',\n"
+        + "       type: 'TIMESTAMP_WITH_LOCAL_TIME_ZONE'\n"
         + "     }"
         + "   ],\n"
         + "   schemas: [\n"
@@ -71,6 +75,13 @@ private CalciteAssert.AssertThat withUdt() {
     withUdt().query(sql).returns("LD=1\n");
   }
 
+  @Test void testAliasOnBasicType() {
+    final String sql = "select CAST(\"date\" AS TIMESTAMP) as ts "
+        + "from (VALUES ROW(DATE '2020-12-25', 'SameName')) AS \"t\" (\"date\", \"desc\")";
+    withUdt().query(sql).typeIs("[TS TIMESTAMP_WITH_LOCAL_TIME_ZONE NOT NULL]");
+  }
+
+
   /** Test case for
    * <a href="https://issues.apache.org/jira/browse/CALCITE-3045">[CALCITE-3045]
    * NullPointerException when casting null literal to composite user defined type</a>. */