[CELEBORN-1601] Support revise lost shuffles #2746
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxzl25
changed the title
Member
|
@FMX, could you also support the corresponding cli command for the HTTP endpoint to revise lost shuffles? |
Contributor
Author
Sounds good. I'll add the cli command. |
Member
Contributor
Author
|
@SteNicholas Thanks. I have added the CLI command and the API endpoint. Please review this PR when you have time. |
SteNicholas
reviewed
Sep 23, 2024
cli/src/main/scala/org/apache/celeborn/cli/master/MasterSubcommandImpl.scala
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Sep 23, 2024
SteNicholas
reviewed
Sep 23, 2024
SteNicholas
reviewed
Sep 23, 2024
SteNicholas
reviewed
Sep 23, 2024
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala
Outdated
Show resolved
Hide resolved
FMX
force-pushed
the
b1600
branch
2 times, most recently
from
e71ac9e to
1daa172
Compare
turboFei
reviewed
Sep 23, 2024
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
RexXiong
reviewed
Oct 18, 2024
service/src/main/scala/org/apache/celeborn/server/common/HttpService.scala
Outdated
Show resolved
Hide resolved
cli/src/main/scala/org/apache/celeborn/cli/master/ReviseLostShuffleOptions.scala
Show resolved
Hide resolved
Co-authored-by: Nicholas Jiang <programgeek@163.com>
SteNicholas
reviewed
Oct 21, 2024
cli/src/main/scala/org/apache/celeborn/cli/common/CommonOptions.scala
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Oct 21, 2024
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Oct 21, 2024
SteNicholas
reviewed
Oct 21, 2024
...c/main/scala/org/apache/celeborn/service/deploy/master/http/api/v1/ApplicationResource.scala
Outdated
Show resolved
Hide resolved
…scala Co-authored-by: Nicholas Jiang <programgeek@163.com>
Co-authored-by: Nicholas Jiang <programgeek@163.com>
…r/http/api/v1/ApplicationResource.scala Co-authored-by: Nicholas Jiang <programgeek@163.com>
…s.scala Co-authored-by: Nicholas Jiang <programgeek@163.com>
SteNicholas
approved these changes
Oct 21, 2024
Member
|
Thanks. Merged to main(v0.6.0). |
zaynt4606
pushed a commit
to zaynt4606/celeborn
that referenced
this pull request
Oct 21, 2024
### What changes were proposed in this pull request? To support revising lost shuffle IDs in a long-running job such as flink batch jobs. ### Why are the changes needed? 1. To support revise lost shuffles. 2. To add an HTTP endpoint to revise lost shuffles manually. ### Does this PR introduce _any_ user-facing change? NO. ### How was this patch tested? Cluster tests. Closes apache#2746 from FMX/b1600. Lead-authored-by: mingji <fengmingxiao.fmx@alibaba-inc.com> Co-authored-by: Ethan Feng <fengmingxiao.fmx@alibaba-inc.com> Signed-off-by: SteNicholas <programgeek@163.com>
RexXiong
pushed a commit
that referenced
this pull request
Nov 12, 2024
…ffles ### What changes were proposed in this pull request? 1. `GET /api/v1/applications/deleteApps` -> `DELETE /api/v1/applications` 2. `GET /api/v1/applications/reviseLostShuffles` -> `POST /api/v1/applications/revise_lost_shuffles` ### Why are the changes needed? Followup for #2746 ### Does this PR introduce _any_ user-facing change? No, these APIs has not been released yet. ### How was this patch tested? GA. Closes #2892 from turboFei/delete_app. Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To support revising lost shuffle IDs in a long-running job such as flink batch jobs.
Why are the changes needed?
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
Cluster tests.