[CELEBORN-1601][FOLLOWUP] Refine the RESTful apis for revise lost shuffles #2892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
turboFei
changed the title
turboFei
changed the title
turboFei
changed the title
Member
|
@turboFei, is there any tool that could verify the consistency between generated openapi-client code and rest api model? |
SteNicholas
reviewed
Nov 7, 2024
...c/main/scala/org/apache/celeborn/service/deploy/master/http/api/v1/ApplicationResource.scala
Outdated
Show resolved
Hide resolved
SteNicholas
reviewed
Nov 7, 2024
...c/main/scala/org/apache/celeborn/service/deploy/master/http/api/v1/ApplicationResource.scala
Show resolved
Hide resolved
turboFei
force-pushed
the
delete_app
branch
3 times, most recently
from
5134b9b to
4e3bc70
Compare
Member
Author
Not yet now, maybe we can followup it to diff the generated RESTful modules in GA. Raised https://issues.apache.org/jira/browse/CELEBORN-1699 to track |
Member
Author
Addressed in #2893 |
Member
Author
|
Will move the ThreadStack part into #2893 Done. |
turboFei
changed the title
SteNicholas
pushed a commit
that referenced
this pull request
Nov 8, 2024
### What changes were proposed in this pull request? Check the consistency between openapi spec and generated openapi-client code in GA. Fix the ThreadStack model. ### Why are the changes needed? Address comments: #2892 (comment) Followup for #2888 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. It works: https://github.com/apache/celeborn/actions/runs/11733693060/job/32688436233?pr=2893 <img width="1059" alt="image" src="https://github.com/user-attachments/assets/84682976-1b7d-42e0-9b62-2966f3e952d7"> After ThreadStack fixed: <img width="1368" alt="image" src="https://github.com/user-attachments/assets/14a2a08f-dbc2-409c-a4ed-fbfee82e50b5"> Closes #2893 from turboFei/diff_openapi. Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: SteNicholas <programgeek@163.com>
Member
Author
|
rebased the code. |
SteNicholas
reviewed
Nov 8, 2024
cli/src/main/scala/org/apache/celeborn/cli/master/MasterSubcommandImpl.scala
Outdated
Show resolved
Hide resolved
FMX
approved these changes
Nov 11, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
Thanks. A modernized HTTP API implementation. LGTM.
RexXiong
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
GET /api/v1/applications/deleteApps->DELETE /api/v1/applicationsGET /api/v1/applications/reviseLostShuffles->POST /api/v1/applications/revise_lost_shufflesWhy are the changes needed?
Followup for #2746
Does this PR introduce any user-facing change?
No, these APIs has not been released yet.
How was this patch tested?
GA.