[CELEBORN-1697] Improve ThreadStackTrace for thread dump #2888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
CELEBORN-1697
branch
from
5edfe16 to
0300838
Compare
SteNicholas
force-pushed
the
CELEBORN-1697
branch
from
0300838 to
6320bf3
Compare
turboFei
approved these changes
Nov 6, 2024
FMX
approved these changes
Nov 7, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.6.0).
This was referenced Nov 7, 2024
SteNicholas
pushed a commit
that referenced
this pull request
Nov 8, 2024
### What changes were proposed in this pull request? Check the consistency between openapi spec and generated openapi-client code in GA. Fix the ThreadStack model. ### Why are the changes needed? Address comments: #2892 (comment) Followup for #2888 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. It works: https://github.com/apache/celeborn/actions/runs/11733693060/job/32688436233?pr=2893 <img width="1059" alt="image" src="https://github.com/user-attachments/assets/84682976-1b7d-42e0-9b62-2966f3e952d7"> After ThreadStack fixed: <img width="1368" alt="image" src="https://github.com/user-attachments/assets/14a2a08f-dbc2-409c-a4ed-fbfee82e50b5"> Closes #2893 from turboFei/diff_openapi. Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: SteNicholas <programgeek@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve
ThreadStackTracewithsynchronizers,monitors,lockName,lockOwnerName,suspended,inNativefor thread dump.Why are the changes needed?
ThreadStackTrace does not support stack trace including
synchronizers,monitors,lockName,lockOwnerName,suspended,inNativeat present. It's recommend to improveThreadStackTraceof thread dump for more details of thread stack trace.Does this PR introduce any user-facing change?
The response of
ThreadStackin/api/v1/thread_dumpaddssynchronizers,monitors,lockName,lockOwnerName,suspended,inNativefields.Cherry pick:
How was this patch tested?
ApiV1BaseResourceSuite#thread_dump