-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: update basic community files for ASF #696
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuhaihe
changed the title
Feature: update basic community files for ASF
[WIP] Feature: update basic community files for ASF
Nov 1, 2024
tuhaihe
changed the title
[WIP] Feature: update basic community files for ASF
Feature: update basic community files for ASF
Nov 5, 2024
yjhnupt
approved these changes
Nov 5, 2024
yjhjstz
previously approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9 tasks
tuhaihe
force-pushed
the
readme_asf
branch
2 times, most recently
from
November 23, 2024 15:53
538bbd6
to
8c49e4b
Compare
tuhaihe
changed the title
Feature: update basic community files for ASF
Doc: update basic community files for ASF
Nov 23, 2024
In this commit, basic community files are udpated to follow the Apache rules and requests, including CoC, Security policy, and other places for a good project name.
tuhaihe
commented
Nov 25, 2024
gfphoenix78
approved these changes
Nov 25, 2024
my-ship-it
approved these changes
Nov 25, 2024
edespino
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
My only followup is for us to consider adding the Apache Incubator Podling Powered by circle with Cloudberry logo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #ISSUE_Number
Change logs
In this commit, basic community files are udpated to follow the Apache rules and requests, including CoC, Security policy, and other places for a good project name.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel
cloudberrydb/dev
team for review and approval when your PR is ready🥳