-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip ci] Doc: fix org change that link dead for discuss #707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiiii, @yihong0618 welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Hi @yihong0618, thank you! There is already a PR #696 for the link changes. Please feel free to rebase your commit once #696 is merged. BTW, welcome to take the git commit template to amend your commit title and body. Thanks again! |
@tuhaihe the issue created is dead in cloudberry it will link a 404 page, maybe we can merge this two pull requests |
Agreed. Welcome to rebase to trigger the CI (now can use the tag ‘skip ci ‘ to skip the checks) then merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yihong0618 welcome to resolve the conflicts.
Also please amend your commit messages per the template - https://github.com/apache/cloudberry/blob/main/.gitmessage, thanks.
fix some of the links are wrong since org changed from cloudberry to apache. Signed-off-by: yihong0618 <zouzou0208@gmail.com>
ea8e5b6
to
a8a3b23
Compare
done |
Hi @edespino have added the tag |
@tuhaihe - I believe the |
fix #ISSUE_Number
Change logs
As cloudberry the org changed to apache now, most of the links can redirect but for the discuss such as orgs/cloudberry/discuss can not, this PR fix that case.
you can try:
link dead: https://github.com/orgs/cloudberrydb/discussions/categories/proposal
link fixed: url: https://github.com/apache/cloudberrydb/discussions/categories/proposal
for the case it may graduate from apache some day so keep the urls can redirect first.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel
cloudberrydb/dev
team for review and approval when your PR is ready🥳